2788 Add ellipsis in log component #561

Merged
carlosjr merged 11 commits from 2788-add-ellipsize_log-component into dev 2021-03-05 11:36:46 +00:00
First-time contributor
No description provided.
Ghost added 3 commits 2021-03-02 13:42:04 +00:00
Ghost added 1 commit 2021-03-02 13:44:33 +00:00
gitea/salix/pipeline/head This commit looks good Details
022d31c952
remove line break
Ghost changed title from 2788-add-ellipsize_log-component to 2788 Add ellipsis log component 2021-03-02 13:47:02 +00:00
Ghost changed title from 2788 Add ellipsis log component to 2788 Add ellipsis in log component 2021-03-02 13:47:40 +00:00
carlosjr requested changes 2021-03-03 12:35:09 +00:00
@ -71,3 +71,2 @@
<div>
<span translate class="label">{{::old.key}}</span><span class="label">: </span>
<span translate class="value">{{::old.value | dashIfEmpty}}</span>
<span translate class="label labelAlign">{{::old.key}}</span><span class="label labelAlign">: </span>
Contributor

alignSpan

alignSpan
Ghost marked this conversation as resolved
@ -82,3 +82,2 @@
<div>
<span translate class="label">{{::new.key}}</span><span class="label">: </span>
<span translate class="value">{{::new.value | dashIfEmpty}}</span>
<span translate class="label labelAlign">{{::new.key}}</span><span class="label labelAlign">: </span>
Contributor

try not to exceed 80 characters per line

try not to exceed 80 characters per line
Author
First-time contributor

If i put a line break between spans, the browser detect a space between spans and this space produce an error on tests.

If i put a line break between spans, the browser detect a space between spans and this space produce an error on tests.
carlosjr marked this conversation as resolved
@ -26,0 +31,4 @@
max-width: 400px;
text-overflow: ellipsis;
display: inline-block;
}
Contributor

it's a span

it's a span
Ghost marked this conversation as resolved
Ghost added 7 commits 2021-03-05 10:57:20 +00:00
carlosjr approved these changes 2021-03-05 11:36:31 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
carlosjr merged commit f01733a8b1 into dev 2021-03-05 11:36:46 +00:00
carlosjr deleted branch 2788-add-ellipsize_log-component 2021-03-05 11:36:54 +00:00
joan deleted branch 2788-add-ellipsize_log-component 2021-03-15 15:47:26 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#561
No description provided.