verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

2811 Show how many lines are going to edit #572

Merged
joan merged 12 commits from 2811-entry_latest_buys into dev 2021-03-23 11:44:35 +00:00
Conversation 0 Commits 12 Files Changed 6 +42 -2259
Ghost commented 2021-03-12 09:05:39 +00:00
First-time contributor
Copy Link
No description provided.
Ghost added 4 commits 2021-03-12 09:05:40 +00:00
joan requested changes 2021-03-12 17:11:24 +00:00
modules/entry/front/latest-buys/index.html Outdated
@ -170,1 +168,4 @@
on-close="$ctrl.editedColumn = null">
<tpl-body>
<vn-horizontal>
<span style="font-size: 16px; font-weight: 600; max-width: 50px;">Editar</span>
joan commented 2021-03-12 17:11:04 +00:00
Contributor
Copy Link

Recorda no ficar paraules en espanyol. Sempre fica les traduccions.
Intenta evitar també ficar estils directament en el html

Recorda no ficar paraules en espanyol. Sempre fica les traduccions. Intenta evitar també ficar estils directament en el html
Ghost commented 2021-03-16 07:22:57 +00:00
Author
First-time contributor
Copy Link

Val això se ma passat, ara eu corregisc

Val això se ma passat, ara eu corregisc
Ghost marked this conversation as resolved
modules/entry/front/latest-buys/style.scss
@ -0,0 +1,12 @@
.countLines {
joan commented 2021-03-12 17:11:15 +00:00
Contributor
Copy Link

No estan gastantse les clases?

No estan gastantse les clases?
Ghost commented 2021-03-15 14:24:20 +00:00
Author
First-time contributor
Copy Link

Les vuic gastar per no ficar styles en el html, pero no me els agafa quan les cride en el html, he fet el anar cridant de major a menor pero tampoc fa res. Si no hi ha solució es borrar ixes classes i pujar com està.

Les vuic gastar per no ficar styles en el html, pero no me els agafa quan les cride en el html, he fet el anar cridant de major a menor pero tampoc fa res. Si no hi ha solució es borrar ixes classes i pujar com està.
joan commented 2021-03-15 16:23:39 +00:00
Contributor
Copy Link

Te fa falta fer el require en el controlador

Te fa falta fer el require en el controlador
Ghost marked this conversation as resolved
carlosjr added the
Needs refactor
 label 2021-03-16 08:26:54 +00:00
Ghost added 3 commits 2021-03-18 12:52:14 +00:00
Ghost removed the
Needs refactor
 label 2021-03-18 12:52:25 +00:00
carlosjr requested changes 2021-03-22 08:53:34 +00:00
modules/entry/front/latest-buys/index.html Outdated
@ -169,2 +168,3 @@
message="Edit buy(s)">
on-close="$ctrl.editedColumn = null">
<tpl-body>
<vn-horizontal>
carlosjr commented 2021-03-22 08:53:19 +00:00
Contributor
Copy Link

You don't need a vn-horizontal here. Also all three spans don't need most the styles applied to them.

You don't need a vn-horizontal here. Also all three spans don't need most the styles applied to them.
Ghost marked this conversation as resolved
Ghost added 4 commits 2021-03-22 09:46:05 +00:00
Ghost added 1 commit 2021-03-23 08:44:55 +00:00
joan approved these changes 2021-03-23 11:41:44 +00:00
carlosjr approved these changes 2021-03-23 11:44:15 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
joan merged commit e2db0d5742 into dev 2021-03-23 11:44:35 +00:00
joan deleted branch 2811-entry_latest_buys 2021-03-23 11:44:53 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#572
No description provided.
Delete Branch "2811-entry_latest_buys"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?