2873-create-supplier-beneficiary #593

Merged
carlosjr merged 9 commits from 2873-create-supplier-beneficiary into dev 2021-04-21 13:29:29 +00:00
Owner
No description provided.
jgallego added 2 commits 2021-04-01 15:37:23 +00:00
gitea/salix/pipeline/head This commit looks good Details
c036c7c7fe
model ok
jgallego added 1 commit 2021-04-01 15:38:18 +00:00
gitea/salix/pipeline/head This commit looks good Details
eec901684a
reviso test
jgallego added 1 commit 2021-04-01 16:38:49 +00:00
gitea/salix/pipeline/head This commit looks good Details
336472291d
test
jgallego added 1 commit 2021-04-01 16:40:15 +00:00
jgallego added 1 commit 2021-04-01 16:43:36 +00:00
gitea/salix/pipeline/head This commit looks good Details
63ec7677c6
test ok
carlosjr was assigned by jgallego 2021-04-01 16:48:04 +00:00
carlosjr requested changes 2021-04-14 08:04:35 +00:00
@ -0,0 +9,4 @@
let error;
const expectedError = 'The IBAN does not have the correct format';
const iban = 'incorrect format';
// si falla el error es extraño preguntar a carlos
Contributor

I would wrap this cone into a try-catch

I would wrap this cone into a try-catch
carlosjr marked this conversation as resolved
@ -0,0 +32,4 @@
const options = {transaction: tx};
const iban = 'ES91 2100 0418 4502 0005 1332';
const activeCtx = {
Contributor

I would move lines from 35 to 49 to the begining of the test as they are just a mock

I would move lines from 35 to 49 to the begining of the test as they are just a mock
@ -0,0 +48,4 @@
active: activeCtx
});
const createdSupplierAccount = await app.models.SupplierAccount.create(
{
Contributor

I would move the { to the begining of the previous line and the "," should be at the end of the previous line.

I would move the { to the begining of the previous line and the "," should be at the end of the previous line.
carlosjr marked this conversation as resolved
@ -0,0 +5,4 @@
message: 'The IBAN does not have the correct format'
});
async function ibanNeedsValidation(err, done) {
Contributor

since this method doesn-t return a boolean I would recommend "ibanValidation" for the name

since this method doesn-t return a boolean I would recommend "ibanValidation" for the name
carlosjr marked this conversation as resolved
jgallego added 1 commit 2021-04-16 16:34:49 +00:00
jgallego added 1 commit 2021-04-16 16:35:15 +00:00
gitea/salix/pipeline/head This commit looks good Details
cd4f93f326
minor fixes
carlosjr approved these changes 2021-04-21 13:21:03 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
carlosjr added 1 commit 2021-04-21 13:21:38 +00:00
carlosjr approved these changes 2021-04-21 13:22:00 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
carlosjr merged commit 2630fa8c43 into dev 2021-04-21 13:29:29 +00:00
carlosjr deleted branch 2873-create-supplier-beneficiary 2021-04-21 13:29:37 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#593
No description provided.