2873-create-supplier-beneficiary #593
No reviewers
Labels
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: verdnatura/salix#593
Loading…
Reference in New Issue
No description provided.
Delete Branch "2873-create-supplier-beneficiary"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -0,0 +9,4 @@
let error;
const expectedError = 'The IBAN does not have the correct format';
const iban = 'incorrect format';
// si falla el error es extraño preguntar a carlos
I would wrap this cone into a try-catch
@ -0,0 +32,4 @@
const options = {transaction: tx};
const iban = 'ES91 2100 0418 4502 0005 1332';
const activeCtx = {
I would move lines from 35 to 49 to the begining of the test as they are just a mock
@ -0,0 +48,4 @@
active: activeCtx
});
const createdSupplierAccount = await app.models.SupplierAccount.create(
{
I would move the { to the begining of the previous line and the "," should be at the end of the previous line.
@ -0,0 +5,4 @@
message: 'The IBAN does not have the correct format'
});
async function ibanNeedsValidation(err, done) {
since this method doesn-t return a boolean I would recommend "ibanValidation" for the name
LGTM
LGTM