verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

fix(payMethod): alter colums name #793

Merged
carlosjr merged 6 commits from 3379-payMethod_ibanRequired into dev 2021-11-22 14:55:34 +00:00
Conversation 0 Commits 6 Files Changed 7 +11 -7
vicent commented 2021-11-19 09:22:36 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2021-11-19 09:22:36 +00:00
vicent added 1 commit 2021-11-19 09:22:37 +00:00
gitea/salix/pipeline/head This commit looks good Details
8f2e29787b fix(payMethod): alter colums name
carlosjr added 1 commit 2021-11-19 11:40:12 +00:00
gitea/salix/pipeline/head This commit looks good Details
7eba2fe509 Merge branch 'dev' into 3379-payMethod_ibanRequired
carlosjr requested changes 2021-11-19 11:45:38 +00:00
modules/client/back/models/client.js Outdated
@ -139,3 +139,3 @@
function hasIban(err, done) {
Self.app.models.PayMethod.findById(this.payMethodFk, (_, instance) => {
if (instance && instance.ibanRequiredForClients && !this.iban)
if (instance && instance.isIbanRequiredForClients && !this.iban)
carlosjr commented 2021-11-19 11:45:14 +00:00
Contributor
Copy Link

try extracting logic gates to constants like:

        const isMissingIban = instance && instance.ibanRequiredForClients && !this.iban;
        if (isMissingIban)
try extracting logic gates to constants like: const isMissingIban = instance && instance.ibanRequiredForClients && !this.iban; if (isMissingIban)
modules/supplier/back/models/supplier.js Outdated
@ -81,3 +81,3 @@
const hasIban = supplierAccount && supplierAccount.iban;
if (payMethod && payMethod.ibanRequiredForSuppliers && !hasIban)
if (payMethod && payMethod.isIbanRequiredForSuppliers && !hasIban)
carlosjr commented 2021-11-19 11:45:29 +00:00
Contributor
Copy Link

same as above

same as above
carlosjr removed the
CR / Tests passed
 label 2021-11-19 11:45:49 +00:00
vicent added 2 commits 2021-11-22 12:44:37 +00:00
vicent added the
CR / Tests passed
 label 2021-11-22 13:10:51 +00:00
carlosjr added 1 commit 2021-11-22 13:32:28 +00:00
gitea/salix/pipeline/head This commit looks good Details
ff0a3acd6e Merge branch 'dev' into 3379-payMethod_ibanRequired
carlosjr approved these changes 2021-11-22 13:32:42 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr added 1 commit 2021-11-22 14:21:53 +00:00
gitea/salix/pipeline/head This commit looks good Details
cbcfdd33ec Merge branch 'dev' into 3379-payMethod_ibanRequired
carlosjr merged commit c618b7c2ed into dev 2021-11-22 14:55:34 +00:00
carlosjr deleted branch 3379-payMethod_ibanRequired 2021-11-22 14:55:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#793
No description provided.
Delete Branch "3379-payMethod_ibanRequired"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?