verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

3372-ticket_sale multi-check for recalculatePrice #811

Merged
carlosjr merged 7 commits from 3372-ticket_sale into dev 2021-12-01 12:55:56 +00:00
Conversation 1 Commits 7 Files Changed 9 +203 -29
alexm commented 2021-11-29 07:32:03 +00:00
Member
Copy Link
No description provided.
alexm added the
CR / Tests passed
 label 2021-11-29 07:32:03 +00:00
alexm added 1 commit 2021-11-29 07:32:05 +00:00
alexm removed the
CR / Tests passed
 label 2021-11-29 09:47:01 +00:00
alexm changed title from 3372-ticket_sale multi-check for recalculatePrice to WIP: 3372-ticket_sale multi-check for recalculatePrice 2021-11-29 09:47:07 +00:00
alexm added 2 commits 2021-11-30 12:47:34 +00:00
gitea/salix/pipeline/head This commit looks good Details
d5c0be5a9d refactor(ticket_sale): logic and tests
alexm commented 2021-11-30 12:50:21 +00:00
Author
Member
Copy Link

A la espera de saber que hacer con el procedimiento vn.sale_calculateComponent()

A la espera de saber que hacer con el procedimiento vn.sale_calculateComponent()
alexm added 1 commit 2021-11-30 14:13:37 +00:00
gitea/salix/pipeline/head This commit looks good Details
decd4b5a95 separate sql procedures
alexm added 1 commit 2021-11-30 14:14:00 +00:00
alexm changed title from WIP: 3372-ticket_sale multi-check for recalculatePrice to 3372-ticket_sale multi-check for recalculatePrice 2021-12-01 08:41:50 +00:00
alexm added the
CR / Tests passed
 label 2021-12-01 08:42:48 +00:00
carlosjr requested changes 2021-12-01 09:27:32 +00:00
modules/ticket/back/methods/sale/recalculatePrice.js Outdated
@ -12,3 +11,4 @@
http: {source: 'body'}
}],
returns: {
type: 'Number',
carlosjr commented 2021-12-01 09:26:37 +00:00
Contributor
Copy Link

number

number
alexm marked this conversation as resolved
modules/ticket/front/sale/index.js
@ -457,0 +453,4 @@
const sales = this.selectedValidSales();
if (!sales) return;
const params = sales;
carlosjr commented 2021-12-01 09:27:12 +00:00
Contributor
Copy Link

not needed

not needed
alexm marked this conversation as resolved
modules/ticket/front/sale/index.spec.js Outdated
@ -690,3 +690,2 @@
const selectedSale = controller.sales[0];
selectedSale.checked = true;
const selectedSaleOne = controller.sales[0];
carlosjr commented 2021-12-01 09:27:28 +00:00
Contributor
Copy Link

try using iteration

try using iteration
alexm marked this conversation as resolved
alexm added 2 commits 2021-12-01 10:40:04 +00:00
gitea/salix/pipeline/head This commit looks good Details
75e32feb16 refactor ticket_sale
alexm requested review from carlosjr 2021-12-01 10:40:59 +00:00
carlosjr approved these changes 2021-12-01 12:55:48 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit bc2b2f37e8 into dev 2021-12-01 12:55:56 +00:00
carlosjr deleted branch 3372-ticket_sale 2021-12-01 12:56:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#811
No description provided.
Delete Branch "3372-ticket_sale"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?