verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 65 Releases Wiki Activity

3426-ticket_search_panel filter by route #821

Merged
carlosjr merged 5 commits from 3426-ticket_index into dev 2021-12-21 11:08:17 +00:00
Conversation 0 Commits 5 Files Changed 4 +75 -1
alexm commented 2021-12-14 11:06:55 +00:00
Member
Copy Link
No description provided.
alexm added the
CR / Tests passed
 label 2021-12-14 11:06:55 +00:00
alexm added 1 commit 2021-12-14 11:06:55 +00:00
gitea/salix/pipeline/head This commit looks good Details
9cfe6b5b7a feat(ticket): filter by route
alexm added 1 commit 2021-12-14 11:44:15 +00:00
carlosjr requested changes 2021-12-20 09:57:27 +00:00
modules/ticket/back/methods/ticket/filter.js Outdated
@ -84,2 +84,4 @@
description: `Whether to show only tickets with problems`
},
{
arg: 'route',
carlosjr commented 2021-12-20 09:55:22 +00:00
Contributor
Copy Link

booleans are commonly named with has, is... as described by sql convention

in this case use hasRoute

booleans are commonly named with has, is... as described by sql convention in this case use hasRoute
joan marked this conversation as resolved
modules/ticket/front/search-panel/locale/es.yml Outdated
@ -12,6 +12,7 @@ Order id: Id cesta
Grouped States: Estado agrupado
Days onward: Días adelante
With problems: Con problemas
With route: Con ruta
carlosjr commented 2021-12-20 09:57:21 +00:00
Contributor
Copy Link

Has route

Has route
joan marked this conversation as resolved
alexm added 2 commits 2021-12-21 07:53:03 +00:00
gitea/salix/pipeline/head This commit looks good Details
831bfb0352 change route for hasRoute
joan added 1 commit 2021-12-21 08:29:17 +00:00
gitea/salix/pipeline/head This commit looks good Details
018e3cc8f6 Merge branch 'dev' into 3426-ticket_index
joan approved these changes 2021-12-21 08:36:11 +00:00
joan left a comment
Contributor
Copy Link

LGTM, tests passed

LGTM, tests passed
carlosjr approved these changes 2021-12-21 11:08:08 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit 35a24cecfa into dev 2021-12-21 11:08:17 +00:00
carlosjr deleted branch 3426-ticket_index 2021-12-21 11:08:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#821
No description provided.
Delete Branch "3426-ticket_index"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?