3247-refactor(ticket): add more text in the error when change zone #841

alexm · 2022-01-07T07:31:09Z

alexm commented

2022-01-07 07:31:09 +00:00

No description provided.

alexm added the

CR / Tests passed

Simple

labels 2022-01-07 07:31:09 +00:00

alexm added 1 commit 2022-01-07 07:31:10 +00:00

gitea/salix/pipeline/head This commit looks good Details

860499db82 refactor(ticket): add more text in error when change zone

carlosjr requested changes 2022-01-10 09:58:32 +00:00

modules/ticket/back/methods/ticket/priceDifference.js Outdated

						
				@ -84,2 +84,2 @@

				                if (!zoneShipped || zoneShipped.zoneFk != args.zoneId)

				                    throw new UserError(`You don't have privileges to change the zone`);

				                if (!zoneShipped || zoneShipped.zoneFk != args.zoneId) {

				                    throw new UserError(`You don't have privileges to change the zone

carlosjr commented

2022-01-10 09:58:06 +00:00

there are some typos on the error message, here's the correction:

'You don't have privileges to change the zone or for these parameters there are more than one shipping options, talk to agencies'

Also try extracting long arguments to constants.

there are some typos on the error message, here's the correction: 'You don't have privileges to change the zone or for these parameters there are more than one shipping options, talk to agencies' Also try extracting long arguments to constants.

alexm added 1 commit 2022-01-10 10:38:13 +00:00