verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

3620-feat(claim): implemented smart-table and change state in summary #887

Merged
carlosjr merged 6 commits from 3620-claim_change_state into dev 2022-03-02 10:12:52 +00:00
Conversation 0 Commits 6 Files Changed 10 +243 -92
alexm commented 2022-02-28 11:49:57 +00:00
Member
Copy Link
No description provided.
alexm added the
CR / Tests passed
 label 2022-02-28 11:49:57 +00:00
alexm added 3 commits 2022-02-28 11:49:58 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
5434dd3baf feat(claim_index): implemented smart-table and change state in summary
alexm changed title from 3620-claim_change_state to 3620-feat(claim): implemented smart-table and change state in summary 2022-02-28 11:51:58 +00:00
carlosjr requested changes 2022-03-02 09:44:44 +00:00
modules/claim/front/main/index.js Outdated
@ -5,3 +9,3 @@
ngModule.vnComponent('vnClaim', {
controller: Claim,
controller: Claims,
carlosjr commented 2022-03-02 09:37:08 +00:00
Contributor
Copy Link

if the controller has no functionality implemented you can you the extending "ModuleMain" as a controller.

ie: controller: ModuleMain :)

if the controller has no functionality implemented you can you the extending "ModuleMain" as a controller. ie: controller: ModuleMain :)
alexm marked this conversation as resolved
modules/claim/front/summary/index.js Outdated
@ -14,0 +25,4 @@
.then(() => {
if (this.card)
this.card.reload();
// Refresh index model
carlosjr commented 2022-03-02 09:39:00 +00:00
Contributor
Copy Link

this comment is not needed for self explanatory code.

this comment is not needed for self explanatory code.
alexm marked this conversation as resolved
modules/claim/front/summary/index.spec.js Outdated
@ -31,3 +45,2 @@
describe('$onChanges()', () => {
it('should call getSummary when item.id is defined', () => {
jest.spyOn(controller, 'getSummary');
it('should call loadData when item.id is defined', () => {
carlosjr commented 2022-03-02 09:44:39 +00:00
Contributor
Copy Link

when item.id is defined, perhaps "when $onChanges is called"

when item.id is defined, perhaps "when $onChanges is called"
alexm marked this conversation as resolved
carlosjr removed the
CR / Tests passed
 label 2022-03-02 09:46:02 +00:00
alexm added 3 commits 2022-03-02 10:07:44 +00:00
gitea/salix/pipeline/head This commit looks good Details
619baf2896 refactor claim_main controller
alexm requested review from carlosjr 2022-03-02 10:11:18 +00:00
carlosjr added the
CR / Tests passed
 label 2022-03-02 10:11:48 +00:00
carlosjr approved these changes 2022-03-02 10:11:58 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit d923209c2d into dev 2022-03-02 10:12:52 +00:00
carlosjr deleted branch 3620-claim_change_state 2022-03-02 10:12:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#887
No description provided.
Delete Branch "3620-claim_change_state"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?