3671-supplier_account #889

alexm · 2022-03-01T10:38:03Z

alexm commented

2022-03-01 10:38:03 +00:00

No description provided.

alexm added the

CR / Tests passed

label 2022-03-01 10:38:03 +00:00

alexm added 2 commits 2022-03-01 10:38:04 +00:00

2137a34b36 feat(supplier-account): isPayMethodChecked false when change model

gitea/salix/pipeline/head This commit looks good Details

a27a48f251 fix(supplier_account): fix setWireTransfer and add test

joan requested changes 2022-03-03 11:03:06 +00:00

modules/supplier/back/models/supplier-account.js

						
				@ -37,0 +38,4 @@

				    Self.observe('after save', async ctx => {

				        const options = {};

				        // Check for transactions

joan commented

2022-03-03 11:00:11 +00:00

Self explanatory code doesn't need comments

alexm marked this conversation as resolved

modules/supplier/back/models/supplier-account.js

						
				@ -37,0 +41,4 @@

				        // Check for transactions

				        if (ctx.options && ctx.options.transaction)

				            options.transaction = ctx.options.transaction;

				        const supplier = await Self.app.models.Supplier.findById(ctx.instance.supplierFk, options);

joan commented

2022-03-03 10:59:34 +00:00

The "options" argument should be used as third argument as described on:
https://apidocs.loopback.io/loopback/#persistedmodel-findbyid

Second argument should be the filter object or null if not needed

The "options" argument should be used as third argument as described on: https://apidocs.loopback.io/loopback/#persistedmodel-findbyid Second argument should be the filter object or null if not needed

alexm marked this conversation as resolved

joan removed the

CR / Tests passed

label 2022-03-03 11:03:17 +00:00

alexm added 2 commits 2022-03-03 12:48:39 +00:00

29d63d1e4d Merge branch 'dev' of https://gitea.verdnatura.es/verdnatura/salix into 3671-supplier_account

gitea/salix/pipeline/head This commit looks good Details

6748426f67 correct loopback form

alexm requested review from joan 2022-03-03 12:48:51 +00:00

carlosjr approved these changes 2022-03-04 08:39:41 +00:00

carlosjr left a comment

LGTM