3671-supplier_account #889

Merged
carlosjr merged 5 commits from 3671-supplier_account into dev 2022-03-04 08:59:38 +00:00
4 changed files with 96 additions and 16 deletions

View File

@ -1,16 +1,28 @@
const app = require('vn-loopback/server/server'); const models = require('vn-loopback/server/server').models;
const LoopBackContext = require('loopback-context'); const LoopBackContext = require('loopback-context');
describe('loopback model Supplier-account', () => { describe('loopback model Supplier-account', () => {
describe('create', () => { describe('create', () => {
const supplierId = 1; const supplierId = 1;
const bankEntityId = 2100; const bankEntityId = 2100;
const activeCtx = {
accessToken: {userId: 5},
http: {
req: {
headers: {origin: 'http://localhost'}
}
}
};
activeCtx.http.req.__ = value => {
return value;
};
it('should throw an error when attempting to set an invalid iban account', async() => { it('should throw an error when attempting to set an invalid iban account', async() => {
let error; let error;
const expectedError = 'The IBAN does not have the correct format'; const expectedError = 'The IBAN does not have the correct format';
const iban = 'incorrect format'; const iban = 'incorrect format';
try { try {
await app.models.SupplierAccount.create( await models.SupplierAccount.create(
{ {
supplierFk: supplierId, supplierFk: supplierId,
bankEntityFk: bankEntityId, bankEntityFk: bankEntityId,
@ -26,27 +38,16 @@ describe('loopback model Supplier-account', () => {
}); });
it('should create a valid supplier account', async() => { it('should create a valid supplier account', async() => {
const tx = await app.models.Claim.beginTransaction({}); const tx = await models.SupplierAccount.beginTransaction({});
try { try {
const options = {transaction: tx}; const options = {transaction: tx};
const iban = 'ES91 2100 0418 4502 0005 1332'; const iban = 'ES91 2100 0418 4502 0005 1332';
const activeCtx = {
accessToken: {userId: 5},
http: {
req: {
headers: {origin: 'http://localhost'}
}
}
};
activeCtx.http.req.__ = value => {
return value;
};
spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({ spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
active: activeCtx active: activeCtx
}); });
const createdSupplierAccount = await app.models.SupplierAccount.create({
const createdSupplierAccount = await models.SupplierAccount.create({
supplierFk: supplierId, supplierFk: supplierId,
bankEntityFk: bankEntityId, bankEntityFk: bankEntityId,
iban: iban iban: iban
@ -60,5 +61,35 @@ describe('loopback model Supplier-account', () => {
throw e; throw e;
} }
}); });
it('should change isPayMethodChecked to false', async() => {
const tx = await models.SupplierAccount.beginTransaction({});
try {
const options = {transaction: tx};
const iban = 'ES91 2100 0418 4502 0005 1332';
spyOn(LoopBackContext, 'getCurrentContext').and.returnValue({
active: activeCtx
});
const supplierBefore = await models.Supplier.findById(supplierId, null, options);
await models.SupplierAccount.create({
supplierFk: supplierId,
bankEntityFk: bankEntityId,
iban: iban
},
options);
const supplierAfter = await models.Supplier.findById(supplierId, null, options);
expect(supplierBefore.isPayMethodChecked).toBeTruthy();
expect(supplierAfter.isPayMethodChecked).toBeFalsy();
await tx.rollback();
} catch (e) {
await tx.rollback();
throw e;
}
});
}); });
}); });

View File

@ -34,4 +34,15 @@ module.exports = Self => {
ctx.instance.iban + ', entidad: ' + bankEntity.name + ', bic: ' + bankEntity.bic ctx.instance.iban + ', entidad: ' + bankEntity.name + ', bic: ' + bankEntity.bic
}); });
}); });
Self.observe('after save', async ctx => {
const options = {};
if (ctx.options && ctx.options.transaction)
alexm marked this conversation as resolved
Review

Self explanatory code doesn't need comments

Self explanatory code doesn't need comments
options.transaction = ctx.options.transaction;
const supplier = await Self.app.models.Supplier.findById(ctx.instance.supplierFk, null, options);
alexm marked this conversation as resolved
Review

The "options" argument should be used as third argument as described on:
https://apidocs.loopback.io/loopback/#persistedmodel-findbyid

Second argument should be the filter object or null if not needed

The "options" argument should be used as third argument as described on: https://apidocs.loopback.io/loopback/#persistedmodel-findbyid Second argument should be the filter object or null if not needed
if (supplier.isPayMethodChecked)
await supplier.updateAttribute('isPayMethodChecked', false, options);
});
}; };

View File

@ -45,6 +45,16 @@ class Controller extends Section {
this.$.payMethodToTransfer.show(); this.$.payMethodToTransfer.show();
}); });
} }
setWireTransfer() {
const params = {
id: this.$params.id,
payMethodFk: this.wireTransferFk
};
const query = `Suppliers/${this.$params.id}`;
return this.$http.patch(query, params)
.then(() => this.$.watcher.notifySaved());
}
} }
ngModule.vnComponent('vnSupplierAccount', { ngModule.vnComponent('vnSupplierAccount', {

View File

@ -5,9 +5,12 @@ import crudModel from 'core/mocks/crud-model';
describe('Supplier Component vnSupplierAccount', () => { describe('Supplier Component vnSupplierAccount', () => {
let $scope; let $scope;
let controller; let controller;
let $httpBackend;
beforeEach(ngModule('supplier')); beforeEach(ngModule('supplier'));
beforeEach(inject(($componentController, $rootScope, _$httpBackend_) => { beforeEach(inject(($componentController, $rootScope, _$httpBackend_) => {
$httpBackend = _$httpBackend_;
$scope = $rootScope.$new(); $scope = $rootScope.$new();
$scope.model = crudModel; $scope.model = crudModel;
$scope.watcher = watcher; $scope.watcher = watcher;
@ -66,5 +69,30 @@ describe('Supplier Component vnSupplierAccount', () => {
}).catch(done.fail); }).catch(done.fail);
}); });
}); });
describe('setWireTransfer()', () => {
it(`should make HTTP PATCH request to set wire transfer and call notifySaved`, () => {
const supplierId = 1;
const params = {
id: supplierId,
payMethodFk: 2
};
const response = {
data: {id: 2}
};
const uri = 'payMethods/findOne?filter=%7B%22where%22:%7B%22code%22:%22wireTransfer%22%7D%7D';
jest.spyOn($scope.watcher, 'notifySaved');
controller.$params.id = supplierId;
controller.wireTransferFk = 2;
controller.supplier = {payMethodFk: 1};
$httpBackend.expectGET(uri).respond(response);
$httpBackend.expectPATCH(`Suppliers/${supplierId}`, params).respond();
controller.setWireTransfer();
$httpBackend.flush();
expect($scope.watcher.notifySaved).toHaveBeenCalledWith();
});
});
}); });