verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 66 Releases Wiki Activity

3607-supplier_agencyTerm #905

Merged
carlosjr merged 22 commits from 3607-supplier_agencyTerm into dev 2022-03-29 08:03:03 +00:00
Conversation 0 Commits 22 Files Changed 24 +501 -18
vicent commented 2022-03-21 11:04:53 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-03-21 11:04:53 +00:00
vicent added 15 commits 2022-03-21 11:04:54 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
a32ebc37da add supplier autonomous
gitea/salix/pipeline/head There was a failure building this commit Details
189fe2ed41 update acl
gitea/salix/pipeline/head There was a failure building this commit Details
16208a5e11 especify PK
gitea/salix/pipeline/head This commit looks good Details
7f5b30aa87 delete frontTest
gitea/salix/pipeline/head There was a failure building this commit Details
ec41123772 button for insert rows
gitea/salix/pipeline/head There was a failure building this commit Details
1ecc76067a code to correct insert in model
gitea/salix/pipeline/head There was a failure building this commit Details
a32f7b5ef1 add new row
gitea/salix/pipeline/head This commit looks good Details
c660786e45 refactor chaneg name
gitea/salix/pipeline/head This commit looks good Details
894f95cb1f update consulte sql
gitea/salix/pipeline/head This commit looks good Details
f501d20c65 update sql
gitea/salix/pipeline/head This commit looks good Details
920bff30c8 modify filter sql
vicent added 1 commit 2022-03-21 12:18:04 +00:00
vicent added 1 commit 2022-03-21 12:19:32 +00:00
gitea/salix/pipeline/head This commit looks good Details
31a5e19151 move db changes to correct folder
vicent added 1 commit 2022-03-23 11:53:48 +00:00
carlosjr added 1 commit 2022-03-28 08:40:44 +00:00
gitea/salix/pipeline/head This commit looks good Details
39694b31b8 Merge branch 'dev' into 3607-supplier_agencyTerm
carlosjr requested changes 2022-03-28 09:04:04 +00:00
db/changes/10440-fallas/00-aclAgency.sql Outdated
@ -0,0 +1,2 @@
INSERT INTO salix.ACL (id, model, property, accessType, permission, principalType, principalId)
carlosjr commented 2022-03-28 08:42:48 +00:00
Contributor
Copy Link

salix.ACL should be a template string for the script to work

salix.ACL should be a template string for the script to work
vicent marked this conversation as resolved
db/changes/10440-fallas/00-supplierAgencyTerm.sql Outdated
@ -0,0 +1,48 @@
ALTER TABLE vn.agencyTerm ADD supplierFk INT NULL;
carlosjr commented 2022-03-28 08:45:54 +00:00
Contributor
Copy Link

vn.agencyTerm

please check all sql files.

`vn`.`agencyTerm` please check all sql files.
vicent marked this conversation as resolved
modules/supplier/back/models/supplier-agency-term.js Outdated
@ -0,0 +1,9 @@
let UserError = require('vn-loopback/util/user-error');
carlosjr commented 2022-03-28 08:53:44 +00:00
Contributor
Copy Link

isn't this a constant?

isn't this a constant?
vicent marked this conversation as resolved
modules/supplier/back/models/supplier-agency-term.json
@ -0,0 +43,4 @@
"foreignKey": "agencyFk"
}
},
"acls": [
carlosjr commented 2022-03-28 08:57:36 +00:00
Contributor
Copy Link

this model ACLs are already stated in the ACL's table. We only state read only ACL on models.

this model ACLs are already stated in the ACL's table. We only state read only ACL on models.
vicent marked this conversation as resolved
modules/supplier/front/routes.json Outdated
@ -89,0 +94,4 @@
"abstract": true
},
{
"url": "/index?q",
carlosjr commented 2022-03-28 09:03:57 +00:00
Contributor
Copy Link

do you need ?q in this case?

do you need ?q in this case?
vicent marked this conversation as resolved
carlosjr removed the
CR / Tests passed
 label 2022-03-28 09:04:19 +00:00
vicent added 1 commit 2022-03-28 11:35:48 +00:00
gitea/salix/pipeline/head This commit looks good Details
f4d53c4040 pull request changes required
vicent added the
CR / Tests passed
 label 2022-03-28 11:36:31 +00:00
vicent requested review from carlosjr 2022-03-28 11:36:36 +00:00
vicent added 1 commit 2022-03-28 11:41:04 +00:00
gitea/salix/pipeline/head This commit looks good Details
b72d26f214 fix: update backTest
carlosjr added 1 commit 2022-03-29 07:54:22 +00:00
gitea/salix/pipeline/head This commit looks good Details
e4ae263d42 Merge branch 'dev' into 3607-supplier_agencyTerm
carlosjr approved these changes 2022-03-29 07:54:37 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit 589a9a1f9d into dev 2022-03-29 08:03:03 +00:00
carlosjr deleted branch 3607-supplier_agencyTerm 2022-03-29 08:03:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#905
No description provided.
Delete Branch "3607-supplier_agencyTerm"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?