verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

3621-fix(worker_calendar): absence in holiday day #911

Merged
carlosjr merged 6 commits from 3621-worker_calendar into dev 2022-03-29 08:27:26 +00:00
Conversation 0 Commits 6 Files Changed 3 +33 -13
alexm commented 2022-03-23 12:07:24 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2022-03-23 12:07:25 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
0963b66560 fix(worker_calendar): absence in holiday day
alexm added 1 commit 2022-03-23 13:03:00 +00:00
alexm changed title from WIP:3621-fix(worker_calendar): absence in holiday day to 3621-fix(worker_calendar): absence in holiday day 2022-03-23 13:04:01 +00:00
alexm added the
CR / Tests passed
Simple
 labels 2022-03-23 13:04:09 +00:00
alexm removed the
Simple
 label 2022-03-24 09:01:43 +00:00
carlosjr requested changes 2022-03-28 10:13:17 +00:00
db/dump/fixtures.sql Outdated
@ -2506,0 +2510,4 @@
INSERT INTO `vn`.`calendarHolidaysType` (`id`, `name`, `hexColour`)
VALUES
(1, 'test', 'E9AA01');
carlosjr commented 2022-03-28 10:10:20 +00:00
Contributor
Copy Link

Don't use words like test in fixtures as it makes it difficult to discern what is a real fixture and what is a temporary change made by a test.

Don't use words like test in fixtures as it makes it difficult to discern what is a real fixture and what is a temporary change made by a test.
alexm marked this conversation as resolved
carlosjr added 1 commit 2022-03-28 10:13:34 +00:00
gitea/salix/pipeline/head This commit looks good Details
8d70bac5c6 Merge branch 'dev' into 3621-worker_calendar
alexm added 1 commit 2022-03-28 11:59:51 +00:00
gitea/salix/pipeline/head This commit looks good Details
f853696d03 change fixture name
alexm requested review from carlosjr 2022-03-28 12:00:11 +00:00
alexm added 1 commit 2022-03-29 08:10:04 +00:00
carlosjr approved these changes 2022-03-29 08:18:10 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr added 1 commit 2022-03-29 08:18:22 +00:00
gitea/salix/pipeline/head This commit looks good Details
74fb7c95c2 Merge branch 'dev' into 3621-worker_calendar
carlosjr merged commit d3946cd568 into dev 2022-03-29 08:27:26 +00:00
carlosjr deleted branch 3621-worker_calendar 2022-03-29 08:27:26 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#911
No description provided.
Delete Branch "3621-worker_calendar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?