3734-fix(item_diary): apply async scroll #913

Merged
carlosjr merged 4 commits from 3734-item_diary_scroll into dev 2022-03-29 08:38:41 +00:00
Member
No description provided.
alexm added the
CR / Tests passed
Simple
labels 2022-03-24 09:29:34 +00:00
alexm added 1 commit 2022-03-24 09:29:35 +00:00
gitea/salix/pipeline/head This commit looks good Details
968ecab9b2
fix(item_diary): apply async scroll
carlosjr added 1 commit 2022-03-28 10:14:48 +00:00
gitea/salix/pipeline/head This commit looks good Details
49ae4d0e74
Merge branch 'dev' into 3734-item_diary_scroll
carlosjr requested changes 2022-03-28 10:23:02 +00:00
@ -47,3 +48,4 @@
controller.lineFk = 1;
controller.scrollToLine('invalidValue');
expect(controller.$.$applyAsync).toHaveBeenCalledWith(jasmine.any(Function));
Contributor

You don't need to test angular's life cycle.

You don't need to test angular's life cycle.
alexm marked this conversation as resolved
@ -52,3 +56,4 @@
});
it('should assign $location then call anchorScroll using received value', () => {
jest.spyOn(controller.$, '$applyAsync');
Contributor

same as above

same as above
carlosjr removed the
CR / Tests passed
Simple
labels 2022-03-28 10:23:29 +00:00
alexm added 1 commit 2022-03-28 12:04:38 +00:00
gitea/salix/pipeline/head This commit looks good Details
1959340163
remove $applyAsync test
alexm requested review from carlosjr 2022-03-28 12:05:02 +00:00
alexm added the
CR / Tests passed
label 2022-03-28 12:05:07 +00:00
carlosjr added 1 commit 2022-03-29 08:34:44 +00:00
gitea/salix/pipeline/head This commit looks good Details
e2aaa616af
Merge branch 'dev' into 3734-item_diary_scroll
carlosjr approved these changes 2022-03-29 08:35:29 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
carlosjr merged commit 7b19a70f96 into dev 2022-03-29 08:38:41 +00:00
carlosjr deleted branch 3734-item_diary_scroll 2022-03-29 08:38:42 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#913
No description provided.