verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

3605-invoiceIn_intrastat3 #921

Merged
carlosjr merged 10 commits from 3605-invoiceIn_intrastat3 into dev 2022-04-11 10:40:20 +00:00
Conversation 0 Commits 10 Files Changed 14 +393 -1
vicent commented 2022-03-30 05:57:06 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-03-30 05:57:06 +00:00
vicent added 8 commits 2022-03-30 05:57:07 +00:00
gitea/salix/pipeline/head This commit looks good Details
d7f252a57d feat(invoiceIn): add section intrastat
gitea/salix/pipeline/head This commit looks good Details
062a3146a3 fix: modify intrastat.sql to show "neto" field
gitea/salix/pipeline/head This commit looks good Details
a152e22f6e update sql changes
gitea/salix/pipeline/head This commit looks good Details
84ebeed8ef add fixtures
gitea/salix/pipeline/head This commit looks good Details
e0244f388c refator: single quotes in sql files
gitea/salix/pipeline/head This commit looks good Details
572cc30a4e refactor: updated translate
gitea/salix/pipeline/head This commit looks good Details
5b1d610f2f refator: updated translate
carlosjr requested changes 2022-04-07 08:52:36 +00:00
db/changes/10420-valentines/00-aclIntrastat.sql Outdated
@ -0,0 +1,3 @@
INSERT INTO `salix`.`ACL`
carlosjr commented 2022-04-07 08:41:51 +00:00
Contributor
Copy Link

update sql folder to fallas or the current version, basically a version yet to be merged.

update sql folder to fallas or the current version, basically a version yet to be merged.
vicent marked this conversation as resolved
db/changes/10420-valentines/00-invoiceInIntrastat.sql Outdated
@ -0,0 +1,2 @@
INSERT INTO `salix`.`ACL` (`model`,`property`,`accessType`,`permission`,`principalType`,`principalId`)
carlosjr commented 2022-04-07 08:42:32 +00:00
Contributor
Copy Link

update sql folder to fallas or the current version, basically a version yet to be merged.

update sql folder to fallas or the current version, basically a version yet to be merged.
vicent marked this conversation as resolved
modules/invoiceIn/front/intrastat/index.html Outdated
@ -0,0 +53,4 @@
ng-model="intrastat.amount"
step="0.01"
rule
vn-focus>
carlosjr commented 2022-04-07 08:44:56 +00:00
Contributor
Copy Link

too many vn-focus, you just focus one.

too many vn-focus, you just focus one.
vicent marked this conversation as resolved
modules/invoiceIn/front/intrastat/index.js Outdated
@ -0,0 +18,4 @@
this.stemsTotal = 0.0;
if (!this._invoceInIntrastat) return;
this._invoceInIntrastat.forEach(intrastat => {
carlosjr commented 2022-04-07 08:47:20 +00:00
Contributor
Copy Link

Do not access private properties if you have getters and setters in your toolkit.

Do not access private properties if you have getters and setters in your toolkit.
vicent marked this conversation as resolved
modules/invoiceIn/front/intrastat/index.spec.js
@ -0,0 +23,4 @@
}));
describe('calculateTotals()', () => {
it('should set amountTotal, netTotal and stemsTotal to 0 if salesClaimed has no data', () => {
carlosjr commented 2022-04-07 08:49:26 +00:00
Contributor
Copy Link

You missed the test where the actual purpose of the function is tested.

You missed the test where the actual purpose of the function is tested.
vicent marked this conversation as resolved
vicent added 1 commit 2022-04-11 06:24:09 +00:00
gitea/salix/pipeline/head This commit looks good Details
d8a1bd1b1c fix: pull request changes
vicent requested review from carlosjr 2022-04-11 06:24:23 +00:00
carlosjr approved these changes 2022-04-11 10:28:52 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr added 1 commit 2022-04-11 10:29:14 +00:00
gitea/salix/pipeline/head This commit looks good Details
b087d275dc Merge branch 'dev' into 3605-invoiceIn_intrastat3
carlosjr merged commit eddbe85ca9 into dev 2022-04-11 10:40:20 +00:00
carlosjr deleted branch 3605-invoiceIn_intrastat3 2022-04-11 10:40:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#921
No description provided.
Delete Branch "3605-invoiceIn_intrastat3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?