verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

3802-ticket_sale_mana #924

Merged
carlosjr merged 10 commits from 3802-ticket_sale_mana into dev 2022-04-11 10:50:20 +00:00
Conversation 0 Commits 10 Files Changed 11 +301 -10
vicent commented 2022-03-30 08:18:49 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-03-30 08:18:49 +00:00
vicent added 8 commits 2022-03-30 08:18:50 +00:00
gitea/salix/pipeline/head This commit looks good Details
c15aea213f feat(ticket_sale): add front test
gitea/salix/pipeline/head This commit looks good Details
86350b2afa feat(ticket_sale): add backTest
gitea/salix/pipeline/head This commit looks good Details
63a857a616 fix: updated test e2e
gitea/salix/pipeline/head There was a failure building this commit Details
b78ecc06d2 fix(ticker_sale): only show mana options if currentWorker has mana
gitea/salix/pipeline/head This commit looks good Details
23cb8c1215 refactor(ticket_sale): update frontTest
carlosjr requested changes 2022-04-08 08:24:05 +00:00
db/changes/10440-fallas/00-component.sql Outdated
@ -0,0 +1,2 @@
INSERT INTO `vn`.`component` (`name`,`typeFk`,`classRate`,`isRenewable`,`code`,`isRequired`)
VALUES ('maná reclamacion',7,4,0,'mana claim',0);
carlosjr commented 2022-04-08 07:59:52 +00:00
Contributor
Copy Link

The column code should be in lowerCamelCase

The column code should be in lowerCamelCase
vicent marked this conversation as resolved
e2e/paths/05-ticket/01-sale/02_edit_sale.spec.js Outdated
@ -176,6 +176,7 @@ describe('Ticket Edit sale path', () => {
await page.waitToClick(selectors.ticketSales.firstSaleDiscount);
await page.waitForSelector(selectors.ticketSales.firstSaleDiscountInput);
await page.type(selectors.ticketSales.firstSaleDiscountInput, '50u000d');
carlosjr commented 2022-04-08 08:03:38 +00:00
Contributor
Copy Link

since you added a click on a submit button on the next line, the u000d of this input is no longer needed.

since you added a click on a submit button on the next line, the u000d of this input is no longer needed.
vicent marked this conversation as resolved
modules/ticket/back/methods/ticket/specs/updateDiscount.spec.js Outdated
@ -113,0 +130,4 @@
}
});
it('should update the discount if the salesPerson has mana and manaType = "mana claim"', async() => {
carlosjr commented 2022-04-08 08:07:36 +00:00
Contributor
Copy Link

if the code gets updated to lowerCamelCase this line and the test should be updated to match the code.

also manaType doesn't seem to be correct, manaCode or manaComponentCode are more specifics

if the code gets updated to lowerCamelCase this line and the test should be updated to match the code. also manaType doesn't seem to be correct, manaCode or manaComponentCode are more specifics
vicent marked this conversation as resolved
modules/ticket/back/methods/ticket/updateDiscount.js Outdated
@ -25,1 +25,4 @@
required: true
},
{
arg: 'manaType',
carlosjr commented 2022-04-08 08:10:18 +00:00
Contributor
Copy Link

manaCode

manaCode
vicent marked this conversation as resolved
modules/ticket/front/sale/index.spec.js Outdated
@ -64,2 +64,4 @@
}));
describe('manaType() setter/getter', () => {
it('should set the manaType data', () => {
carlosjr commented 2022-04-08 08:17:48 +00:00
Contributor
Copy Link

Don't test angularjs basic functionalities like getters and setters, we test setters if there's logic to it.

Don't test angularjs basic functionalities like getters and setters, we test setters if there's logic to it.
vicent marked this conversation as resolved
modules/ticket/front/sale/index.spec.js Outdated
@ -733,2 +743,4 @@
});
});
describe('save()', () => {
carlosjr commented 2022-04-08 08:23:08 +00:00
Contributor
Copy Link

This test is testing the function's implementation, there's no logic worth a test here.

This test is testing the function's implementation, there's no logic worth a test here.
vicent marked this conversation as resolved
vicent added 1 commit 2022-04-11 07:04:20 +00:00
gitea/salix/pipeline/head This commit looks good Details
655db502f7 refactor: pull request changes
vicent requested review from carlosjr 2022-04-11 07:04:55 +00:00
carlosjr added 1 commit 2022-04-11 10:41:05 +00:00
gitea/salix/pipeline/head This commit looks good Details
56e52c35d8 Merge branch 'dev' into 3802-ticket_sale_mana
carlosjr approved these changes 2022-04-11 10:50:09 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit 5426445451 into dev 2022-04-11 10:50:20 +00:00
carlosjr deleted branch 3802-ticket_sale_mana 2022-04-11 10:50:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#924
No description provided.
Delete Branch "3802-ticket_sale_mana"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?