verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 58 Releases Wiki Activity

3830-ticket_sale #927

Merged
carlosjr merged 9 commits from 3830-ticket_sale into dev 2022-04-13 09:30:49 +00:00
Conversation 0 Commits 9 Files Changed 25 +298 -40
vicent commented 2022-04-04 12:18:29 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-04-04 12:18:29 +00:00
vicent added 3 commits 2022-04-04 12:18:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
c5efc17fe9 refactr: update test
gitea/salix/pipeline/head This commit looks good Details
a8f4192b4c feat: update salix fonts
carlosjr requested changes 2022-04-08 09:25:05 +00:00
modules/ticket/back/methods/sale/refund.js Outdated
@ -0,0 +8,4 @@
arg: 'sales',
description: 'The sales',
type: ['object'],
required: false
carlosjr commented 2022-04-08 09:09:04 +00:00
Contributor
Copy Link

If you want to pick all sales from a ticket create an endpoint for such functionality, this endpoint was meant to receive the sales. follow the single responsability principle.

for example create an endpoint that picks all sales from a given ticket and then calls this one with the expected sales. in this way both endpoints do their job as expected.

Can't all sales be selected in the old way? (ticket.sale)

If you want to pick all sales from a ticket create an endpoint for such functionality, this endpoint was meant to receive the sales. follow the single responsability principle. for example create an endpoint that picks all sales from a given ticket and then calls this one with the expected sales. in this way both endpoints do their job as expected. Can't all sales be selected in the old way? (ticket.sale)
vicent marked this conversation as resolved
modules/ticket/front/descriptor-menu/index.spec.js Outdated
@ -263,2 +263,4 @@
});
describe('refundAll()', () => {
it('should make a query and show a go to ticket.card.sale', () => {
carlosjr commented 2022-04-08 09:22:13 +00:00
Contributor
Copy Link

show a go?

show a go?
vicent marked this conversation as resolved
modules/ticket/front/descriptor-menu/index.spec.js Outdated
@ -264,1 +264,4 @@
describe('refundAll()', () => {
it('should make a query and show a go to ticket.card.sale', () => {
jest.spyOn(controller.$state, 'go').mockReturnValue('ok');
carlosjr commented 2022-04-08 09:22:48 +00:00
Contributor
Copy Link

do you need this spy to return a value?

do you need this spy to return a value?
vicent marked this conversation as resolved
carlosjr added the
Needs refactor
 label 2022-04-08 09:25:15 +00:00
vicent added 2 commits 2022-04-11 08:01:34 +00:00
gitea/salix/pipeline/head This commit looks good Details
fefff80af4 pull request changes
vicent removed the
Needs refactor
 label 2022-04-11 08:02:08 +00:00
vicent requested review from carlosjr 2022-04-11 08:02:10 +00:00
vicent added 1 commit 2022-04-12 10:49:47 +00:00
vicent added 1 commit 2022-04-13 07:50:41 +00:00
gitea/salix/pipeline/head This commit looks good Details
a47349646f change versions db
carlosjr requested changes 2022-04-13 08:05:37 +00:00
modules/ticket/back/methods/sale/refundAll.js
@ -0,0 +2,4 @@
module.exports = Self => {
Self.remoteMethodCtx('refundAll', {
description: 'Create ticket with all lines and services changing the sign to the quantites',
carlosjr commented 2022-04-13 08:05:10 +00:00
Contributor
Copy Link

This endpoint should call the existing endpoint (modules/ticket/back/methods/sale/refund.js) which already has the functionality and validations.

Doing this we avoid repeating validation's code and so.

refoundAll should just get the ticket sales and then call refund with the sales and the ticket id.

This endpoint should call the existing endpoint (modules/ticket/back/methods/sale/refund.js) which already has the functionality and validations. Doing this we avoid repeating validation's code and so. refoundAll should just get the ticket sales and then call refund with the sales and the ticket id.
carlosjr added
Needs refactor
 and removed
CR / Tests passed
 labels 2022-04-13 08:05:55 +00:00
carlosjr added
CR / Tests passed
 and removed
Needs refactor
 labels 2022-04-13 09:12:08 +00:00
carlosjr added 1 commit 2022-04-13 09:12:20 +00:00
gitea/salix/pipeline/head This commit looks good Details
6015050eed Merge branch 'dev' into 3830-ticket_sale
carlosjr approved these changes 2022-04-13 09:12:42 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr added 1 commit 2022-04-13 09:19:57 +00:00
gitea/salix/pipeline/head This commit looks good Details
9085098a04 Merge branch 'dev' into 3830-ticket_sale
carlosjr merged commit d84f882b36 into dev 2022-04-13 09:30:49 +00:00
carlosjr deleted branch 3830-ticket_sale 2022-04-13 09:30:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#927
No description provided.
Delete Branch "3830-ticket_sale"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?