3750-claim_photo #935

Merged
carlosjr merged 16 commits from 3750-claim_photo into dev 2022-05-09 13:15:26 +00:00
Contributor
No description provided.
vicent added the
CR / Tests passed
label 2022-04-11 06:07:20 +00:00
vicent added 9 commits 2022-04-11 06:07:22 +00:00
vicent added 1 commit 2022-04-11 08:10:09 +00:00
gitea/salix/pipeline/head This commit looks good Details
6e999302bf
refactor: replace let for const
carlosjr requested changes 2022-04-13 09:04:24 +00:00
@ -86,0 +89,4 @@
"name": "claimStorage",
"connector": "loopback-component-storage",
"provider": "filesystem",
"root": "./storage/claim",
Contributor

"root": "./storage/dms" is the existing folder for the DMS, use it.

"root": "./storage/dms" is the existing folder for the DMS, use it.
vicent marked this conversation as resolved
@ -0,0 +3,4 @@
module.exports = Self => {
Self.remoteMethodCtx('deleteOldFiles', {
description: 'Delete files that are 6 months old from "./storage/claim"',
Contributor

Deletes files that are 6 months old from dms

Deletes files that are 6 months old from dms
vicent marked this conversation as resolved
@ -0,0 +26,4 @@
myOptions.transaction = tx;
try {
const claimContainer = './storage/claim';
Contributor

You need to obtain the claim storage directories dynamically

Please don't use './storage/claim' since that won't work in test/prod.

investigate loopback-component-storage to list all the containers.

You need to obtain the claim storage directories dynamically Please don't use './storage/claim' since that won't work in test/prod. investigate loopback-component-storage to list all the containers.
vicent marked this conversation as resolved
@ -0,0 +38,4 @@
srcFile = path.join(srcFoulder, file);
const {birthtime} = fs.statSync(srcFile);
const sixMonthsAgo = new Date();
sixMonthsAgo.setMonth(sixMonthsAgo.getMonth() - 6);
Contributor

checking directory creation/modification date doesn't show how old the contained files are. beware

checking directory creation/modification date doesn't show how old the contained files are. beware
vicent marked this conversation as resolved
carlosjr added
Needs refactor
and removed
CR / Tests passed
labels 2022-04-13 09:06:00 +00:00
vicent added 1 commit 2022-04-20 12:47:10 +00:00
gitea/salix/pipeline/head This commit looks good Details
5db20ee3e2
refactor: deleteOldFiles in claim
vicent added
CR / Tests passed
and removed
Needs refactor
labels 2022-04-20 12:47:57 +00:00
vicent added
Missing tests
and removed
CR / Tests passed
labels 2022-04-20 12:51:46 +00:00
vicent added 1 commit 2022-04-20 13:19:26 +00:00
gitea/salix/pipeline/head This commit looks good Details
de7a992480
change folder files
vicent added 1 commit 2022-04-21 05:14:43 +00:00
vicent added
CR / Tests passed
and removed
Missing tests
labels 2022-04-21 05:28:20 +00:00
vicent requested review from carlosjr 2022-04-21 05:28:22 +00:00
vicent added 1 commit 2022-04-29 06:23:52 +00:00
gitea/salix/pipeline/head This commit looks good Details
c10e4c04b6
refactor: delete file
vicent added 1 commit 2022-04-29 06:32:17 +00:00
carlosjr approved these changes 2022-05-09 12:36:20 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
carlosjr added 1 commit 2022-05-09 12:36:50 +00:00
gitea/salix/pipeline/head This commit looks good Details
efc43c9611
Merge branch 'dev' into 3750-claim_photo
carlosjr merged commit 58ab1ab4dc into dev 2022-05-09 13:15:26 +00:00
carlosjr deleted branch 3750-claim_photo 2022-05-09 13:15:27 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#935
No description provided.