3752-claim_action #939

Merged
carlosjr merged 14 commits from 3752-claim_action into dev 2022-05-10 12:05:07 +00:00
Contributor
No description provided.
vicent added the
CR / Tests passed
label 2022-04-12 10:42:49 +00:00
vicent added 6 commits 2022-04-12 10:42:50 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
313e911940
fix(claim_action): smart-table
gitea/salix/pipeline/head There was a failure building this commit Details
4872407723
fix test
gitea/salix/pipeline/head There was a failure building this commit Details
5921891161
refactor: updated css
gitea/salix/pipeline/head This commit looks good Details
1e11191e79
fix: frontTest
vicent added 1 commit 2022-04-12 10:44:58 +00:00
gitea/salix/pipeline/head This commit looks good Details
ad3b3c44d6
refactor: replace let for const
vicent added 1 commit 2022-04-12 10:45:21 +00:00
gitea/salix/pipeline/head Build queued... Details
9a171d5202
refactor
vicent added 1 commit 2022-04-12 10:46:38 +00:00
gitea/salix/pipeline/head This commit looks good Details
c1edb8206e
refactor
carlosjr requested changes 2022-04-13 09:54:12 +00:00
@ -0,0 +1,49 @@
module.exports = Self => {
Self.remoteMethodCtx('deleteSalesClaimed', {
Contributor

delete the claimed sales = deleteClamedSales

delete the claimed sales = deleteClamedSales
vicent marked this conversation as resolved
@ -0,0 +1,49 @@
module.exports = Self => {
Self.remoteMethodCtx('deleteSalesClaimed', {
description: 'Deletes the selected sales',
Contributor

Deletes the claimed sales?

Deletes the claimed sales?
vicent marked this conversation as resolved
@ -0,0 +36,4 @@
promises.push(deletedSale);
}
const deletedSales = await Promise.all(promises);
Contributor

What happens if the claim ends up empty? shouldn't we delete it?

What happens if the claim ends up empty? shouldn't we delete it?
vicent marked this conversation as resolved
@ -0,0 +37,4 @@
const models = Self.app.models;
for (let row of rows) {
const claimEnd = await models.ClaimEnd.findById(row.id, null, myOptions);
await claimEnd.updateAttribute('claimDestinationFk', claimDestinationFk, myOptions);
Contributor

const updatedClaimEnd = claimEnd.updateAttribute('claimDestinationFk', claimDestinationFk, myOptions);
promises.push(updatedClaimEnd);

this way all queries are made with promise.all instead of firing several queries

const updatedClaimEnd = claimEnd.updateAttribute('claimDestinationFk', claimDestinationFk, myOptions); promises.push(updatedClaimEnd); this way all queries are made with promise.all instead of firing several queries
vicent marked this conversation as resolved
vicent added 1 commit 2022-04-21 07:34:23 +00:00
gitea/salix/pipeline/head This commit looks good Details
0ec51202e0
pull request changed
vicent requested review from carlosjr 2022-04-21 07:34:53 +00:00
vicent added 1 commit 2022-04-21 10:14:25 +00:00
vicent added 1 commit 2022-05-10 05:11:46 +00:00
carlosjr approved these changes 2022-05-10 11:36:26 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
carlosjr added 1 commit 2022-05-10 11:36:55 +00:00
gitea/salix/pipeline/head This commit looks good Details
0e65f382f9
Merge branch 'dev' into 3752-claim_action
carlosjr added 1 commit 2022-05-10 11:47:24 +00:00
gitea/salix/pipeline/head This commit looks good Details
a47c0dbaea
Merge branch 'dev' into 3752-claim_action
carlosjr merged commit d7b76835f5 into dev 2022-05-10 12:05:07 +00:00
carlosjr deleted branch 3752-claim_action 2022-05-10 12:05:08 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#939
No description provided.