verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

3409-clientCredit_maxRows #963

Merged
carlosjr merged 13 commits from 3409-clientCredit_maxRows into dev 2022-05-16 08:24:42 +00:00
Conversation 0 Commits 13 Files Changed 158 +858 -752
alexm commented 2022-05-04 05:48:11 +00:00
Member
Copy Link
No description provided.
alexm added the
CR / Tests passed
Simple
 labels 2022-05-04 05:48:11 +00:00
alexm added 3 commits 2022-05-04 05:48:13 +00:00
gitea/salix/pipeline/head This commit looks good Details
b40b8d931d feat(client_credit): remove de old rows
gitea/salix/pipeline/head This commit looks good Details
e140c9d1f4 console.logs
gitea/salix/pipeline/head This commit looks good Details
800b4984ff fix(test): use ctx.options
alexm added 1 commit 2022-05-04 08:26:27 +00:00
gitea/salix/pipeline/head This commit looks good Details
1cc199e26b refactor(client-credit)
alexm added 1 commit 2022-05-04 08:28:29 +00:00
gitea/salix/pipeline/head This commit looks good Details
0cae852dea refactor
alexm added 3 commits 2022-05-09 11:19:57 +00:00
carlosjr requested changes 2022-05-10 12:54:07 +00:00
modules/client/back/models/client-config.json Outdated
@ -0,0 +8,4 @@
},
"properties": {
"id": {
"type": "Number",
carlosjr commented 2022-05-10 12:25:26 +00:00
Contributor
Copy Link
  • types project convention is lowercase
  • 4 spaces indentation
- types project convention is lowercase - 4 spaces indentation
alexm marked this conversation as resolved
modules/client/back/models/specs/clientCredit.spec.js Outdated
@ -0,0 +13,4 @@
try {
const options = {transaction: tx};
const ctx = {options};
carlosjr commented 2022-05-10 12:49:30 +00:00
Contributor
Copy Link

why ctx.options instead of options?

why ctx.options instead of options?
alexm marked this conversation as resolved
modules/client/back/models/specs/clientCredit.spec.js
@ -0,0 +34,4 @@
throw e;
}
expect(rowsAfter.length).toEqual(clientConfig.maxCreditRows);
carlosjr commented 2022-05-10 12:52:36 +00:00
Contributor
Copy Link

Checking the length of the result doesn't check the "old" rows where actually deleted as mentioned in the test description "should delete old rows of clientCredit"

Checking the length of the result doesn't check the "old" rows where actually deleted as mentioned in the test description "should delete old rows of clientCredit"
alexm marked this conversation as resolved
carlosjr removed the
CR / Tests passed
Simple
 labels 2022-05-10 12:54:35 +00:00
alexm added 2 commits 2022-05-12 06:06:55 +00:00
alexm requested review from carlosjr 2022-05-12 06:07:15 +00:00
alexm added the
CR / Tests passed
 label 2022-05-12 06:07:26 +00:00
alexm added 1 commit 2022-05-12 07:48:00 +00:00
gitea/salix/pipeline/head This commit looks good Details
5021315ed4 refactor(clientCredit): test and types
carlosjr added 1 commit 2022-05-16 07:23:14 +00:00
gitea/salix/pipeline/head This commit looks good Details
b5ccd32800 Merge branch 'dev' into 3409-clientCredit_maxRows
carlosjr added 1 commit 2022-05-16 08:20:12 +00:00
gitea/salix/pipeline/head This commit looks good Details
d31f7f1b6b all type Dates replaced to date as per convention
carlosjr approved these changes 2022-05-16 08:22:15 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit 9f246f08d5 into dev 2022-05-16 08:24:42 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#963
No description provided.
Delete Branch "3409-clientCredit_maxRows"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?