verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 65 Releases Wiki Activity

4024-refactor(client_defaulter) #972

Merged
carlosjr merged 8 commits from 4024-client_defaulter into dev 2022-06-13 07:10:04 +00:00
Conversation 0 Commits 8 Files Changed 7 +44 -36
alexm commented 2022-05-12 12:20:49 +00:00
Member
Copy Link
No description provided.
alexm added 1 commit 2022-05-12 12:20:51 +00:00
gitea/salix/pipeline/head This commit looks good Details
ec49dd67be refactor(client_defaulter)
alexm added 2 commits 2022-05-16 12:31:01 +00:00
gitea/salix/pipeline/head This commit looks good Details
a37be3e5fe refactor(client_defaulter): search in smart-table
alexm added 1 commit 2022-06-09 13:11:07 +00:00
gitea/salix/pipeline/head This commit looks good Details
36ea903333 change NumberFormat
alexm reviewed 2022-06-09 13:11:59 +00:00
front/core/filters/currency.js Outdated
@ -16,2 +16,4 @@
};
let lang = $translate.use();
if (lang == 'es')
alexm commented 2022-06-09 13:11:58 +00:00
Author
Member
Copy Link

Se admiten sugerencias

Se admiten sugerencias
carlosjr commented 2022-06-10 07:19:18 +00:00
Contributor
Copy Link

const lang = $translate.use() == 'es' ? 'de' : translate.use();

const lang = $translate.use() == 'es' ? 'de' : translate.use();
alexm marked this conversation as resolved
alexm changed title from WIP: 4024-refactor(client_defaulter) to 4024-refactor(client_defaulter) 2022-06-09 13:12:28 +00:00
alexm added the
CR / Tests passed
 label 2022-06-09 13:12:40 +00:00
alexm added 1 commit 2022-06-09 13:13:25 +00:00
carlosjr added 1 commit 2022-06-10 07:21:56 +00:00
gitea/salix/pipeline/head This commit looks good Details
096f225656 Merge branch 'dev' into 4024-client_defaulter
carlosjr requested changes 2022-06-10 07:50:01 +00:00
modules/client/front/defaulter/index.spec.js Outdated
@ -36,17 +36,6 @@ describe('client defaulter', () => {
});
});
describe('balanceDueTotal() getter', () => {
carlosjr commented 2022-06-10 07:49:58 +00:00
Contributor
Copy Link

falta el test del total

falta el test del total
alexm marked this conversation as resolved
alexm added 2 commits 2022-06-13 05:44:29 +00:00
gitea/salix/pipeline/head This commit looks good Details
5e586bf1d0 test(client_defaulter): getBalanceDueTotal tested
alexm requested review from carlosjr 2022-06-13 05:44:43 +00:00
carlosjr approved these changes 2022-06-13 07:09:05 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit b0827bd98b into dev 2022-06-13 07:10:04 +00:00
carlosjr deleted branch 4024-client_defaulter 2022-06-13 07:10:04 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#972
No description provided.
Delete Branch "4024-client_defaulter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?