verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

4037-fix(multi-check) #973

Merged
carlosjr merged 4 commits from 4037-multi-check_align into dev 2022-05-16 08:35:57 +00:00
Conversation 0 Commits 4 Files Changed 4 +35 -10
alexm commented 2022-05-13 10:15:30 +00:00
Member
Copy Link
No description provided.
alexm added the
CR / Tests passed
Simple
 labels 2022-05-13 10:15:30 +00:00
alexm added 1 commit 2022-05-13 10:15:31 +00:00
gitea/salix/pipeline/head This commit looks good Details
35209d77cc fix(multi-check)
joan requested changes 2022-05-13 13:03:07 +00:00
front/core/components/multi-check/multi-check.spec.js
@ -193,0 +200,4 @@
expect(isCheckedDummy).toEqual(true);
});
it(`should return true only if is checked and checked dummy is enabled`, () => {
joan commented 2022-05-13 13:02:28 +00:00
Contributor
Copy Link

Tested twice?

Tested twice?
alexm marked this conversation as resolved
alexm added 2 commits 2022-05-16 08:24:13 +00:00
gitea/salix/pipeline/head This commit looks good Details
1707ff7f0f duplicate test
alexm requested review from joan 2022-05-16 08:24:43 +00:00
carlosjr approved these changes 2022-05-16 08:29:37 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr added 1 commit 2022-05-16 08:29:48 +00:00
gitea/salix/pipeline/head This commit looks good Details
5747fbbd2f Merge branch 'dev' into 4037-multi-check_align
carlosjr removed the
Simple
 label 2022-05-16 08:35:03 +00:00
carlosjr merged commit d7c790de4f into dev 2022-05-16 08:35:57 +00:00
carlosjr deleted branch 4037-multi-check_align 2022-05-16 08:35:57 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
joan
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#973
No description provided.
Delete Branch "4037-multi-check_align"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?