verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 58 Releases Wiki Activity

4002-item.itemType #974

Merged
carlosjr merged 10 commits from 4002-item.itemType into dev 2022-05-23 12:31:24 +00:00
Conversation 0 Commits 10 Files Changed 30 +654 -17
vicent commented 2022-05-17 07:55:51 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-05-17 07:55:51 +00:00
vicent added 6 commits 2022-05-17 07:55:53 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
734f9cb60d feat(item.itemType): added section itemType
gitea/salix/pipeline/head This commit looks good Details
13a6f1f8c1 feat(item): add section itemType
gitea/salix/pipeline/head This commit looks good Details
16fdf982c8 feat(item.itemtype): add frontTest
gitea/salix/pipeline/head This commit looks good Details
3335cb8a01 feat(item.itemType): add fields
gitea/salix/pipeline/head This commit looks good Details
76515bdd3f add: search-panel
carlosjr requested changes 2022-05-20 08:49:29 +00:00
db/changes/10460-motherDay/00-aclItemType.sql Outdated
@ -0,0 +1,7 @@
INSERT INTO `salix`.`ACL`
carlosjr commented 2022-05-20 08:44:17 +00:00
Contributor
Copy Link

you are inserting in the same table using the INSERT INTO twice...

you can wrap both in the same insert ie:

INSERT INTO salix.ACL(model, property, accessType, permission, principalType, principalId)
VALUES
('ItemType', '', 'READ', 'ALLOW', 'ROLE', 'employee'),
('ItemType', '', 'WRITE', 'ALLOW', 'ROLE', 'buyer');

you are inserting in the same table using the INSERT INTO twice... you can wrap both in the same insert ie: INSERT INTO `salix`.`ACL`(`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`) VALUES ('ItemType', '*', 'READ', 'ALLOW', 'ROLE', 'employee'), ('ItemType', '*', 'WRITE', 'ALLOW', 'ROLE', 'buyer');
vicent marked this conversation as resolved
modules/item/back/models/item-type.json Outdated
@ -21,0 +21,4 @@
"workerFk": {
"type": "number"
},
"categoryFk": {
carlosjr commented 2022-05-20 08:46:01 +00:00
Contributor
Copy Link

it's important to add the relations to any foreign key instead of a siemple field (just the foreign key)

it's important to add the relations to any foreign key instead of a siemple field (just the foreign key)
vicent marked this conversation as resolved
modules/item/front/item-type/card/index.spec.js Outdated
@ -0,0 +15,4 @@
it('should reload the controller data', () => {
controller.$params.id = 1;
$httpBackend.expectGET('ItemTypes/1').respond('foo');
carlosjr commented 2022-05-20 08:47:04 +00:00
Contributor
Copy Link

"foo" doesn't give context, therefore not making code maintenance easier.

"foo" doesn't give context, therefore not making code maintenance easier.
vicent marked this conversation as resolved
modules/item/front/item-type/descriptor/index.html Outdated
@ -0,0 +27,4 @@
vn-id="delete-itemType"
on-accept="$ctrl.onDelete()"
question="Are you sure you want to continue?"
message="ItemType will be removed">
carlosjr commented 2022-05-20 08:22:43 +00:00
Contributor
Copy Link

It is easier for the user to read "The item type will be removed" instead of "entityName will be removed"

The user is not a developer.

It is easier for the user to read "The item type will be removed" instead of "entityName will be removed" The user is not a developer.
vicent marked this conversation as resolved
modules/item/front/item-type/descriptor/locale/es.yml Outdated
@ -0,0 +1,2 @@
Role will be removed: El rol va a ser eliminado
carlosjr commented 2022-05-20 08:25:08 +00:00
Contributor
Copy Link

The roll will be removed: El rol va a ser eliminado
or
Roll will be removed: Rol va a ser eliminado

The roll will be removed: El rol va a ser eliminado or Roll will be removed: Rol va a ser eliminado
vicent marked this conversation as resolved
modules/item/front/item-type/search-panel/index.html
@ -0,0 +1,21 @@
<div class="search-panel">
<form ng-submit="$ctrl.onSearch()">
<vn-horizontal>
<vn-textfield
carlosjr commented 2022-05-20 08:34:16 +00:00
Contributor
Copy Link

this textfield may want to be the focus

this textfield may want to be the focus
vicent marked this conversation as resolved
carlosjr removed the
CR / Tests passed
 label 2022-05-20 08:49:51 +00:00
vicent added 1 commit 2022-05-20 10:33:24 +00:00
gitea/salix/pipeline/head This commit looks good Details
3c9800a7a3 refactor: pull request changes
vicent added 1 commit 2022-05-20 10:33:40 +00:00
vicent added the
CR / Tests passed
 label 2022-05-20 10:33:49 +00:00
vicent requested review from carlosjr 2022-05-20 10:33:52 +00:00
carlosjr requested changes 2022-05-23 09:42:20 +00:00
modules/item/back/models/item-type.json Outdated
@ -18,11 +18,20 @@
"name": {
"type": "string"
},
"temperatureFk": {
carlosjr commented 2022-05-23 09:05:19 +00:00
Contributor
Copy Link

relation still missing

relation still missing
vicent marked this conversation as resolved
modules/item/back/models/item-type.json Outdated
@ -26,0 +27,4 @@
"promo": {
"type": "number"
},
"itemPackingTypeFk": {
carlosjr commented 2022-05-23 09:05:27 +00:00
Contributor
Copy Link

relation still missing

relation still missing
vicent marked this conversation as resolved
carlosjr removed the
CR / Tests passed
 label 2022-05-23 09:43:31 +00:00
vicent added 1 commit 2022-05-23 10:40:25 +00:00
vicent added the
CR / Tests passed
 label 2022-05-23 10:42:14 +00:00
vicent requested review from carlosjr 2022-05-23 10:42:18 +00:00
vicent added 1 commit 2022-05-23 10:43:51 +00:00
carlosjr approved these changes 2022-05-23 12:31:12 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit 79a75dcfa5 into dev 2022-05-23 12:31:24 +00:00
carlosjr deleted branch 4002-item.itemType 2022-05-23 12:31:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#974
No description provided.
Delete Branch "4002-item.itemType"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?