verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

4022-client.balance.create #976

Merged
carlosjr merged 5 commits from 4022-client.balance.create into dev 2022-05-23 12:52:23 +00:00
Conversation 0 Commits 5 Files Changed 4 +20 -15
vicent commented 2022-05-17 10:26:24 +00:00
Contributor
Copy Link
No description provided.
vicent added the
CR / Tests passed
 label 2022-05-17 10:26:24 +00:00
vicent added 1 commit 2022-05-17 10:26:26 +00:00
gitea/salix/pipeline/head This commit looks good Details
eeede417eb feat: update date depending of accountingType
vicent changed title from feat: update date depending of accountingType to 4022-client.balance.create 2022-05-17 10:26:33 +00:00
carlosjr requested changes 2022-05-20 10:01:26 +00:00
db/dump/fixtures.sql Outdated
@ -166,3 +161,1 @@
(6, 'Loans', NULL, NULL, NULL),
(7, 'Leasing', NULL, NULL, NULL),
(8, 'Compensations', 'Compensations', 'compensation', NULL);
(1, 'CC y Polizas de crédito', 'Transferencias', 'wireTransfer', NULL, 1),
carlosjr commented 2022-05-20 09:56:23 +00:00
Contributor
Copy Link

english should be use by default.

english should be use by default.
vicent marked this conversation as resolved
modules/client/front/balance/create/index.js
@ -72,6 +67,13 @@ class Controller extends Dialog {
`${accountingType && accountingType.receiptDescription}`;
}
this.maxAmount = accountingType && accountingType.maxAmount;
carlosjr commented 2022-05-20 10:01:05 +00:00
Contributor
Copy Link

// this.receipt.payed is going to be 100% of the times a date object therefore you can write more simplistic code:

pseudocode example:

this.receipt.payed = new Date()
if (accountingType.daysInFuture)
this.receipt.payed.setDate(this.receipt.payed.getDate() + accountingType.daysInFuture);

// this.receipt.payed is going to be 100% of the times a date object therefore you can write more simplistic code: pseudocode example: this.receipt.payed = new Date() if (accountingType.daysInFuture) this.receipt.payed.setDate(this.receipt.payed.getDate() + accountingType.daysInFuture);
vicent marked this conversation as resolved
carlosjr removed the
CR / Tests passed
 label 2022-05-20 10:01:35 +00:00
vicent added 1 commit 2022-05-20 11:16:58 +00:00
gitea/salix/pipeline/head This commit looks good Details
875e9503c3 refactor: request changes
vicent added the
CR / Tests passed
 label 2022-05-20 11:17:41 +00:00
vicent added 1 commit 2022-05-20 11:18:13 +00:00
vicent requested review from carlosjr 2022-05-20 11:36:16 +00:00
carlosjr requested changes 2022-05-23 09:52:36 +00:00
db/dump/fixtures.sql Outdated
@ -172,3 +172,4 @@
(1, 'Pay on receipt', '5720000001', 3, 0, 1, 1),
(2, 'Cash', '5700000001', 2, 0, 1, 1),
(3, 'Compensation', '4000000000', 8, 0, 1, 1),
(4, 'Transferencias', '4000000001', 1, 0, 1, 1),
carlosjr commented 2022-05-23 09:51:48 +00:00
Contributor
Copy Link

wrong language

wrong language
vicent marked this conversation as resolved
carlosjr removed the
CR / Tests passed
 label 2022-05-23 09:52:50 +00:00
vicent added 1 commit 2022-05-23 10:47:54 +00:00
gitea/salix/pipeline/head This commit looks good Details
ab6a0425f5 refactor: translate fixtures
vicent added the
CR / Tests passed
 label 2022-05-23 10:47:59 +00:00
vicent requested review from carlosjr 2022-05-23 10:48:02 +00:00
carlosjr approved these changes 2022-05-23 12:35:13 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr added 1 commit 2022-05-23 12:43:07 +00:00
gitea/salix/pipeline/head This commit looks good Details
c721d9ae82 Merge branch 'dev' into 4022-client.balance.create
carlosjr merged commit 1808eee9ab into dev 2022-05-23 12:52:23 +00:00
carlosjr deleted branch 4022-client.balance.create 2022-05-23 12:52:24 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#976
No description provided.
Delete Branch "4022-client.balance.create"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?