2470-account_e2e #980

Merged
carlosjr merged 6 commits from 2470-account_e2e into dev 2022-05-25 07:32:22 +00:00
Member
No description provided.
alexm added the
CR / Tests passed
label 2022-05-19 05:28:20 +00:00
alexm added 3 commits 2022-05-19 05:28:22 +00:00
gitea/salix/pipeline/head This commit looks good Details
89baf63646
feat(account): add e2e acl
gitea/salix/pipeline/head This commit looks good Details
34bcdf1bd3
test(account): acl, connections and accounts secctions
gitea/salix/pipeline/head This commit looks good Details
68c94ec3c1
typo
alexm added 1 commit 2022-05-19 13:02:52 +00:00
gitea/salix/pipeline/head This commit looks good Details
3650567caf
test(account): e2e for ldap and samba
carlosjr requested changes 2022-05-20 10:48:50 +00:00
@ -2545,2 +2545,4 @@
(4, 2, 0, 20.00, 0.00, NULL, 0, 0.00, 0),
(5, 442, 0, 0.00, 3.05, NULL, 0, 0.00, 0);
INSERT INTO `salix`.`ACL` (`model`, `property`, `accessType`, `permission`, `principalType`, `principalId`)
Contributor

is this code supposed to be here?

is this code supposed to be here?
alexm marked this conversation as resolved
@ -0,0 +40,4 @@
it('should edit the third acl', async() => {
await page.autocompleteSearch(selectors.accountAcl.model, 'AccessToken');
await page.autocompleteSearch(selectors.accountAcl.accessType, 'READ');
Contributor

isn't this one READ already?

isn't this one READ already?
alexm marked this conversation as resolved
@ -0,0 +48,4 @@
});
it('should delete the third result', async() => {
const firstResult = await page.waitToGetProperty(selectors.accountAcl.thirdAcl, 'innerText');
Contributor

first result using selector of the thirdAcl?

first result using selector of the thirdAcl?
alexm marked this conversation as resolved
@ -0,0 +52,4 @@
await page.waitToClick(selectors.accountAcl.deleteThirdAcl);
await page.waitToClick(selectors.globalItems.acceptButton);
const message = await page.waitForSnackbar();
const newFirstResult = await page.waitToGetProperty(selectors.accountAcl.thirdAcl, 'innerText');
Contributor

newFirst?

newFirst?
alexm marked this conversation as resolved
@ -0,0 +23,4 @@
expect(firstResult).toContain(account);
});
it('should kill this connection', async() => {
Contributor

"should kill this connection and then get redirected to the login page" this makes easier the code maintenance helping to understand what the test is actually doing

"should kill this connection and then get redirected to the login page" this makes easier the code maintenance helping to understand what the test is actually doing
alexm marked this conversation as resolved
carlosjr removed the
CR / Tests passed
label 2022-05-20 10:49:02 +00:00
alexm changed title from 2470-account_e2e to WIP: 2470-account_e2e 2022-05-23 06:16:38 +00:00
alexm added 1 commit 2022-05-25 05:36:10 +00:00
alexm added 1 commit 2022-05-25 06:27:35 +00:00
gitea/salix/pipeline/head This commit looks good Details
1b061852d2
fix e2e
alexm changed title from WIP: 2470-account_e2e to 2470-account_e2e 2022-05-25 06:27:53 +00:00
alexm added the
CR / Tests passed
label 2022-05-25 06:28:03 +00:00
alexm requested review from carlosjr 2022-05-25 06:28:05 +00:00
carlosjr approved these changes 2022-05-25 07:29:42 +00:00
carlosjr left a comment
Contributor

LGTM

LGTM
carlosjr merged commit 00fc060bed into dev 2022-05-25 07:32:22 +00:00
carlosjr deleted branch 2470-account_e2e 2022-05-25 07:32:22 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#980
No description provided.