4040-chat_sendQueued #993

Merged
joan merged 9 commits from 4040-chat_sendQueued into dev 2022-06-09 09:57:59 +00:00
Contributor
No description provided.
vicent added the
CR / Tests passed
label 2022-06-03 12:03:05 +00:00
vicent added 7 commits 2022-06-03 12:03:07 +00:00
gitea/salix/pipeline/head This commit looks good Details
7de0fd6634
feat: create table chat
gitea/salix/pipeline/head This commit looks good Details
f6028316f4
feat: endpoint sendQueued addded
gitea/salix/pipeline/head This commit is unstable Details
3eac002fb4
feat: add queue to send rocket messages
gitea/salix/pipeline/head This commit looks good Details
fa27e6dd58
fix: backTest
gitea/salix/pipeline/head This commit looks good Details
9f57481390
refator: change comments
gitea/salix/pipeline/head This commit looks good Details
e30817644a
fix: bug
gitea/salix/pipeline/head This commit looks good Details
e4b23fa14d
fix: bugs
carlosjr requested changes 2022-06-07 13:39:42 +00:00
@ -2,3 +1,3 @@
module.exports = Self => {
Self.remoteMethodCtx('send', {
description: 'Send a RocketChat message',
description: 'Insert in model Chat',
Contributor

Creates a direct message in the chat model for a user or a channel for example

Creates a direct message in the chat model for a user or a channel for example
vicent marked this conversation as resolved
@ -3,3 +1,3 @@
module.exports = Self => {
Self.remoteMethodCtx('sendCheckingPresence', {
description: 'Sends a RocketChat message to a connected user or department channel',
description: 'Insert in model Chat',
Contributor

this description MUST be different from the previously review endpoint.

Creates a message in the chat model checking the user status for example

this description MUST be different from the previously review endpoint. Creates a message in the chat model checking the user status for example
vicent marked this conversation as resolved
@ -96,0 +53,4 @@
attempts: 0
});
return true;
Contributor

be consistent about what your endpoints return.

for example back/methods/chat/send.js returns true or false and this one only returns true.

endpoints can also return the created instance or false.

be consistent about what your endpoints return. for example back/methods/chat/send.js returns true or false and this one only returns true. endpoints can also return the created instance or false.
vicent marked this conversation as resolved
vicent added 1 commit 2022-06-08 11:09:05 +00:00
gitea/salix/pipeline/head This commit looks good Details
93bb678738
updated endpoints description
vicent requested review from carlosjr 2022-06-08 11:14:25 +00:00
carlosjr requested changes 2022-06-09 08:03:45 +00:00
carlosjr added 1 commit 2022-06-09 08:44:38 +00:00
gitea/salix/pipeline/head This commit is unstable Details
cd5dba6fcb
Merge branch 'dev' into 4040-chat_sendQueued
carlosjr approved these changes 2022-06-09 08:45:25 +00:00
joan approved these changes 2022-06-09 09:57:43 +00:00
joan merged commit be50663faa into dev 2022-06-09 09:57:59 +00:00
joan deleted branch 4040-chat_sendQueued 2022-06-09 09:58:00 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#993
No description provided.