verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 65 Releases Wiki Activity

4164 - Endpoint refactor #996

Merged
joan merged 8 commits from 4164-edi_updateData into dev 2022-06-09 11:10:34 +00:00
Conversation 0 Commits 8 Files Changed 5 +193 -103
joan commented 2022-06-07 11:07:10 +00:00
Contributor
Copy Link
No description provided.
joan added 1 commit 2022-06-07 11:07:11 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
f77f5cee58 4164 - Endpoint refactor
joan added 1 commit 2022-06-07 11:07:28 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
33e9dacf60 Merge branch 'dev' into 4164-edi_updateData
joan added 1 commit 2022-06-07 11:15:17 +00:00
gitea/salix/pipeline/head This commit looks good Details
f633a09717 Removed package-lock
carlosjr approved these changes 2022-06-08 09:15:02 +00:00
carlosjr left a comment
Contributor
Copy Link

no se yo

no se yo
carlosjr requested review from alexm 2022-06-08 09:17:01 +00:00
carlosjr added 1 commit 2022-06-08 09:17:39 +00:00
gitea/salix/pipeline/head This commit looks good Details
a824da3908 Merge branch 'dev' into 4164-edi_updateData
juan approved these changes 2022-06-08 15:07:01 +00:00
back/methods/edi/updateData.js Outdated
@ -76,1 +87,4 @@
// Clean files
if (fs.existsSync(tempPath))
fs.rmSync(tempPath, {recursive: true, force: true});
juan commented 2022-06-08 14:53:49 +00:00
Owner
Copy Link

¿Porque no utilizas la version asíncrona (sin el sufijo Sync) con await en los métodos de fs?

Los métodos Sync bloquean el servidor en esa línea sin que pueda manejar otros eventos durante ese tiempo, en el backend es recomendable evitarlos siempre que se pueda.

¿Porque no utilizas la version asíncrona (sin el sufijo *Sync*) con await en los métodos de fs? Los métodos *Sync* bloquean el servidor en esa línea sin que pueda manejar otros eventos durante ese tiempo, en el backend es recomendable evitarlos siempre que se pueda.
joan marked this conversation as resolved
back/methods/edi/updateData.js
juan commented 2022-06-08 15:01:20 +00:00
Owner
Copy Link

En vez de coger la 5a línea sería más fiable coger aquella que contenga el nombre del fichero, al principio o final, en funcion de keyValue.

Rectifico: Para el fichero florecompc2.zip no se cumple, dentro del txt pone otro nombre: FloreCom08062022.zip

En vez de coger la 5a línea sería más fiable coger aquella que contenga el nombre del fichero, al principio o final, en funcion de *keyValue*. **Rectifico:** Para el fichero florecompc2.zip no se cumple, dentro del txt pone otro nombre: *FloreCom08062022.zip*
joan marked this conversation as resolved
alexm refused to review 2022-06-09 05:29:52 +00:00
joan added 1 commit 2022-06-09 08:14:00 +00:00
gitea/salix/pipeline/head This commit looks good Details
7fe7fb2e8f Replaced fs sync functions
carlosjr added 1 commit 2022-06-09 08:50:00 +00:00
gitea/salix/pipeline/head Build queued... Details
626057fc4e Merge branch 'dev' into 4164-edi_updateData
joan added 1 commit 2022-06-09 09:31:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
83d4627f2d Removed font color
juan approved these changes 2022-06-09 10:17:48 +00:00
juan added 1 commit 2022-06-09 10:18:12 +00:00
gitea/salix/pipeline/head This commit looks good Details
86605c3d67 Merge branch 'dev' into 4164-edi_updateData
joan merged commit d08e1cee23 into dev 2022-06-09 11:10:34 +00:00
joan deleted branch 4164-edi_updateData 2022-06-09 11:10:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
juan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#996
No description provided.
Delete Branch "4164-edi_updateData"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?