verdnatura/worker-time-control
verdnatura
/
worker-time-control
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

#6656 fix timetable #19

Merged
jorgep merged 2 commits from 6656-fixTimeTable into test 2024-01-17 14:01:06 +00:00
Conversation 0 Commits 2 Files Changed 1 +4 -12
jorgep commented 2024-01-12 15:12:08 +00:00
Member
Copy Link
No description provided.
jorgep requested review from jsegarra 2024-01-12 15:12:41 +00:00
jorgep added 1 commit 2024-01-12 15:13:24 +00:00
gitea/worker-time-control/pipeline/head This commit looks good Details
948be76654 fix: refs #6656 fix ifisemptytext
jsegarra requested changes 2024-01-15 06:37:19 +00:00
js/clockIn.js Outdated
@ -215,3 +213,1 @@
} else {
return "show";
}
if (!value.trim()) return "hide";
jsegarra commented 2024-01-15 06:37:17 +00:00
Member
Copy Link

Si los valores van a ser 2 y tan cortos, quizas lo cambiaría a ternario

Si los valores van a ser 2 y tan cortos, quizas lo cambiaría a ternario
jorgep marked this conversation as resolved
js/clockIn.js
@ -218,3 +215,4 @@
}
function ifIsEmptyImage(value) {
jsegarra commented 2024-01-15 06:35:36 +00:00
Member
Copy Link

Lo revisamos porque se podría dejar en una línea.
Ya que construyes un string en la 220, puedes aprovechar a darle un valor por defecto a value que sea in

Lo revisamos porque se podría dejar en una línea. Ya que construyes un string en la 220, puedes aprovechar a darle un valor por defecto a value que sea in
jorgep marked this conversation as resolved
js/clockIn.js
@ -224,2 +219,2 @@
return "img/" + value + ".svg";
}
if (!value.trim()) return "img/in.svg";
return "img/" + value + ".svg";
jsegarra commented 2024-01-15 06:35:51 +00:00
Member
Copy Link

Se podría usar template string

Se podría usar template string
jorgep marked this conversation as resolved
jorgep added 1 commit 2024-01-15 12:24:15 +00:00
gitea/worker-time-control/pipeline/head This commit looks good Details
d3f14d8ca3 fix: refs #6656 fix ifisemptytext
jorgep requested review from jsegarra 2024-01-15 12:26:05 +00:00
jsegarra approved these changes 2024-01-15 19:36:59 +00:00
jorgep merged commit fb22e4214e into test 2024-01-17 14:01:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/worker-time-control#19
No description provided.
Delete Branch "6656-fixTimeTable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?