verdnatura/worker-time-control
verdnatura
/
worker-time-control
0
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

#6555 refactor to js #28

Merged
jorgep merged 13 commits from 6555-refactorToJs into test 2024-10-10 13:51:47 +00:00
Conversation 2 Commits 13 Files Changed 8 +832 -640
jorgep commented 2024-06-04 08:25:01 +00:00
Member
Copy Link
No description provided.
jorgep added 1 commit 2024-06-04 12:38:12 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
9d323bdb21 refactor: refs #6555 create call fn & WIP: replace jquery
jorgep added 1 commit 2024-06-14 13:57:28 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
d2b5e1fc76 refactor: refs #6555 wip: improve error handler
jorgep added 1 commit 2024-06-14 15:01:10 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
ab326dd6ac fix: refs #6555 update package & fix params builder
jorgep added 1 commit 2024-06-14 15:06:34 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
76411063ba feat: refs #6555 iron out url parms builder
jorgep added 1 commit 2024-06-14 15:26:01 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
b2fa1d341b refactor: refs #6555 convert jquery index file to js
jorgep added 1 commit 2024-06-18 14:39:35 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
213b4f8520 refactor: #6555 code translation JQuery to Js
jorgep added 1 commit 2024-06-18 15:00:12 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
5e413cc352 refactor: refs #6555 improve performance
jorgep added 1 commit 2024-06-18 15:01:34 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
e2524362ed refactor: refs #6555 drop excess spaces
jorgep commented 2024-06-18 15:04:04 +00:00
Author
Member
Copy Link

@juan Que versión pongo en el package.json ?

@juan Que versión pongo en el package.json ?
jorgep commented 2024-06-18 15:13:32 +00:00
Author
Member
Copy Link

Yo valoraría crear tarea pare refactorizar el css...

  • Hay varias clases con nombres en español
  • Hay clases declaradas en camel-case en lugar de kebab-case
  • No se está aplicando la metodología BEM, siendo el css menos claro.

De paso, hacerlo responsive para que lo puedan usar en los moviles la gente del campo.

Yo valoraría crear tarea pare refactorizar el css... * Hay varias clases con nombres en español * Hay clases declaradas en camel-case en lugar de kebab-case * No se está aplicando la metodología BEM, siendo el css menos claro. De paso, hacerlo responsive para que lo puedan usar en los moviles la gente del campo.
jorgep added 1 commit 2024-06-18 15:37:31 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
f540a51dd1 refactor: refs #6555 adjust footer height
jorgep added 1 commit 2024-06-19 07:52:11 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
30d9acf58b fix: refs #6555 replace renewToken url
jorgep added 1 commit 2024-06-19 09:40:33 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
1f9bf03780 fix: refs #6555 uncomment redirect
jorgep added 2 commits 2024-06-19 11:18:47 +00:00
gitea/worker-time-control/pipeline/pr-test This commit looks good Details
5e1a5f313a refactor: refs #6555 check if is Empty
jorgep changed title from WIP: #6555 refactor to js to #6555 refactor to js 2024-06-19 11:31:48 +00:00
jorgep requested review from juan 2024-06-19 11:32:00 +00:00
juan approved these changes 2024-10-07 07:52:37 +00:00
jorgep merged commit 1db067a65a into test 2024-10-10 13:51:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
juan
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/worker-time-control#28
No description provided.
Delete Branch "6555-refactorToJs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?