verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 93 Releases Wiki Activity

feat: #7087 created CardSummary test #1197

Merged
provira merged 13 commits from 7087-testCardSummary into dev 2025-01-16 06:16:46 +00:00
Conversation 0 Commits 13 Files Changed 2 +78 -1
provira commented 2025-01-10 13:08:56 +00:00
Member
Copy Link
No description provided.
provira added 1 commit 2025-01-10 13:08:56 +00:00
provira added 1 commit 2025-01-10 13:09:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e8105f312f Merge branch 'dev' into 7087-testCardSummary
provira added 2 commits 2025-01-13 07:11:54 +00:00
provira changed title from WIP: feat: #7087 created CardSummary test to feat: #7087 created CardSummary test 2025-01-13 07:12:12 +00:00
provira added 1 commit 2025-01-13 07:12:15 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6c0181b2e4 Merge branch 'dev' into 7087-testCardSummary
provira requested review from jsegarra 2025-01-13 07:12:24 +00:00
jsegarra requested changes 2025-01-13 07:53:28 +00:00
Dismissed
src/components/ui/__tests__/CardSummary.spec.js
@ -0,0 +54,4 @@
it('should respond to prop changes and refetch data', async () => {
const fetchSpy = vi.spyOn(vm.arrayData, 'fetch');
await wrapper.setProps({ url: 'newUrl', filter: { key: 'newValue' } });
jsegarra commented 2025-01-13 07:53:16 +00:00
Member
Copy Link

En esta linea en las dos ultimas lineas se repiten los valores.
Podemos hacer un cambio para que solo haya un newUrl y un newValue?

En esta linea en las dos ultimas lineas se repiten los valores. Podemos hacer un cambio para que solo haya un newUrl y un newValue?
jsegarra requested changes 2025-01-13 08:34:48 +00:00
Dismissed
jsegarra left a comment
Member
Copy Link

Propongo añadir un test para probar la linea 50
isSummary.value = String(route.path).endsWith('/summary');

Propongo añadir un test para probar la linea 50 ` isSummary.value = String(route.path).endsWith('/summary'); `
provira added 1 commit 2025-01-13 11:42:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
c9c0e87e46 Merge branch 'dev' into 7087-testCardSummary
provira added 3 commits 2025-01-15 07:55:27 +00:00
provira added 1 commit 2025-01-15 07:58:02 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8e4a92b6be Merge branch 'dev' into 7087-testCardSummary
provira added 1 commit 2025-01-15 08:01:51 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
76968fe6bd fix: refs #7087 fixed some tests
provira added 1 commit 2025-01-15 08:56:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
979353119a refactor: refs #7087 removed unused imports
provira requested review from jsegarra 2025-01-15 08:59:10 +00:00
jsegarra approved these changes 2025-01-15 20:13:01 +00:00
provira added 1 commit 2025-01-16 06:15:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
a0f7905983 Merge branch 'dev' into 7087-testCardSummary
provira merged commit 4b9453380a into dev 2025-01-16 06:16:46 +00:00
provira deleted branch 7087-testCardSummary 2025-01-16 06:16:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jsegarra
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1197
No description provided.
Delete Branch "7087-testCardSummary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?