feat: refs #8442 add Vehicle DMS import functionality and routing #1377

Closed
jtubau wants to merge 13 commits from 8422-createVehicleDms into dev
Member
PR BACK: https://gitea.verdnatura.es/verdnatura/salix/pulls/3435
jtubau added 1 commit 2025-02-11 12:58:51 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
8f0a4da245
feat: refs #8422 add Vehicle DMS import functionality and routing
jtubau requested review from jorgep 2025-02-12 13:57:55 +00:00
jtubau changed title from feat: refs #8422 add Vehicle DMS import functionality and routing to WIP: feat: refs #8422 add Vehicle DMS import functionality and routing 2025-02-13 15:04:12 +00:00
jorgep reviewed 2025-02-14 17:44:13 +00:00
@ -0,0 +1,76 @@
<script setup>
Member

e2e. De paso crear tarea test componente VnDmsList

e2e. De paso crear tarea test componente VnDmsList
Author
Member
Ya hay tarea para ello. https://redmine.verdnatura.es/issues/8561
jtubau marked this conversation as resolved
jorgep requested changes 2025-02-14 17:44:58 +00:00
jorgep left a comment
Member

.

.
jtubau changed title from WIP: feat: refs #8422 add Vehicle DMS import functionality and routing to WIP: feat: refs #8442 add Vehicle DMS import functionality and routing 2025-03-03 13:56:06 +00:00
jtubau added 1 commit 2025-03-05 06:42:10 +00:00
jtubau added 2 commits 2025-03-05 10:14:31 +00:00
jtubau added 1 commit 2025-03-06 12:49:26 +00:00
jtubau requested review from jorgep 2025-03-07 11:52:53 +00:00
jorgep requested changes 2025-03-10 10:44:55 +00:00
@ -0,0 +54,4 @@
:save-fn="importDms"
>
<template #form-inputs>
<VnRow>
Member

el slot form-inputs ya tiene la clase row, creo que no hace falta usar vnRow

el slot form-inputs ya tiene la clase row, creo que no hace falta usar vnRow
Author
Member

comprobado, no hace falta utilizarla, resuelto.

comprobado, no hace falta utilizarla, resuelto.
jtubau marked this conversation as resolved
@ -0,0 +25,4 @@
<QDialog v-model="showImportDialog">
<VehicleDmsImportForm @on-data-saved="onDataSaved()" />
</QDialog>
<QPageSticky position="bottom-right" :offset="[25, 90]">
Member

Haz esto genérico, para que cualquier sección Dms pueda añadir un btn de añadir o la acción que se desee. Avísame y lo miramos si hace falta.

Haz esto genérico, para que cualquier sección Dms pueda añadir un btn de añadir o la acción que se desee. Avísame y lo miramos si hace falta.
Author
Member

Quedamos en hacer una tarea

Quedamos en hacer una tarea
jtubau marked this conversation as resolved
@ -0,0 +43,4 @@
cy.get('.q-table')
.children()
.should('be.visible')
.should('have.length.greaterThan', 0);
Member

Cambia de vehículo y comprueba que el número de dms ha cambiado, deja tu comprobación también.

Cambia de vehículo y comprueba que el número de dms ha cambiado, deja tu comprobación también.
@ -0,0 +52,4 @@
cy.dataCy(selectors.addBtn).click();
cy.dataCy(selectors.referenceInput).type(data.Reference.val);
cy.dataCy(selectors.fileInput).type(filePath);
cy.dataCy(selectors.saveFormBtn).click();
Member

Comprueba que se ha añadido el archivo.

Comprueba que se ha añadido el archivo.
Author
Member

incluido

incluido
Member

Perfecto

Perfecto
jtubau marked this conversation as resolved
@ -0,0 +84,4 @@
it('Should delete DMS', () => {
cy.get(selectors.lastRowDeleteBtn).click();
cy.clickConfirm();
cy.validateContent(selectors.firstRowReference, 'Vehicle:3333-BAT');
Member

Podrías comprobar que se muestra la notificación "archivo borrado" o algo así.

Podrías comprobar que se muestra la notificación "archivo borrado" o algo así.
Author
Member

incluido

incluido
jtubau marked this conversation as resolved
@ -0,0 +88,4 @@
});
it('Should redirect to worker summary from worker descriptor pop-up', () => {
cy.get(':nth-child(1) > :nth-child(8) > .q-tr > .link').click();
Member

Añade data-cy si es posible, usa nombres de variables para que quede más claro a que $elemento estás acceciendo.

Añade data-cy si es posible, usa nombres de variables para que quede más claro a que $elemento estás acceciendo.
jtubau marked this conversation as resolved
@ -180,3 +180,3 @@
break;
default:
cy.wrap(el).type(val);
cy.wrap(el).clear().type(val);
Member

Puedes hacer .type('{selectionall}xxxxxx')

Puedes hacer **.type('{selectionall}xxxxxx')**
jtubau marked this conversation as resolved
jtubau added 1 commit 2025-03-11 12:02:31 +00:00
jtubau added 2 commits 2025-03-12 07:30:24 +00:00
jtubau added 1 commit 2025-03-12 07:32:49 +00:00
jtubau added 1 commit 2025-03-14 13:57:44 +00:00
jtubau changed title from WIP: feat: refs #8442 add Vehicle DMS import functionality and routing to feat: refs #8442 add Vehicle DMS import functionality and routing 2025-03-17 07:48:08 +00:00
jtubau requested review from jorgep 2025-03-17 07:48:18 +00:00
jorgep reviewed 2025-03-18 09:42:49 +00:00
@ -44,6 +44,7 @@ export default defineConfig({
supportFile: 'test/cypress/support/index.js',
videosFolder: 'test/cypress/videos',
downloadsFolder: 'test/cypress/downloads',
tmpUploadFolder: '../salix/storage/tmp/dms',
Member

@alexm ok?

@alexm ok?
jorgep reviewed 2025-03-18 09:43:57 +00:00
jorgep requested changes 2025-03-18 09:55:43 +00:00
@ -82,6 +84,7 @@ async function save() {
const body = mapperDms(dms.value);
const response = await axios.post(getUrl(), body[0], body[1]);
emit('onDataSaved', body[1].params, response);
notify(t('globals.dataSaved'), 'positive');
Member

try/catch, si falla, lanza el err, asegurate de que el usuario lo vea.

try/catch, si falla, lanza el **err**, asegurate de que el usuario lo vea.
jtubau marked this conversation as resolved
@ -0,0 +43,4 @@
@on-fetch="(data) => (dmsOptions = data)"
/>
<FormModelPopup
url-create="genera"
Member

Esta url está mal no? Aunque creo que como ya tienes save-fn no hace falta.

Esta url está mal no? Aunque creo que como ya tienes **save-fn** no hace falta.
jtubau marked this conversation as resolved
@ -0,0 +3,4 @@
`tr:last-child > .text-right > .no-wrap > :nth-child(${btnPosition}) > .q-btn > .q-btn__content > .q-icon`;
const selectors = {
lastRowDownloadBtn: getSelector(1),
Member

tienen data-cy

tienen data-cy
jtubau marked this conversation as resolved
@ -0,0 +7,4 @@
lastRowEditBtn: getSelector(2),
lastRowDeleteBtn: getSelector(3),
lastRowReference: 'tr:last-child > :nth-child(5) > .q-tr > :nth-child(1) > span',
firstRowReference:
Member

Puedes acceder a los data-set: data-row-index y data-col-field para acceder a los td de forma más fácil

Puedes acceder a los data-set: **data-row-index** y **data-col-field** para acceder a los td de forma más fácil
jorgep marked this conversation as resolved
@ -0,0 +15,4 @@
'.q-menu > .descriptor > .body > .q-list > .q-item__label--header > .title > span',
workerDescriptorGoToSummary:
'[href="#/worker/5/summary"] > .q-btn > .q-btn__content > .q-icon',
summaryTitle: '.summaryHeader > div',
Member

usar data-cy

usar data-cy
jtubau marked this conversation as resolved
Member

Puedes acceder a estos selectores para acceder a los td de la tabla:

image

Y para los botones de acciones:

image

Puedes acceder a estos selectores para acceder a los td de la tabla: ![image](/attachments/bba5f502-42ca-4b24-af50-31015599ae94) Y para los botones de acciones: ![image](/attachments/3cfb3c83-c6f9-4eb5-8d57-8c643a1eb4a8)
140 KiB
131 KiB
jtubau added 1 commit 2025-03-18 13:24:31 +00:00
jtubau added 1 commit 2025-03-18 14:55:01 +00:00
gitea/salix-front/pipeline/pr-dev There was a failure building this commit Details
5d356428d3
refactor: refs #8422 enhance error handling in save function and update selectors in tests
jtubau added 1 commit 2025-03-20 08:25:25 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
de9f1bca9a
Merge branch 'dev' into 8422-createVehicleDms
jtubau closed this pull request 2025-03-20 11:07:55 +00:00
jtubau reopened this pull request 2025-03-20 11:08:08 +00:00
jtubau closed this pull request 2025-03-20 11:18:39 +00:00
Some checks reported warnings
gitea/salix-front/pipeline/pr-dev This commit is unstable
Required
Details

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1377
No description provided.