verdnatura/salix
verdnatura
/
salix
3
5
Fork 0
Code Issues Pull Requests 65 Releases Wiki Activity

WIP: feat: refs #8442 add VehicleDms model and related methods for file management #3435

Draft
jtubau wants to merge 1 commits from 8442-createVehicleDms into dev
pull from: 8442-createVehicleDms
merge into: verdnatura:dev
Conversation 0 Commits 1 Files Changed 10 +1765 -1568
jtubau commented 2025-02-11 12:59:20 +00:00
Member
Copy Link

PR FRONT: verdnatura/salix-front#1377

PR FRONT: https://gitea.verdnatura.es/verdnatura/salix-front/pulls/1377
jtubau added 1 commit 2025-02-11 12:59:20 +00:00
jtubau requested review from jorgep 2025-02-12 13:58:01 +00:00
jtubau changed title from feat: refs #8442 add VehicleDms model and related methods for file management to WIP: feat: refs #8442 add VehicleDms model and related methods for file management 2025-02-13 15:04:16 +00:00
jorgep reviewed 2025-02-17 17:17:33 +00:00
db/dump/.dump/structure.sql
@ -2912,55 +2912,55 @@ DELIMITER ;
/*!50003 SET collation_connection = utf8mb4_unicode_ci */ ;
DELIMITER ;;
jorgep commented 2025-02-17 17:17:33 +00:00
Member
Copy Link

Este archivo no deberías tocarlo.

Este archivo no deberías tocarlo.
jorgep reviewed 2025-02-17 17:20:05 +00:00
db/versions/11434-yellowBirch/00-firstScript.sql
@ -0,0 +3,4 @@
`dmsFk` int(11) NOT NULL,
`editorFk` int(10) unsigned DEFAULT NULL,
PRIMARY KEY (`vehicleFk`,`dmsFk`),
KEY `gestdoc_id` (`dmsFk`),
jorgep commented 2025-02-17 17:20:05 +00:00
Member
Copy Link

@jgallego el nombre de la clave ok?

@jgallego el nombre de la clave ok?
jorgep requested changes 2025-02-17 17:20:30 +00:00
jorgep left a comment
Member
Copy Link

Faltan los tests de back de los métodos que has creado.

Faltan los tests de back de los métodos que has creado.
jgallego requested changes 2025-02-18 07:43:21 +00:00
db/versions/11434-yellowBirch/00-firstScript.sql
@ -0,0 +1,21 @@
CREATE TABLE IF NOT EXISTS `vehicleDms` (
jgallego commented 2025-02-18 07:43:14 +00:00
Owner
Copy Link

las claves primarias dobles no son compatibles con loopback, por eso la tabla vehicleDms tenia un id autoincrement, cual es el objetivo de cambiar la estructura de la tabla?

las claves primarias dobles no son compatibles con loopback, por eso la tabla vehicleDms tenia un id autoincrement, cual es el objetivo de cambiar la estructura de la tabla?
All checks were successful
gitea/salix/pipeline/pr-dev This commit looks good
Required
Details
This pull request has changes conflicting with the target branch.
  • db/dump/.dump/structure.sql
Sign in to join this conversation.
Reviewers
No reviewers
jorgep
jgallego
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#3435
No description provided.
Delete Branch "8442-createVehicleDms"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?