verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 78 Releases Wiki Activity

fix_vnLinkPhone #1659

Merged
jsegarra merged 10 commits from fix_vnLinkPhone into dev 2025-04-02 07:53:16 +00:00
Conversation 6 Commits 10 Files Changed 7 +77 -63
jsegarra commented 2025-03-31 13:16:16 +00:00
Member
Copy Link
No description provided.
jsegarra added 5 commits 2025-03-31 13:16:16 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
gitea/salix-front/pipeline/pr-test This commit looks good Details
d71029c7e9 feat: dashIfEmpty
jsegarra requested review from alexm 2025-03-31 13:16:19 +00:00
alexm requested changes 2025-04-01 05:18:17 +00:00
Dismissed
src/pages/Customer/Card/CustomerSummary.vue Outdated
@ -102,1 +92,3 @@
/>
<VnLv :label="t('customer.summary.mobile')">
<template #value>
<div class="col">
alexm commented 2025-04-01 05:17:42 +00:00
Member
Copy Link
<div class="row">
<VnLinkPhone .../>
<VnLinkPhone .../>
</div>

Lo querias en linea?

``` <div class="row"> <VnLinkPhone .../> <VnLinkPhone .../> </div> ``` Lo querias en linea?
jsegarra commented 2025-04-01 07:02:27 +00:00
Author
Member
Copy Link

Con tu solución, se ve así

Con tu solución, se ve así
jsegarra commented 2025-04-01 13:11:08 +00:00
Author
Member
Copy Link

Ahora solo hay 1

Ahora solo hay 1
jsegarra commented 2025-04-01 07:02:48 +00:00
Author
Member
Copy Link

#1659 (comment)
image

https://gitea.verdnatura.es/verdnatura/salix-front/pulls/1659#issuecomment-86488 ![image](/attachments/2754fddc-bf40-4a41-b97b-a60cd0d7b08f)
image.png
85 KiB
jsegarra commented 2025-04-01 07:03:16 +00:00
Author
Member
Copy Link

Con el código que está se ve así
image

Con el código que está se ve así ![image](/attachments/c44b0959-c8bd-47f0-9511-dab150be82a7)
image.png
84 KiB
jsegarra requested review from alexm 2025-04-01 08:51:42 +00:00
alexm requested changes 2025-04-01 08:54:34 +00:00
Dismissed
alexm left a comment
Member
Copy Link

Se ve un poco raro no?
image

Se ve un poco raro no? ![image](/attachments/c4e525b9-adee-4a6f-b14f-dd43fc35dbd5)
image.png
7.6 KiB
alexm changed target branch from dev to test 2025-04-01 10:19:12 +00:00
jsegarra added 18 commits 2025-04-01 12:52:38 +00:00
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
f8cc7b95ab refactor: refs #7995 modified hasAcl function
gitea/salix-front/pipeline/pr-dev This commit looks good Details
801e9687f7 Merge branch 'dev' into 7995-CreateHasAcl
gitea/salix-front/pipeline/head This commit looks good Details
044c607405 chore: update version to 25.16.0 in package.json
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
27ec560fc5 Merge branch 'dev' into 7995-CreateHasAcl
gitea/salix-front/pipeline/pr-dev This commit is unstable Details
3ddc6dc310 Merge branch 'dev' into 7995-CreateHasAcl
gitea/salix-front/pipeline/pr-dev This commit looks good Details
26861e92b6 Merge branch 'dev' into 7995-CreateHasAcl
gitea/salix-front/pipeline/head This commit looks good Details
da21c0aad6 Merge pull request '#7995: Added hasAcl to check only one acl' (!1654) from 7995-CreateHasAcl into dev 
Reviewed-on: #1654
Reviewed-by: Jorge Penadés <jorgep@verdnatura.es>
gitea/salix-front/pipeline/pr-dev Build queued... Details
gitea/salix-front/pipeline/pr-test This commit looks good Details
8849b9ed97 Merge branch 'dev' into fix_vnLinkPhone
jsegarra requested review from alexm 2025-04-01 12:57:55 +00:00
jsegarra changed target branch from test to dev 2025-04-01 12:58:19 +00:00
jsegarra reviewed 2025-04-01 12:59:00 +00:00
src/components/ui/CardSummary.vue
@ -169,6 +170,10 @@ async function fetch() {
flex-grow: 0;
flex-shrink: 0;
}
&.ellipsis > .value {
jsegarra commented 2025-04-01 12:59:00 +00:00
Author
Member
Copy Link

He creado la clase ellipsis para que desde el summary se pueda poner a pupilaje
De esta manera mantenemos la direccion del consignatario totalmente visible

He creado la clase ellipsis para que desde el summary se pueda poner a pupilaje De esta manera mantenemos la direccion del consignatario totalmente visible
alexm commented 2025-04-02 05:25:35 +00:00
Member
Copy Link

Quasar tiene la clase ellipsis (no la he probado) pero seria lo mismo? https://quasar.dev/style/visibility/

Quasar tiene la clase ellipsis (no la he probado) pero seria lo mismo? https://quasar.dev/style/visibility/
jsegarra commented 2025-04-02 06:00:54 +00:00
Author
Member
Copy Link

lo pruebo y te vuelvo a pedir revision

lo pruebo y te vuelvo a pedir revision
jsegarra commented 2025-04-02 07:48:33 +00:00
Author
Member
Copy Link

Negativo para tu propuesta porque date cuenta que esa clase afecta al componente VnLv, no al value que es hijo de VnLv, es decir, no se hereda

Negativo para tu propuesta porque date cuenta que esa clase afecta al componente VnLv, no al value que es hijo de VnLv, es decir, no se hereda
jsegarra reviewed 2025-04-01 12:59:11 +00:00
src/components/ui/VnLinkMail.vue
@ -3,3 +5,4 @@
</script>
<template>
<QBtn
class="q-pr-xs"
jsegarra commented 2025-04-01 12:59:11 +00:00
Author
Member
Copy Link

Le doy un espacio a la derecha al icono

Le doy un espacio a la derecha al icono
jsegarra reviewed 2025-04-01 12:59:23 +00:00
src/components/ui/VnLinkMail.vue
@ -13,4 +16,5 @@ defineProps({ email: { type: [String], default: null } });
:href="`mailto:${email}`"
@click.stop
/>
<span>{{ dashIfEmpty(email) }}</span>
jsegarra commented 2025-04-01 12:59:23 +00:00
Author
Member
Copy Link

Delego la funcionalidad del componente de mostrar su valor

Delego la funcionalidad del componente de mostrar su valor
jsegarra reviewed 2025-04-01 12:59:49 +00:00
src/components/ui/VnLinkPhone.vue
@ -2,3 +2,3 @@
import { ref, reactive, useAttrs, onBeforeMount, capitalize } from 'vue';
import axios from 'axios';
import { parsePhone } from 'src/filters';
import { dashIfEmpty, parsePhone } from 'src/filters';
jsegarra commented 2025-04-01 12:59:49 +00:00
Author
Member
Copy Link

Con este cambio, evito depender del numero de instancias, ahora con atributos es suficiente

Con este cambio, evito depender del numero de instancias, ahora con atributos es suficiente
jsegarra reviewed 2025-04-01 13:09:38 +00:00
src/pages/Customer/Card/CustomerSummary.vue Outdated
@ -108,1 +107,3 @@
<VnLinkMail email="entity.email"></VnLinkMail> </template
<VnLv
:label="t('globals.params.email')"
:value="entity.email"
jsegarra commented 2025-04-01 13:09:38 +00:00
Author
Member
Copy Link

Lo pongo otra vez para el copy
Deberiamos crear tarea para una diectiva de copiar

Lo pongo otra vez para el copy Deberiamos crear tarea para una diectiva de copiar
jsegarra added 1 commit 2025-04-01 13:10:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
f02fa732ee feat: remove unused vnLinkPhone
jsegarra commented 2025-04-01 13:12:01 +00:00
Author
Member
Copy Link

Ahora se ve así
2 iconos para el mismo telefono y el email truncado
image

Ahora se ve así 2 iconos para el mismo telefono y el email truncado ![image](/attachments/bace0baf-9df5-4088-9bfe-93955e2aca24)
image.png
72 KiB
alexm approved these changes 2025-04-02 05:27:39 +00:00
alexm commented 2025-04-02 05:28:16 +00:00
Member
Copy Link

Deberia ir a test no? Se ve mal ahi tb

Deberia ir a test no? Se ve mal ahi tb
jsegarra commented 2025-04-02 07:48:50 +00:00
Author
Member
Copy Link

Deberia ir a test no? Se ve mal ahi tb

Aplicamos en dev, validamos y luego cherry pick de la fusión

> Deberia ir a test no? Se ve mal ahi tb Aplicamos en dev, validamos y luego cherry pick de la fusión
jsegarra commented 2025-04-02 07:49:17 +00:00
Author
Member
Copy Link

Cuando lo hagamos a test, modificaremos Worker descriptor porque no se aplica ellipsis

Cuando lo hagamos a test, modificaremos Worker descriptor porque no se aplica ellipsis
jsegarra merged commit 22b57f850c into dev 2025-04-02 07:53:16 +00:00
jsegarra deleted branch fix_vnLinkPhone 2025-04-02 07:53:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#1659
No description provided.
Delete Branch "fix_vnLinkPhone"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?