verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 91 Releases Wiki Activity

refactor: refs #7361 ticket/summary like salix #368

Merged
jon merged 14 commits from 7361-TicketSummaryRefactor into dev 2024-05-20 05:09:12 +00:00
Conversation 1 Commits 14 Files Changed 1 +46 -12
jon commented 2024-05-10 10:00:58 +00:00
Member
Copy Link
No description provided.
jon added 1 commit 2024-05-10 10:00:58 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
071e6a7296 refactor: refs #7361 ticket/summary like salix
jon added 1 commit 2024-05-10 10:01:52 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
686bead961 Merge branch 'dev' into 7361-TicketSummaryRefactor
jon requested review from alexm 2024-05-10 10:02:39 +00:00
jon added 1 commit 2024-05-13 05:08:21 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
68082dddd0 Merge branch 'dev' into 7361-TicketSummaryRefactor
alexm reviewed 2024-05-13 05:49:36 +00:00
src/pages/Ticket/Card/TicketSummary.vue Outdated
@ -456,0 +481,4 @@
.subName {
color: var(--vn-label-color);
margin-left: -40%;
alexm commented 2024-05-13 05:49:36 +00:00
Member
Copy Link

Poner márgenes negativos lo veo raro

Poner márgenes negativos lo veo raro
jon marked this conversation as resolved
alexm requested changes 2024-05-13 05:51:39 +00:00
Dismissed
src/pages/Ticket/Card/TicketSummary.vue Outdated
@ -364,4 +374,4 @@
<QTd>{{ props.row.visible }}</QTd>
<QTd>{{ props.row.available }}</QTd>
<QTd>{{ props.row.quantity }}</QTd>
<QTd>
alexm commented 2024-05-13 05:51:38 +00:00
Member
Copy Link

Creo que igual fusionando las dos columnas en una y la parte de fetched-tags(Cambialo por CamelCase) y la del subname las pones en un div con flex row igual se alinea mejor

Creo que igual fusionando las dos columnas en una y la parte de fetched-tags(Cambialo por CamelCase) y la del subname las pones en un div con flex row igual se alinea mejor
jon marked this conversation as resolved
src/pages/Ticket/Card/TicketSummary.vue Outdated
@ -456,0 +486,4 @@
.fetched-tags {
width: 70%;
margin-left: 19%;
alexm commented 2024-05-13 05:50:07 +00:00
Member
Copy Link

Creo que lo que quieres es centrar el contenido,. buscaria otra forma de hacerlo, igual con flex se puede

Creo que lo que quieres es centrar el contenido,. buscaria otra forma de hacerlo, igual con flex se puede
jon marked this conversation as resolved
alexm commented 2024-05-13 05:52:52 +00:00
Member
Copy Link

Algo asi (⚠️ Asi tal cual no funciona, es solo para explicarme):
image

Algo asi (⚠️ Asi tal cual no funciona, es solo para explicarme): ![image](/attachments/bbde4657-e677-43c3-a644-766a37d0a18b)
image.png
76 KiB
jon added 2 commits 2024-05-13 11:58:01 +00:00
jon added 1 commit 2024-05-13 11:58:52 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
04ce9558b7 Merge branch 'dev' into 7361-TicketSummaryRefactor
jon requested review from alexm 2024-05-13 11:59:47 +00:00
alexm requested changes 2024-05-15 06:31:34 +00:00
Dismissed
src/pages/Ticket/Card/TicketSummary.vue
@ -365,3 +374,3 @@
<QTd>{{ props.row.available }}</QTd>
<QTd>{{ props.row.quantity }}</QTd>
<QTd>
<QTd class="description-cell">
alexm commented 2024-05-15 06:31:09 +00:00
Member
Copy Link
                            <QTd class="description-cell">
                                <div class="row full-width justify-between">
                                    {{ props.row.item.name }}
                                    <div v-if="props.row.item.subName" class="subName">
                                        {{ props.row.item.subName.toUpperCase() }}
                                    </div>
                                </div>
                                <FetchedTags
                                    :item="props.row.item"
                                    :max-length="6"
                                    class="fetched-tags"
                                />
                            </QTd>
``` <QTd class="description-cell"> <div class="row full-width justify-between"> {{ props.row.item.name }} <div v-if="props.row.item.subName" class="subName"> {{ props.row.item.subName.toUpperCase() }} </div> </div> <FetchedTags :item="props.row.item" :max-length="6" class="fetched-tags" /> </QTd> ```
jon marked this conversation as resolved
src/pages/Ticket/Card/TicketSummary.vue Outdated
@ -456,0 +479,4 @@
.subName {
color: var(--vn-label-color);
}
.description-cell {
alexm commented 2024-05-15 06:31:29 +00:00
Member
Copy Link

.description-cell {
width: 25%;
}
.fetched-tags {
max-width: 70%;
}

.description-cell { width: 25%; } .fetched-tags { max-width: 70%; }
jon marked this conversation as resolved
jon added 2 commits 2024-05-15 12:35:16 +00:00
jon added 1 commit 2024-05-15 12:36:01 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e766bdfdfb Merge branch 'dev' into 7361-TicketSummaryRefactor
jon requested review from alexm 2024-05-15 12:36:47 +00:00
jon added 1 commit 2024-05-16 05:18:16 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
6603c81aa3 Merge branch 'dev' into 7361-TicketSummaryRefactor
alexm requested changes 2024-05-16 06:05:43 +00:00
Dismissed
src/pages/Ticket/Card/TicketSummary.vue Outdated
@ -456,0 +484,4 @@
.fetched-tags {
max-width: 70%;
}
.fetched-tags > * {
alexm commented 2024-05-16 06:05:41 +00:00
Member
Copy Link

Esta creo que ya no hace falta, aparte calc(100% / 2) es lo mismo que poner 50%

Esta creo que ya no hace falta, aparte calc(100% / 2) es lo mismo que poner 50%
jon added 2 commits 2024-05-17 08:30:57 +00:00
jon added 1 commit 2024-05-17 08:31:54 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
8b835e299b Merge branch 'dev' into 7361-TicketSummaryRefactor
jon requested review from alexm 2024-05-17 08:55:04 +00:00
alexm approved these changes 2024-05-17 12:37:08 +00:00
jon added 1 commit 2024-05-20 05:08:04 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
708a852473 Merge branch 'dev' into 7361-TicketSummaryRefactor
jon merged commit bfbe71c63e into dev 2024-05-20 05:09:12 +00:00
jon deleted branch 7361-TicketSummaryRefactor 2024-05-20 05:09:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#368
No description provided.
Delete Branch "7361-TicketSummaryRefactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?