verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 96 Releases Wiki Activity

refactor: refs #7361 ticket/summary like salix #368

Merged
jon merged 14 commits from 7361-TicketSummaryRefactor into dev 2024-05-20 05:09:12 +00:00
Conversation 1 Commits 14 Files Changed 1 +46 -12
1 changed files with 46 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

58
src/pages/Ticket/Card/TicketSummary.vue
View File

@ -13,6 +13,7 @@ import VnLinkPhone from 'src/components/ui/VnLinkPhone.vue';
import { getUrl } from 'src/composables/getUrl';
import VnUserLink from 'src/components/ui/VnUserLink.vue';
import VnTitle from 'src/components/common/VnTitle.vue';
import ItemDescriptorProxy from 'src/pages/Item/Card/ItemDescriptorProxy.vue';
const route = useRoute();
const router = useRouter();
@ -262,9 +263,12 @@ async function changeState(value) {
:url="ticketUrl + 'sale'"
:text="t('ticket.summary.saleLines')"
/>
<QTable :rows="ticket.sales">
<QTable :rows="ticket.sales" style="text-align: center">
<template #body-cell="{ value }">
<QTd>{{ value }}</QTd>
</template>
<template #header="props">
<QTr :props="props">
<QTr class="tr-header" :props="props">
<QTh auto-width></QTh>
<QTh auto-width>{{ t('ticket.summary.item') }}</QTh>
<QTh auto-width>{{ t('ticket.summary.visible') }}</QTh>
@ -360,23 +364,29 @@ async function changeState(value) {
</QTooltip>
</QIcon>
</QTd>
<QTd class="link">{{ props.row.itemFk }}</QTd>
<QTd>
<QBtn class="link" flat>
{{ props.row.itemFk }}
<ItemDescriptorProxy :id="props.row.itemFk" />
</QBtn>
</QTd>
<QTd>{{ props.row.visible }}</QTd>
<QTd>{{ props.row.available }}</QTd>
<QTd>{{ props.row.quantity }}</QTd>
<QTd>
<div class="fetched-tags">
<span>{{ props.row.item.name }}</span>
<span v-if="props.row.item.subName" class="subName">{{
props.row.item.subName
}}</span>
<QTd class="description-cell">
jon marked this conversation as resolved
alexm commented 2024-05-15 06:31:09 +00:00
Review
Copy Link
                            <QTd class="description-cell">
                                <div class="row full-width justify-between">
                                    {{ props.row.item.name }}
                                    <div v-if="props.row.item.subName" class="subName">
                                        {{ props.row.item.subName.toUpperCase() }}
                                    </div>
                                </div>
                                <FetchedTags
                                    :item="props.row.item"
                                    :max-length="6"
                                    class="fetched-tags"
                                />
                            </QTd>
``` <QTd class="description-cell"> <div class="row full-width justify-between"> {{ props.row.item.name }} <div v-if="props.row.item.subName" class="subName"> {{ props.row.item.subName.toUpperCase() }} </div> </div> <FetchedTags :item="props.row.item" :max-length="6" class="fetched-tags" /> </QTd> ```
<div class="row full-width justify-between">
jon marked this conversation as resolved Outdated
alexm commented 2024-05-13 05:51:38 +00:00
Outdated
Review
Copy Link

Creo que igual fusionando las dos columnas en una y la parte de fetched-tags(Cambialo por CamelCase) y la del subname las pones en un div con flex row igual se alinea mejor

Creo que igual fusionando las dos columnas en una y la parte de fetched-tags(Cambialo por CamelCase) y la del subname las pones en un div con flex row igual se alinea mejor
{{ props.row.item.name }}
<div v-if="props.row.item.subName" class="subName">
{{ props.row.item.subName.toUpperCase() }}
</div>
</div>
<fetched-tags
<FetchedTags
class="fetched-tags"
:item="props.row.item"
:max-length="5"
></fetched-tags>
></FetchedTags>
</QTd>
<QTd>{{ props.row.price }}</QTd>
<QTd>{{ props.row.price }} €</QTd>
<QTd>{{ props.row.discount }} %</QTd>
<QTd
>{{
@ -453,4 +463,28 @@ async function changeState(value) {
padding: 1%;
}
}
.q-table {
tr,
th,
.q-td {
border-bottom: 1px solid black;
}
}
.subName {
margin-left: 10%;
}
.tr-header,
.subName {
color: var(--vn-label-color);
}
jon marked this conversation as resolved Outdated
alexm commented 2024-05-15 06:31:29 +00:00
Outdated
Review
Copy Link

.description-cell {
width: 25%;
}
.fetched-tags {
max-width: 70%;
}

.description-cell { width: 25%; } .fetched-tags { max-width: 70%; }
.description-cell {
width: 25%;
jon marked this conversation as resolved Outdated
alexm commented 2024-05-13 05:49:36 +00:00
Outdated
Review
Copy Link

Poner márgenes negativos lo veo raro

Poner márgenes negativos lo veo raro
}
.fetched-tags {
alexm commented 2024-05-16 06:05:41 +00:00
Outdated
Review
Copy Link

Esta creo que ya no hace falta, aparte calc(100% / 2) es lo mismo que poner 50%

Esta creo que ya no hace falta, aparte calc(100% / 2) es lo mismo que poner 50%
max-width: 70%;
}
jon marked this conversation as resolved Outdated
alexm commented 2024-05-13 05:50:07 +00:00
Outdated
Review
Copy Link

Creo que lo que quieres es centrar el contenido,. buscaria otra forma de hacerlo, igual con flex se puede

Creo que lo que quieres es centrar el contenido,. buscaria otra forma de hacerlo, igual con flex se puede
</style>