verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 88 Releases Wiki Activity

refactor: refs #7361 ticket/summary like salix #368

Merged
jon merged 14 commits from 7361-TicketSummaryRefactor into dev 2024-05-20 05:09:12 +00:00
Conversation 1 Commits 14 Files Changed 1 +19 -17
1 changed files with 19 additions and 17 deletions
Showing only changes of commit 2859a7bad6 - Show all commits
src/pages/Ticket/Card
TicketSummary.vue

36
src/pages/Ticket/Card/TicketSummary.vue
View File

@ -275,7 +275,6 @@ async function changeState(value) {
<QTh auto-width>{{ t('ticket.summary.available') }}</QTh>
<QTh auto-width>{{ t('ticket.summary.quantity') }}</QTh>
<QTh auto-width>{{ t('globals.description') }}</QTh>
<QTh auto-width></QTh>
<QTh auto-width>{{ t('ticket.summary.price') }}</QTh>
<QTh auto-width>{{ t('ticket.summary.discount') }}</QTh>
<QTh auto-width>{{ t('globals.amount') }}</QTh>
@ -374,20 +373,19 @@ async function changeState(value) {
<QTd>{{ props.row.visible }}</QTd>
<QTd>{{ props.row.available }}</QTd>
<QTd>{{ props.row.quantity }}</QTd>
<QTd>
<QTd class="description-cell">
jon marked this conversation as resolved
alexm commented 2024-05-15 06:31:09 +00:00
Review 
                            <QTd class="description-cell">
                                <div class="row full-width justify-between">
                                    {{ props.row.item.name }}
                                    <div v-if="props.row.item.subName" class="subName">
                                        {{ props.row.item.subName.toUpperCase() }}
                                    </div>
                                </div>
                                <FetchedTags
                                    :item="props.row.item"
                                    :max-length="6"
                                    class="fetched-tags"
                                />
                            </QTd>
``` <QTd class="description-cell"> <div class="row full-width justify-between"> {{ props.row.item.name }} <div v-if="props.row.item.subName" class="subName"> {{ props.row.item.subName.toUpperCase() }} </div> </div> <FetchedTags :item="props.row.item" :max-length="6" class="fetched-tags" /> </QTd> ```
<span>
jon marked this conversation as resolved Outdated
alexm commented 2024-05-13 05:51:38 +00:00
Outdated
Review

Creo que igual fusionando las dos columnas en una y la parte de fetched-tags(Cambialo por CamelCase) y la del subname las pones en un div con flex row igual se alinea mejor

Creo que igual fusionando las dos columnas en una y la parte de fetched-tags(Cambialo por CamelCase) y la del subname las pones en un div con flex row igual se alinea mejor
{{ props.row.item.name }}
</span>
<fetched-tags
class="fetched-tags"
:item="props.row.item"
:max-length="5"
></fetched-tags>
</QTd>
<QTd>
<span v-if="props.row.item.subName" class="subName">
{{ props.row.item.subName.toUpperCase() }}
</span>
<div class="fetched-tags">
<FetchedTags
:item="props.row.item"
:max-length="5"
></FetchedTags>
</div>
</QTd>
<QTd>{{ props.row.price }} €</QTd>
<QTd>{{ props.row.discount }} %</QTd>
@ -466,7 +464,6 @@ async function changeState(value) {
padding: 1%;
}
}
.q-table {
tr,
th,
@ -475,17 +472,22 @@ async function changeState(value) {
}
}
.tr-header {
color: var(--vn-label-color);
.subName {
margin-left: 10%;
}
.tr-header,
.subName {
color: var(--vn-label-color);
margin-left: -40%;
}
.description-cell {
jon marked this conversation as resolved Outdated
alexm commented 2024-05-15 06:31:29 +00:00
Outdated
Review

.description-cell {
width: 25%;
}
.fetched-tags {
max-width: 70%;
}

.description-cell { width: 25%; } .fetched-tags { max-width: 70%; }
width: 30%;
}
jon marked this conversation as resolved Outdated
alexm commented 2024-05-13 05:49:36 +00:00
Outdated
Review

Poner márgenes negativos lo veo raro

Poner márgenes negativos lo veo raro
.fetched-tags {
width: 70%;
margin-left: 19%;
display: flex;
flex-wrap: wrap;
alexm commented 2024-05-16 06:05:41 +00:00
Outdated
Review

Esta creo que ya no hace falta, aparte calc(100% / 2) es lo mismo que poner 50%

Esta creo que ya no hace falta, aparte calc(100% / 2) es lo mismo que poner 50%
margin-left: 10%;
}
jon marked this conversation as resolved Outdated
alexm commented 2024-05-13 05:50:07 +00:00
Outdated
Review

Creo que lo que quieres es centrar el contenido,. buscaria otra forma de hacerlo, igual con flex se puede

Creo que lo que quieres es centrar el contenido,. buscaria otra forma de hacerlo, igual con flex se puede
.fetched-tags > * {
max-width: calc(100% / 2);
}
</style>