verdnatura/salix-front
verdnatura
/
salix-front
2
3
Fork 1
Code Issues Pull Requests 89 Releases Wiki Activity

refactor: refs #7361 ticket/summary like salix #368

Merged
jon merged 14 commits from 7361-TicketSummaryRefactor into dev 2024-05-20 05:09:12 +00:00
Conversation 1 Commits 14 Files Changed 1 +11 -14
1 changed files with 11 additions and 14 deletions
Showing only changes of commit ccaf993841 - Show all commits
src/pages/Ticket/Card
TicketSummary.vue

25
src/pages/Ticket/Card/TicketSummary.vue
View File

@ -374,18 +374,17 @@ async function changeState(value) {
<QTd>{{ props.row.available }}</QTd>
<QTd>{{ props.row.quantity }}</QTd>
<QTd class="description-cell">
jon marked this conversation as resolved
alexm commented 2024-05-15 06:31:09 +00:00
Review 
                            <QTd class="description-cell">
                                <div class="row full-width justify-between">
                                    {{ props.row.item.name }}
                                    <div v-if="props.row.item.subName" class="subName">
                                        {{ props.row.item.subName.toUpperCase() }}
                                    </div>
                                </div>
                                <FetchedTags
                                    :item="props.row.item"
                                    :max-length="6"
                                    class="fetched-tags"
                                />
                            </QTd>
``` <QTd class="description-cell"> <div class="row full-width justify-between"> {{ props.row.item.name }} <div v-if="props.row.item.subName" class="subName"> {{ props.row.item.subName.toUpperCase() }} </div> </div> <FetchedTags :item="props.row.item" :max-length="6" class="fetched-tags" /> </QTd> ```
<span>
<div class="row full-width justify-between">
jon marked this conversation as resolved Outdated
alexm commented 2024-05-13 05:51:38 +00:00
Outdated
Review

Creo que igual fusionando las dos columnas en una y la parte de fetched-tags(Cambialo por CamelCase) y la del subname las pones en un div con flex row igual se alinea mejor

Creo que igual fusionando las dos columnas en una y la parte de fetched-tags(Cambialo por CamelCase) y la del subname las pones en un div con flex row igual se alinea mejor
{{ props.row.item.name }}
</span>
<span v-if="props.row.item.subName" class="subName">
{{ props.row.item.subName.toUpperCase() }}
</span>
<div class="fetched-tags">
<FetchedTags
:item="props.row.item"
:max-length="5"
></FetchedTags>
<div v-if="props.row.item.subName" class="subName">
{{ props.row.item.subName.toUpperCase() }}
</div>
</div>
<FetchedTags
class="fetched-tags"
:item="props.row.item"
:max-length="5"
></FetchedTags>
</QTd>
<QTd>{{ props.row.price }} €</QTd>
<QTd>{{ props.row.discount }} %</QTd>
@ -480,12 +479,10 @@ async function changeState(value) {
color: var(--vn-label-color);
}
.description-cell {
width: 30%;
width: 25%;
jon marked this conversation as resolved Outdated
alexm commented 2024-05-15 06:31:29 +00:00
Outdated
Review

.description-cell {
width: 25%;
}
.fetched-tags {
max-width: 70%;
}

.description-cell { width: 25%; } .fetched-tags { max-width: 70%; }
}
.fetched-tags {
jon marked this conversation as resolved Outdated
alexm commented 2024-05-13 05:49:36 +00:00
Outdated
Review

Poner márgenes negativos lo veo raro

Poner márgenes negativos lo veo raro
display: flex;
flex-wrap: wrap;
margin-left: 10%;
max-width: 70%;
}
.fetched-tags > * {
alexm commented 2024-05-16 06:05:41 +00:00
Outdated
Review

Esta creo que ya no hace falta, aparte calc(100% / 2) es lo mismo que poner 50%

Esta creo que ya no hace falta, aparte calc(100% / 2) es lo mismo que poner 50%
max-width: calc(100% / 2);