verdnatura/salix-front
verdnatura
/
salix-front
1
2
Fork 1
Code Issues Pull Requests 57 Releases Wiki Activity

Warmfix: packaging type field showing repetitive values #856

Merged
jon merged 3 commits from Fix-CustomerSummaryTable into test 2024-10-25 08:02:25 +00:00
Conversation 0 Commits 3 Files Changed 1 +15 -7
jon commented 2024-10-23 07:18:17 +00:00
Member
Copy Link

PR realizada para solucionar CAU https://cau.verdnatura.es/scp/tickets.php?number=162911

PR realizada para solucionar CAU https://cau.verdnatura.es/scp/tickets.php?number=162911
jon added 1 commit 2024-10-23 07:18:18 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
4bde0dffa7 fix: fixed item packaging type field showing repetitive values
jon requested review from alexm 2024-10-23 07:20:27 +00:00
alexm reviewed 2024-10-25 07:05:34 +00:00
alexm requested changes 2024-10-25 07:05:50 +00:00
Dismissed
src/pages/Customer/components/CustomerSummaryTable.vue Outdated
@ -159,2 +155,3 @@
if (!ticketSales || ticketSales.length === 0) return '-';
return dashIfEmpty(packagingType);
const packagingTypes = ticketSales
alexm commented 2024-10-25 07:05:48 +00:00
Member
Copy Link

Com sols hi ha H i V. igual tiraria mes per un .some

algo com:
const packagingTypes = []
if(ticketSales.some(sale => sale.item.itemPackingTypeFk == 'H')) packagingTypes.push('H')
if(ticketSales.some(sale => sale.item.itemPackingTypeFk == 'V')) packagingTypes.push('V')

Com sols hi ha H i V. igual tiraria mes per un .some algo com: const packagingTypes = [] if(ticketSales.some(sale => sale.item.itemPackingTypeFk == 'H')) packagingTypes.push('H') if(ticketSales.some(sale => sale.item.itemPackingTypeFk == 'V')) packagingTypes.push('V')
jon added 1 commit 2024-10-25 07:41:38 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
1daa8be635 perf: optimize get packing type function
jon requested review from alexm 2024-10-25 07:42:19 +00:00
alexm approved these changes 2024-10-25 07:53:13 +00:00
jon added 1 commit 2024-10-25 08:01:30 +00:00
gitea/salix-front/pipeline/pr-test This commit looks good Details
139744d90b Merge branch 'test' into Fix-CustomerSummaryTable
jon merged commit 88fe60e296 into test 2024-10-25 08:02:25 +00:00
jon deleted branch Fix-CustomerSummaryTable 2024-10-25 08:02:25 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexm
Labels
Clear labels   
bug

Something is not working

  
CR / Tests passed

CR / Tests passed

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
invalid

Something is wrong

  
Missing Tests

Missing Tests

  
wontfix

This won't be fixed

No Label
bug
CR / Tests passed
duplicate
enhancement
invalid
Missing Tests
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#856
No description provided.
Delete Branch "Fix-CustomerSummaryTable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?