Warmfix: packaging type field showing repetitive values #856

Merged
jon merged 3 commits from Fix-CustomerSummaryTable into test 2024-10-25 08:02:25 +00:00
1 changed files with 15 additions and 7 deletions

View File

@ -101,7 +101,7 @@ const columns = computed(() => [
align: 'left',
name: 'itemPackingTypeFk',
label: t('ticketSale.packaging'),
format: (row) => getItemPackagingType(row),
format: (row) => getItemPackagingType(row.ticketSales),
},
{
align: 'right',
@ -151,13 +151,21 @@ const setShippedColor = (date) => {
if (difference < 0) return 'success';
};
const getItemPackagingType = (row) => {
const packagingType = row?.ticketSales
.map((sale) => sale.item?.itemPackingTypeFk || '-')
.filter((value) => value !== '-')
.join(', ');
const getItemPackagingType = (ticketSales) => {
if (!ticketSales?.length) return '-';
return dashIfEmpty(packagingType);
const packagingTypes = ticketSales.reduce((types, sale) => {
Outdated
Review

Com sols hi ha H i V. igual tiraria mes per un .some

algo com:
const packagingTypes = []
if(ticketSales.some(sale => sale.item.itemPackingTypeFk == 'H')) packagingTypes.push('H')
if(ticketSales.some(sale => sale.item.itemPackingTypeFk == 'V')) packagingTypes.push('V')

Com sols hi ha H i V. igual tiraria mes per un .some algo com: const packagingTypes = [] if(ticketSales.some(sale => sale.item.itemPackingTypeFk == 'H')) packagingTypes.push('H') if(ticketSales.some(sale => sale.item.itemPackingTypeFk == 'V')) packagingTypes.push('V')
const { itemPackingTypeFk } = sale.item;
if (
!types.includes(itemPackingTypeFk) &&
(itemPackingTypeFk === 'H' || itemPackingTypeFk === 'V')
) {
types.push(itemPackingTypeFk);
}
return types;
}, []);
return dashIfEmpty(packagingTypes.join(', ') || '-');
};
</script>