#7134 SupplierBalance #905

Closed
jsegarra wants to merge 0 commits from 7134-supplierBalance into dev
Member
https://gitea.verdnatura.es/verdnatura/salix/pulls/3173
jsegarra added 3 commits 2024-11-11 10:55:33 +00:00
jsegarra added 2 commits 2024-11-11 13:47:04 +00:00
jsegarra added 2 commits 2024-11-20 10:21:34 +00:00
jsegarra added 2 commits 2024-11-20 13:28:51 +00:00
jsegarra added 1 commit 2024-11-21 11:44:43 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
e948253bea
feat: refs #7134 vnTable setTableFooter
jsegarra added 2 commits 2024-12-02 09:24:44 +00:00
jsegarra added 7 commits 2024-12-27 10:57:34 +00:00
jsegarra added 4 commits 2024-12-27 12:26:54 +00:00
jsegarra added 1 commit 2024-12-27 12:57:18 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
0b767ff812
feat: refs #7134 order
jsegarra requested review from jgallego 2024-12-27 12:57:47 +00:00
jsegarra changed title from WIP: #7134 SupplierBalance to #7134 SupplierBalance 2024-12-27 12:57:48 +00:00
jgallego requested changes 2024-12-30 06:32:13 +00:00
Dismissed
@ -13,3 +13,3 @@
videosFolder: 'test/cypress/videos',
video: false,
specPattern: 'test/cypress/integration/**/*.spec.js',
specPattern: 'test/cypress/integration/invoiceOut/*.spec.js',
Owner

esto imagino que se ha colado

esto imagino que se ha colado
jsegarra marked this conversation as resolved
@ -83,0 +83,4 @@
@keydown="handleKeydown"
ref="vnInputRef"
v-model="internalValue"
:maxlength="10"
Owner

creo que puedes poner tb minlength

creo que puedes poner tb minlength
@ -0,0 +10,4 @@
params: { filter: JSON.stringify(filter) },
});
}
export async function getSupplierRisk(_filter) {
Owner

si hacen lo mismo las dos, porque no creas solo una? o es que la de bajo deberia llamar a otro back

si hacen lo mismo las dos, porque no creas solo una? o es que la de bajo deberia llamar a otro back
jsegarra marked this conversation as resolved
@ -0,0 +56,4 @@
<QItem v-bind="scope.itemProps">
<QItemSection>
<QItemLabel>
{{ scope.opt.id }}:&ensp;{{ scope.opt.bank }}
Owner

porque no pones directamente el espacio?

porque no pones directamente el espacio?
jsegarra marked this conversation as resolved
@ -0,0 +74,4 @@
};
const initialData = reactive({
received: '2001-01-01T11:00:00.000Z',
Owner

estos valores que son?

estos valores que son?
@ -0,0 +14,4 @@
cy.get('.q-pa-md > .q-drawer-container > .q-drawer > .q-drawer__content').click();
cy.get('.q-pa-md > #subToolbar').click();
cy.get('.text-bold').should('have.text', 'Total by company');
// cy.get('.q-tr > :nth-child(4) > span').should('have.text', '1181.87');
Owner

los comentarios?

los comentarios?
jsegarra added 2 commits 2025-01-03 15:28:59 +00:00
jsegarra added 3 commits 2025-01-13 18:20:15 +00:00
jsegarra added 1 commit 2025-01-13 21:33:14 +00:00
jsegarra added 1 commit 2025-01-13 21:52:42 +00:00
jsegarra added 1 commit 2025-01-13 21:56:01 +00:00
jsegarra added 1 commit 2025-01-13 21:58:41 +00:00
jsegarra added 2 commits 2025-01-13 22:04:02 +00:00
jsegarra added 1 commit 2025-01-13 22:05:21 +00:00
jsegarra added 1 commit 2025-01-13 22:05:40 +00:00
jsegarra requested review from jgallego 2025-01-13 22:05:42 +00:00
jsegarra added 2 commits 2025-01-13 22:13:13 +00:00
jgallego requested changes 2025-01-14 06:27:24 +00:00
Dismissed
@ -0,0 +29,4 @@
supplierId: route.params.id,
companyId: companyId.value ?? companyUser.value,
isBooked: false,
currencyFk: 1, // EUR
Owner

este uno podemo hacer que sea el back el que lo reciba por defecto? para no dejar numeros. De todas formas el back casi seguro lo tendrá

este uno podemo hacer que sea el back el que lo reciba por defecto? para no dejar numeros. De todas formas el back casi seguro lo tendrá
Author
Member

Lo he resuelto haciendo un fetchData

Lo he resuelto haciendo un fetchData
jsegarra marked this conversation as resolved
@ -0,0 +59,4 @@
align: 'left',
name: 'invoiceEuros',
label: t('Debit'),
format: ({ invoiceEuros }) => invoiceEuros && toCurrency(invoiceEuros),
Owner

duda
format: ({ invoiceEuros }) => toCurrency(invoiceEuros ?? 0)
esto serviria?

duda `format: ({ invoiceEuros }) => toCurrency(invoiceEuros ?? 0)` esto serviria?
jsegarra marked this conversation as resolved
@ -0,0 +150,4 @@
<template #column-footer-invoiceEuros>
<span>
{{ toCurrency(round(tableRef.footer.invoiceEuros)) }}
Owner

el redondeo lo hace el toCurrency creo que tiene un parametro para los decimales

el redondeo lo hace el toCurrency creo que tiene un parametro para los decimales
Author
Member

Pero por defecto es 2
toCurrency =>(value, symbol = 'EUR', fractionSize = 2)

Pero por defecto es 2 toCurrency =>(value, symbol = 'EUR', fractionSize = 2)
jsegarra marked this conversation as resolved
jsegarra added 1 commit 2025-01-21 13:53:52 +00:00
jsegarra added 1 commit 2025-01-21 13:56:11 +00:00
jsegarra added 1 commit 2025-01-21 13:56:25 +00:00
jsegarra requested review from jgallego 2025-01-21 13:56:39 +00:00
jgallego approved these changes 2025-01-21 16:26:00 +00:00
Dismissed
jsegarra added 3 commits 2025-01-21 22:08:53 +00:00
jsegarra dismissed jgallego’s review 2025-01-21 22:08:53 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra added 1 commit 2025-01-21 22:15:33 +00:00
jsegarra requested review from jgallego 2025-01-21 22:20:11 +00:00
jgallego approved these changes 2025-01-22 06:23:11 +00:00
Dismissed
@ -0,0 +118,4 @@
</script>
<template>
<QDrawer side="right" :width="265" v-model="stateStore.rightDrawer">
Owner

de momento seguimos con el 265 pero ticketBasicData ya tiene witdth 265, hay que ir mirando de hacerlo en una clase css a nivel aplicacion o un como los iconos md, xs, como creas mas conveniente.

de momento seguimos con el 265 **pero** ticketBasicData ya tiene witdth 265, hay que ir mirando de hacerlo en una clase css a nivel aplicacion o un como los iconos md, xs, como creas mas conveniente.
Author
Member

Se podría ver de hacer en src7boot la definición de la linea
setDefault(QDrawer, width,256)
Esto se lo podríamos dar a tubau-pau pero sin decirle esto

Se podría ver de hacer en src7boot la definición de la linea setDefault(QDrawer, width,256) Esto se lo podríamos dar a tubau-pau pero sin decirle esto
jsegarra added 1 commit 2025-01-28 07:48:13 +00:00
jsegarra added 1 commit 2025-01-28 22:43:26 +00:00
Author
Member

@jgallego Parece que se han roto los checks de jenkins

@jgallego Parece que se han roto los checks de jenkins
jgallego dismissed jgallego’s review 2025-01-29 06:09:51 +00:00
jgallego dismissed jgallego’s review 2025-01-29 06:09:54 +00:00
jgallego approved these changes 2025-01-29 06:10:11 +00:00
Dismissed
jgallego requested review from jgallego 2025-01-29 06:10:20 +00:00
jgallego approved these changes 2025-01-29 06:10:24 +00:00
jsegarra added 2 commits 2025-01-29 08:54:21 +00:00
jsegarra added 1 commit 2025-01-29 08:55:46 +00:00
gitea/salix-front/pipeline/pr-dev This commit looks good Details
2fb7db051c
Merge branch 'dev' into 7134-supplierBalance
jsegarra closed this pull request 2025-01-29 08:56:28 +00:00
jsegarra reopened this pull request 2025-01-29 08:56:31 +00:00
jsegarra closed this pull request 2025-01-29 08:57:10 +00:00
All checks were successful
gitea/salix-front/pipeline/pr-dev This commit looks good
Required
Details

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix-front#905
No description provided.