Merge branch 'dev' into 8057-geoFk

Reviewed-on: #3170
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>

back/methods/collection/getTickets.js

@@ -73,7 +73,7 @@ module.exports = Self => {
                     JOIN item i ON i.id = s.itemFk
                     JOIN itemShelvingSale iss ON iss.saleFk = s.id
                     LEFT JOIN itemShelving ish ON ish.id = iss.itemShelvingFk
-                    LEFT JOIN shelving sh ON sh.code = ish.shelvingFk
+                    LEFT JOIN shelving sh ON sh.id = ish.shelvingFk
                     LEFT JOIN parking p ON p.id = sh.parkingFk
                     LEFT JOIN itemColor ic ON ic.itemFk = s.itemFk
                     LEFT JOIN origin o ON o.id = i.originFk
@@ -114,7 +114,7 @@ module.exports = Self => {
                 JOIN item i ON i.id = s.itemFk
                 JOIN itemShelvingSale iss ON iss.saleFk = s.id
                 LEFT JOIN itemShelving ish ON ish.id = iss.itemShelvingFk
-                LEFT JOIN shelving sh ON sh.code = ish.shelvingFk
+                LEFT JOIN shelving sh ON sh.id = ish.shelvingFk
                 LEFT JOIN parking p ON p.id = sh.parkingFk
                 LEFT JOIN itemColor ic ON ic.itemFk = s.itemFk
                 LEFT JOIN origin o ON o.id = i.originFk

back/methods/mrw-config/cancelShipment.js

@@ -39,6 +39,9 @@ module.exports = Self => {
         const xmlString = response.data;
         const parser = new DOMParser();
         const xmlDoc = parser.parseFromString(xmlString, 'text/xml');
+
+        await Self.rawSql('CALL util.debugAdd(?,?);', ['cancelShipment', xmlDoc]);
+
         const result = xmlDoc.getElementsByTagName('Mensaje')[0].textContent;
         return result.toLowerCase().includes('se ha cancelado correctamente');
     };

back/models/say-simple-config.json

@@ -13,6 +13,9 @@
         },
         "url": {
             "type": "string"
+        },
+        "defaultChannel": {
+            "type": "number"
         }
     },
     "acls": [

db/dump/.dump/data.sql

@@ -2084,7 +2084,7 @@ INSERT INTO `ACL` VALUES (756,'Route','findOne','READ','ALLOW','ROLE','employee'
 INSERT INTO `ACL` VALUES (757,'Route','getRoutesByWorker','READ','ALLOW','ROLE','employee',NULL);
 INSERT INTO `ACL` VALUES (758,'Route','canViewAllRoute','READ','ALLOW','ROLE','deliveryAssistant',NULL);
 INSERT INTO `ACL` VALUES (759,'Route','cmr','READ','ALLOW','ROLE','employee',NULL);
-INSERT INTO `ACL` VALUES (760,'Route','downloadCmrsZip','READ','ALLOW','ROLE','employee',NULL);
+INSERT INTO `ACL` VALUES (760,'Cmr','downloadZip','READ','ALLOW','ROLE','employee',NULL);
 INSERT INTO `ACL` VALUES (761,'Route','downloadZip','READ','ALLOW','ROLE','employee',NULL);
 INSERT INTO `ACL` VALUES (762,'Route','filter','READ','ALLOW','ROLE','employee',NULL);
 INSERT INTO `ACL` VALUES (763,'Route','getByWorker','READ','ALLOW','ROLE','employee',NULL);

db/dump/fixtures.before.sql

@@ -1254,9 +1254,9 @@ INSERT INTO `vn`.`saleComponent`(`saleFk`, `componentFk`, `value`)
 
 INSERT INTO `vn`.`itemShelving` (`itemFk`, `shelvingFk`, `visible`, `grouping`, `packing`,`buyFk`, `userFk`)
     VALUES
-        (2, 'GVC', 1, 1, 1, 2,1106),
-        (4, 'HEJ', 1, 1, 1, NULL,1106),
-        (1, 'UXN', 2, 12, 12, NULL,1106);
+        (2, 11, 1, 1, 1, 2,1106),
+        (4, 12, 1, 1, 1, NULL,1106),
+        (1, 13, 2, 12, 12, NULL,1106);
 
 INSERT INTO `vn`.`itemShelvingSale` (`itemShelvingFk`, `saleFk`, `quantity`, `created`, `userFk`)
     VALUES
@@ -3425,7 +3425,7 @@ INSERT INTO vn.buy
 INSERT INTO vn.itemShelving
 	SET id = 9931,
 		itemFk = 999993,
-		shelvingFk = 'NCC',
+		shelvingFk = 16,
 		visible = 10,
 		`grouping` = 5,
 		packing = 10;
@@ -3752,7 +3752,7 @@ INSERT vn.sale
 
 USE vn;
 DELETE ish.*  FROM vn.itemShelving ish
-		JOIN vn.shelving sh ON sh.code = ish.shelvingFk
+		JOIN vn.shelving sh ON sh.id = ish.shelvingFk
 		JOIN vn.parking p ON p.id = sh.parkingFk
 		JOIN vn.sector s ON s.id = p.sectorFk
 		JOIN vn.warehouse w ON w.id = s.warehouseFk
@@ -3761,22 +3761,22 @@ DELETE ish.*  FROM vn.itemShelving ish
 INSERT INTO vn.itemShelving
 (itemFk, shelvingFk, visible, created, `grouping`, packing, packagingFk, userFk, isChecked)
 VALUES
-	(999991, 'NAA', 8, '2023-09-20', 1, 20, NULL, 103, NULL),
-	(999998, 'NAA', 80, '2023-09-20', 10, 30, NULL, 103, NULL),
-	(1000001, 'NAA', 6, '2023-09-20', 3, 50, NULL, 103, NULL),
-	(1000000, 'NBB', 50, '2023-09-18', 25, 500, NULL, 103, NULL),
-	(999993, 'NBB', 25, '2023-09-18', NULL, 10, NULL, 103, NULL),
-	(999999, 'NBB', 30, '2023-09-18', 10, 500, NULL, 103, NULL),
-	(999993, 'NCC', 25, '2023-09-20', 5, 10, NULL, 103, NULL),
-	(999997, 'NCC', 10, '2023-09-20', NULL, 100, NULL, 103, NULL),
-	(999999, 'NCC', 40, '2023-09-20', 10, 500, NULL, 103, NULL),
-	(999995, 'NDD', 10, '2023-09-19', NULL, 20, NULL, 103, NULL),
-	(999994, 'NDD', 48, '2023-09-19', 4, 20, NULL, 103, NULL),
-	(1000001, 'NEE', 6, '2023-09-21', 3, 50, NULL, 103, NULL),
-	(999992, 'NEE', 50, '2023-09-21', NULL, 1, NULL, 103, NULL),
-	(1000000, 'NEE', 25, '2023-09-21', 25, 500, NULL, 103, NULL),
-	(999996, 'PAA', 5, '2023-09-27', 1, 5, NULL, 103, NULL),
-	(999997, 'PCC', 10, '2023-09-27', 5, 100, NULL, 103, NULL);
+	(999991, 14, 8, '2023-09-20', 1, 20, NULL, 103, NULL),
+	(999998, 14, 80, '2023-09-20', 10, 30, NULL, 103, NULL),
+	(1000001, 14, 6, '2023-09-20', 3, 50, NULL, 103, NULL),
+	(1000000, 15, 50, '2023-09-18', 25, 500, NULL, 103, NULL),
+	(999993, 15, 25, '2023-09-18', NULL, 10, NULL, 103, NULL),
+	(999999, 15, 30, '2023-09-18', 10, 500, NULL, 103, NULL),
+	(999993, 16, 25, '2023-09-20', 5, 10, NULL, 103, NULL),
+	(999997, 16, 10, '2023-09-20', NULL, 100, NULL, 103, NULL),
+	(999999, 16, 40, '2023-09-20', 10, 500, NULL, 103, NULL),
+	(999995, 17, 10, '2023-09-19', NULL, 20, NULL, 103, NULL),
+	(999994, 17, 48, '2023-09-19', 4, 20, NULL, 103, NULL),
+	(1000001, 18, 6, '2023-09-21', 3, 50, NULL, 103, NULL),
+	(999992, 18, 50, '2023-09-21', NULL, 1, NULL, 103, NULL),
+	(1000000, 18, 25, '2023-09-21', 25, 500, NULL, 103, NULL),
+	(999996, 19, 5, '2023-09-27', 1, 5, NULL, 103, NULL),
+	(999997, 21, 10, '2023-09-27', 5, 100, NULL, 103, NULL);
 
 -- Previous for Bolas de madera
 INSERT IGNORE INTO vn.sectorCollection
@@ -4023,9 +4023,8 @@ INSERT INTO srt.buffer (id, x, y, `size`, `length`, stateFk, typeFk, isActive, c
 
 
 INSERT IGNORE INTO vn.saySimpleCountry (countryFk, channel) 
-	VALUES (19, 1169),
-			(8, 1183),
-            (NULL, 1320);
+	VALUES (19, '1169'),
+			(8, '1183');
 
-INSERT IGNORE INTO vn.saySimpleConfig (url) 
-	VALUES ('saysimle-url-mock');
+INSERT IGNORE INTO vn.saySimpleConfig (url, defaultChannel) 
+	VALUES ('saysimle-url-mock', 1320);

db/routines/account/views/myUser.sql

@@ -7,8 +7,7 @@ AS SELECT `u`.`id` AS `id`,
 	`u`.`email` AS `email`,
 	`u`.`nickname` AS `nickname`,
 	`u`.`lang` AS `lang`,
-	`u`.`role` AS `role`,
-	`u`.`recoverPass` AS `recoverPass`
+	`u`.`role` AS `role`
 FROM `account`.`user` `u`
 WHERE `u`.`name` = `myUser_getName`()
 WITH CASCADED CHECK OPTION

db/routines/bs/procedures/inventoryDiscrepancyDetail_replace.sql

@@ -32,7 +32,7 @@ BEGIN
 		CREATE OR REPLACE TEMPORARY TABLE tVisible
 			SELECT itemFk, SUM(visible) totalVisible
 				FROM vn.itemShelving ish
-					JOIN vn.shelving sh ON sh.code = ish.shelvingFk
+					JOIN vn.shelving sh ON sh.id = ish.shelvingFk
 					JOIN vn.parking p ON p.id = sh.parkingFk
 					JOIN vn.sector sc ON sc.id = p.sectorFk
 					WHERE sc.warehouseFk = vWarehouseFk

db/routines/vn/functions/hasItemsInSector.sql

@@ -9,7 +9,7 @@ BEGIN
     SELECT count(*) INTO vItemCount
 		FROM vn.sale s 
 			JOIN vn.itemShelving ish ON ish.itemFk = s.itemFk
-            JOIN vn.shelving sh ON sh.code = ish.shelvingFk
+            JOIN vn.shelving sh ON sh.id = ish.shelvingFk
             JOIN vn.parking p ON p.id = sh.parkingFk
 		WHERE s.ticketFk = vTicketFk
 			AND p.sectorFk = vSectorFk;

db/routines/vn/functions/itemsInSector_get.sql

@@ -10,7 +10,7 @@ BEGIN
     SELECT count(*) INTO vItemCount
 		FROM vn.sale s 
 			JOIN vn.itemShelving ish ON ish.itemFk = s.itemFk
-            JOIN vn.shelving sh ON sh.code = ish.shelvingFk
+            JOIN vn.shelving sh ON sh.id = ish.shelvingFk
             JOIN vn.parking p ON p.id = sh.parkingFk
 		WHERE s.ticketFk = vTicketFk
 			AND p.sectorFk = vSectorFk;

db/routines/vn/procedures/collectionPlacement_get.sql

@@ -83,7 +83,7 @@ BEGIN
 								AND s.semaphore = 1
 							GROUP BY st.saleFk) st ON st.saleFk = ts.saleFk
 				JOIN itemShelving ish ON ish.itemFk = ts.itemFk
-				JOIN shelving sh ON sh.code = ish.shelvingFk
+				JOIN shelving sh ON sh.id = ish.shelvingFk
 				JOIN parking p ON p.id = sh.parkingFk
 				JOIN sector sc ON sc.id = p.sectorFk
 				JOIN sectorType st ON st.id = sc.typeFk

db/routines/vn/procedures/entry_splitByShelving.sql

@@ -1,10 +1,15 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`entry_splitByShelving`(vShelvingFk VARCHAR(3), vFromEntryFk INT, vToEntryFk INT)
+CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`entry_splitByShelving`(
+	vShelvingCode VARCHAR(10),
+	vFromEntryFk INT,
+	vToEntryFk INT
+)
 BEGIN
 /**
- * Divide las compras entre dos entradas de acuerdo con lo ubicado en una matr<EFBFBD>cula
+ * Divide las compras entre dos entradas de
+ * acuerdo con lo ubicado en una matricula.
  * 
- * @param vShelvingFk Identificador de vn.shelving
+ * @param vShelvingCode Código de vn.shelving
  * @param vFromEntryFk Entrada origen
  * @param vToEntryFk Entrada destino
  */
@@ -14,7 +19,7 @@ BEGIN
 	DECLARE vDone BOOLEAN DEFAULT FALSE;
 
 	DECLARE cur CURSOR FOR
-		SELECT 	bb.id buyFk,
+		SELECT bb.id buyFk,
 				LEAST(bb.stickers, FLOOR(ish.visible / ish.packing)) ishStickers,
 				bb.stickers buyStickers
 			FROM itemShelving ish
@@ -23,7 +28,7 @@ BEGIN
 						WHERE b.entryFk = vFromEntryFk
 						ORDER BY b.stickers DESC
 						LIMIT 10000000000000000000) bb ON bb.itemFk = ish.itemFk
-			WHERE ish.shelvingFk = vShelvingFk COLLATE utf8_general_ci
+			WHERE ish.shelvingFk = vShelvingCode COLLATE utf8_general_ci
 				AND NOT ish.isSplit
 			GROUP BY ish.id;
 			
@@ -107,9 +112,10 @@ BEGIN
 			UPDATE buy SET printedStickers = vIshStickers WHERE id = LAST_INSERT_ID();
 		END IF;
 
-		UPDATE itemShelving
-			SET isSplit = TRUE
-				WHERE shelvingFk = vShelvingFk COLLATE utf8_general_ci;
+		UPDATE itemShelving ish
+				JOIN shelving sh ON sh.id = ish.shelvingFk
+			SET ish.isSplit = TRUE
+			WHERE sh.code = vShelvingCode COLLATE utf8_general_ci;
 	END LOOP;
 	CLOSE cur;
 END$$

db/routines/vn/procedures/itemPlacementSupplyAiming.sql

@@ -1,5 +1,9 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemPlacementSupplyAiming`(vShelvingFk VARCHAR(10), quantity INT, vItemFk INT)
+CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemPlacementSupplyAiming`(
+    vShelvingCode VARCHAR(10),
+    vQuantity INT,
+    vItemFk INT
+)
 BEGIN
 
 	SELECT 	ish.itemFk,
@@ -9,21 +13,21 @@ BEGIN
 			ish.itemShelvingFk,
             ish.shelving,
             ish.stock,
-            LEAST(ish.stock,quantity) as total,
+            LEAST(ish.stock,vQuantity) total,
             CONCAT(
-					CAST(FLOOR(LEAST(ish.stock,quantity) / ish.packing) AS DECIMAL(10,0)),
+					CAST(FLOOR(LEAST(ish.stock, vQuantity) / ish.packing) AS DECIMAL(10,0)),
                     ' x ',
                     ish.packing,
                     IF	(	
-						LEAST(ish.stock,quantity) MOD ish.packing,
-						CONCAT(' + ',CAST(LEAST(ish.stock,quantity) MOD ish.packing AS DECIMAL(10,0))),
+						LEAST(ish.stock, vQuantity) MOD ish.packing,
+						CONCAT(' + ',CAST(LEAST(ish.stock, vQuantity) MOD ish.packing AS DECIMAL(10,0))),
                         ''
                         ),
                     ' = ',
-                    LEAST(ish.stock,quantity)
-				   ) as proposal
-		FROM vn.itemShelvingPlacementSupplyStock ish
-        WHERE ish.shelving = vShelvingFk COLLATE utf8_general_ci
+                    LEAST(ish.stock, vQuantity)
+				   ) proposal
+		FROM itemShelvingPlacementSupplyStock ish
+        WHERE ish.shelving = vShelvingCode COLLATE utf8_general_ci
 			AND ish.itemFk = vItemFk;
 
 END$$

db/routines/vn/procedures/itemPlacementSupplyGetOrder.sql

@@ -1,5 +1,7 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemPlacementSupplyGetOrder`(vSector INT )
+CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemPlacementSupplyGetOrder`(
+    vSectorFk INT
+)
 BEGIN
 
 	DECLARE vId INT;
@@ -7,31 +9,35 @@ BEGIN
     DECLARE vNextParkingFk INT;
         
 	SELECT sh.parkingFk INTO vLastParkingFk
-		FROM vn.itemShelvingPlacementSupply isps
-			JOIN vn.itemShelving ish ON ish.id = isps.itemShelvingFk
-            JOIN vn.shelving sh ON sh.code = ish.shelvingFk
+		FROM itemShelvingPlacementSupply isps
+			JOIN itemShelving ish ON ish.id = isps.itemShelvingFk
+            JOIN shelving sh ON sh.id = ish.shelvingFk
         WHERE isps.userFk = getUser()
         ORDER BY isps.created DESC
         LIMIT 1;
     
-    SET vNextParkingFk = vn.itemShelvingPlacementSupply_ClosestGet(vLastParkingFk);
+    SET vNextParkingFk = itemShelvingPlacementSupply_ClosestGet(vLastParkingFk);
     
 	SELECT ipsl.id INTO vId
-		FROM vn.itemPlacementSupplyList ipsl
-			JOIN vn.itemShelvingPlacementSupplyStock ispss ON ispss.itemFk = ipsl.itemFk
+		FROM itemPlacementSupplyList ipsl
+			JOIN itemShelvingPlacementSupplyStock ispss ON ispss.itemFk = ipsl.itemFk
 		WHERE ipsl.saldo > 0
 			AND (ipsl.repoUserFk is NULL OR ipsl.repoUserFk = getUser())
-            AND ipsl.sectorFk = vSector
-         ORDER BY  ipsl.repoUserFk DESC, ipsl.priority DESC, (ispss.parkingFk = vNextParkingFk) DESC, ispss.parking DESC, ipsl.created
+            AND ipsl.sectorFk = vSectorFk
+         ORDER BY ipsl.repoUserFk DESC,
+            ipsl.priority DESC,
+            (ispss.parkingFk = vNextParkingFk) DESC,
+            ispss.parking DESC,
+            ipsl.created
         LIMIT 1;
         
-    UPDATE vn.itemPlacementSupply
+    UPDATE itemPlacementSupply
 		SET repoUserFk = getUser()
         WHERE id = vId;
         
-    SELECT * FROM vn.itemPlacementSupplyList 
+    SELECT * FROM itemPlacementSupplyList 
 		WHERE id = vId 
-		AND sectorFk = vSector;
+		    AND sectorFk = vSectorFk;
 
 END$$
 DELIMITER ;

db/routines/vn/procedures/itemPlacementSupplyStockGetTargetList.sql

@@ -1,5 +1,8 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemPlacementSupplyStockGetTargetList`(vItemFk INT,vSectorFk INT)
+CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemPlacementSupplyStockGetTargetList`(
+	vItemFk INT,
+	vSectorFk INT
+)
 BEGIN
 /**
  * Devuelve la lista de ubicaciones para itemFk en ese sector. Se utiliza en la preparación previa.
@@ -13,11 +16,11 @@ BEGIN
 			SUM(ish.visible) stockTotal,
 			ish.created,
 			p.pickingOrder
-		FROM vn.itemShelving ish
-			JOIN vn.shelving sh ON sh.code = ish.shelvingFk
-			JOIN vn.parking p ON p.id = sh.parkingFk
-			JOIN vn.sector sc ON sc.id = p.sectorFk
-			JOIN vn.warehouse w ON w.id = sc.warehouseFk
+		FROM itemShelving ish
+			JOIN shelving sh ON sh.id = ish.shelvingFk
+			JOIN parking p ON p.id = sh.parkingFk
+			JOIN sector sc ON sc.id = p.sectorFk
+			JOIN warehouse w ON w.id = sc.warehouseFk
 		WHERE ish.visible > 0
 			AND ish.itemFk = vItemFk
 		GROUP BY ish.id

db/routines/vn/procedures/itemShelvingLog_get.sql

@@ -1,14 +1,14 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelvingLog_get`(vShelvingFk VARCHAR(10) )
+CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelvingLog_get`(
+	vShelvingCode VARCHAR(10)
+)
 BEGIN
-	
 /**
  * Devuelve el log de los item en cada carro
  *
- * @param vShelvingFk Matrícula del carro 
+ * @param vShelvingCode Matrícula del carro 
  * 
  */
-	
 	SELECT isl.itemShelvingFk, 
 			isl.created, 
 			isl.accion, 
@@ -28,8 +28,9 @@ BEGIN
 	FROM item 
 		JOIN itemShelvingLog isl ON item.id = isl.itemFk 
 		JOIN worker ON isl.workerFk = worker.id
-	WHERE shelvingFk = vShelvingFk OR isl.itemFk = vShelvingFk
-		ORDER BY isl.created DESC;
-	
+		JOIN shelving sh ON sh.id = isl.shelvingFk
+	WHERE sh.code = vShelvingCode COLLATE utf8mb3_unicode_ci
+		OR isl.itemFk = vShelvingCode -- ?? Respeto porque ya estaba
+	ORDER BY isl.created DESC;
 END$$
 DELIMITER ;

db/routines/vn/procedures/itemShelvingMatch.sql

@@ -20,7 +20,7 @@ BEGIN
 		LEFT JOIN (
 					SELECT itemFk, sum(cast(visible / packing AS DECIMAL(10,0))) AS etiquetas 
 						FROM itemShelving ish
-							JOIN shelving sh ON sh.code = ish.shelvingFk
+							JOIN shelving sh ON sh.id = ish.shelvingFk
                             LEFT JOIN parking pk ON pk.id = sh.parkingFk
 						WHERE ish.created BETWEEN vFromTimed AND vToTimed
 						GROUP BY itemFk

db/routines/vn/procedures/itemShelvingSale_addBySale.sql

@@ -27,7 +27,7 @@ proc: BEGIN
 				ish.available
 			FROM sale s
 				JOIN itemShelving ish ON ish.itemFk = s.itemFk
-				JOIN shelving sh ON sh.code = ish.shelvingFk
+				JOIN shelving sh ON sh.id = ish.shelvingFk
 				JOIN parking p ON p.id = sh.parkingFk
 				JOIN sector sc ON sc.id = p.sectorFk
 				JOIN productionConfig pc
@@ -61,7 +61,7 @@ proc: BEGIN
 		FROM sale s
 			LEFT JOIN itemShelvingSale iss ON iss.saleFk = s.id
 			LEFT JOIN itemShelving ish ON ish.id = iss.itemShelvingFk
-			LEFT JOIN shelving sh ON sh.code = ish.shelvingFk
+			LEFT JOIN shelving sh ON sh.id = ish.shelvingFk
 			LEFT JOIN parking p ON p.id = sh.parkingFk
 		WHERE s.id = vSaleFk;
 		

db/routines/vn/procedures/itemShelving_add.sql

@@ -1,6 +1,6 @@
 DELIMITER $$
 CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_add`(
-	vShelvingFk VARCHAR(8),
+	vShelvingCode VARCHAR(10),
 	vBarcode VARCHAR(22),
 	vQuantity INT,
 	vPackagingFk VARCHAR(10),
@@ -12,7 +12,7 @@ BEGIN
 /**
  * Añade registro o lo actualiza si ya existe.
  *
- * @param vShelvingFk matrícula del carro
+ * @param vShelvingCode matrícula del carro
  * @param vBarcode el id del registro
  * @param vQuantity indica la cantidad del producto
  * @param vPackagingFk el packaging del producto en itemShelving, NULL para coger el de la ultima compra
@@ -23,10 +23,15 @@ BEGIN
  **/
 	DECLARE vItemFk INT;
 	DECLARE vBuyFk INT;
+	DECLARE vShelvingFk INT;
 
 	SELECT id INTO vBuyFk 
 		FROM buy WHERE id = vBarcode;
 
+	SELECT id INTO vShelvingFk
+		FROM shelving
+		WHERE code COLLATE utf8_unicode_ci = vShelvingCode;
+
 	SELECT barcodeToItem(vBarcode) INTO vItemFk;
 
 	IF vBuyFk IS NULL THEN
@@ -40,7 +45,7 @@ BEGIN
 	END IF;
 
 	IF (SELECT COUNT(*) FROM itemShelving
-			WHERE shelvingFk COLLATE utf8_unicode_ci  = vShelvingFk
+			WHERE shelvingFk = vShelvingFk
 				AND itemFk  = vItemFk
 				AND packing  = vPacking
 				AND buyFk = vBuyFk) THEN
@@ -48,7 +53,9 @@ BEGIN
 		UPDATE itemShelving
 			SET visible = visible + vQuantity,
 				available = available + vQuantity
-			WHERE shelvingFk COLLATE utf8_unicode_ci = vShelvingFk AND itemFk = vItemFk AND packing = vPacking;
+			WHERE shelvingFk = vShelvingFk
+				AND itemFk = vItemFk
+				AND packing = vPacking;
 
 	ELSE
 

db/routines/vn/procedures/itemShelving_addByClaim.sql

@@ -1,29 +1,38 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_addByClaim`(vClaimFk INT, vShelvingFk VARCHAR(3))
+CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_addByClaim`(
+	vClaimFk INT,
+	vShelvingCode VARCHAR(10)
+)
 BEGIN
 /**
  * Insert items of claim into itemShelving.
  *
  * @param vClaimFk The claim
- * @param vShelvingFk The shelving
+ * @param vShelvingCode The shelving code
  * @table tmp.buyUltimate
  */
 	DECLARE vWarehouseFk INT;
+	DECLARE vShelvingFk INT;
 
 	SELECT t.warehouseFk INTO vWarehouseFk
 		FROM claim c
 			JOIN ticket t ON t.id = c.ticketFk
 		WHERE c.id = vClaimFk;
 
+	SELECT id INTO vShelvingFk
+		FROM shelving
+		WHERE code COLLATE utf8_unicode_ci = vShelvingCode;
+
 	CALL buy_getUltimate(NULL, vWarehouseFk, util.VN_CURDATE());
 
 	INSERT INTO itemShelving (itemFk, shelvingFk, packing, `grouping`, visible)
-		SELECT s.itemFk, vShelvingFk, b.packing, b.`grouping`, cb.quantity AS visible
+		SELECT s.itemFk, vShelvingFk, b.packing, b.`grouping`, cb.quantity visible
 			FROM claim c
 				JOIN claimBeginning cb ON c.id = cb.claimFk
 				JOIN sale s ON s.id = cb.saleFk
 				JOIN ticket t ON t.id = s.ticketFk
-				JOIN tmp.buyUltimate bu ON bu.itemFk = s.itemFk AND bu.warehouseFk = t.warehouseFk
+				JOIN tmp.buyUltimate bu ON bu.itemFk = s.itemFk
+					AND bu.warehouseFk = t.warehouseFk
 				JOIN buy b ON b.id = bu.buyFk
 			WHERE c.id = vClaimFk;
 END$$

db/routines/vn/procedures/itemShelving_addList.sql

@@ -1,6 +1,6 @@
 DELIMITER $$
 CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_addList`(
-	vShelvingFk VARCHAR(3),
+	vShelvingCode VARCHAR(10),
 	vList TEXT,
 	vIsChecking BOOL,
 	vWarehouseFk INT
@@ -13,7 +13,7 @@ BEGIN
  * Cuando es TRUE sólo inserta los elementos de la colección que no están ya en
  * ese shelving, actualizando los valores del campo itemShelving.isChecked
  *
- * @param vShelvingFk Identificador de shelving
+ * @param vShelvingCode Código de shelving
  * @param vList JSON array con esta estructura: '[value1, value2, ...]'
  * @param vIsChecking Define si hay que añadir o comprobar los items
  * @param vWarehouseFk Identificador de warehouse
@@ -24,6 +24,11 @@ BEGIN
 	DECLARE vPath VARCHAR(6);
 	DECLARE vItemFk INT;
 	DECLARE vIsChecked BOOL;
+	DECLARE vShelvingFk INT;
+
+	SELECT id INTO vShelvingFk
+		FROM shelving
+		WHERE code COLLATE utf8_unicode_ci = vShelvingCode;
 
 	WHILE vCounter < vListLength DO
 		SET vPath = CONCAT('$[', vCounter, ']');
@@ -34,17 +39,17 @@ BEGIN
 
 			SELECT IF(COUNT(*), TRUE, FALSE) INTO vIsChecked
 				FROM itemShelving
-				WHERE shelvingFk COLLATE utf8_unicode_ci = vShelvingFk
+				WHERE shelvingFk = vShelvingFk
 					AND itemFk = vItemFk;
 		END IF;
 
 		IF NOT vIsChecking OR NOT vIsChecked THEN
-			CALL itemShelving_add(vShelvingFk, vBarcode, 1, NULL, NULL, NULL, vWarehouseFk);
+			CALL itemShelving_add(vShelvingCode, vBarcode, 1, NULL, NULL, NULL, vWarehouseFk);
 		END IF;
 
 		UPDATE itemShelving
 			SET isChecked = vIsChecked
-			WHERE shelvingFk COLLATE utf8_unicode_ci = vShelvingFk
+			WHERE shelvingFk = vShelvingFk
 				AND itemFk = vItemFk
 				AND isChecked IS NULL;
 

db/routines/vn/procedures/itemShelving_get.sql

@@ -1,10 +1,12 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_get`(IN vSelf VARCHAR(8))
+CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_get`(
+	vShelvingCode VARCHAR(10)
+)
 BEGIN
 /**
-* Lista artículos de itemshelving 
+* Lista artículos de itemShelving.
 *
-* @param vSelf matrícula del carro
+* @param vShelvingCode Matrícula del carro
 **/
 	SELECT ish.itemFk item, 
 			i.name, 
@@ -22,9 +24,9 @@ BEGIN
 			ish.buyFk
 		FROM itemShelving ish
 			JOIN item i ON i.id = ish.itemFk
-			JOIN shelving s ON vSelf = s.code COLLATE utf8_unicode_ci
-			LEFT JOIN parking p ON s.parkingFk = p.id
+			JOIN shelving s ON s.id = ish.shelvingFk
+			LEFT JOIN parking p ON p.id = s.parkingFk
 			JOIN hedera.imageConfig ic
-		WHERE ish.shelvingFk COLLATE utf8_unicode_ci = vSelf;
+		WHERE s.code COLLATE utf8_unicode_ci = vShelvingCode;
 END$$
 DELIMITER ;

db/routines/vn/procedures/itemShelving_getAlternatives.sql

@@ -1,21 +1,31 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_getAlternatives`(vShelvingFk VARCHAR(10))
+CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_getAlternatives`(
+	vShelvingCode VARCHAR(10)
+)
 BEGIN
 /**
- * Devuelve un listado de posibles ubicaciones alternativas a ubicar los item de la matricula
- * del carro que se le ha pasado.
+ * Devuelve un listado de posibles ubicaciones alternativas a ubicar
+ * los item de la matricula del carro que se le ha pasado.
  *
- * @param vShelvingFk matricula del carro
+ * @param vShelvingCode Matricula del carro
  */
-	SELECT is2.id,is2.shelvingFk , p.code, is2.itemFk , is2.visible, p.pickingOrder 
+	DECLARE vShelvingFk INT;
+
+	SELECT id INTO vShelvingFk
+		FROM shelving
+		WHERE code COLLATE utf8_unicode_ci = vShelvingCode;
+
+	SELECT is2.id,is2.shelvingFk, p.code, is2.itemFk , is2.visible, p.pickingOrder 
 		FROM itemShelving is2
-			JOIN shelving sh ON sh.code = is2.shelvingFk
+			JOIN shelving sh ON sh.id = is2.shelvingFk
 			JOIN parking p ON p.id = sh.parkingFk
 			JOIN sector s ON s.id = p.sectorFk
-			LEFT JOIN operator o ON  o.sectorFk = s.id AND o.workerFk = account.myUser_getId()
+			LEFT JOIN operator o ON  o.sectorFk = s.id
+				AND o.workerFk = account.myUser_getId()
 			JOIN warehouse wh ON wh.id = s.warehouseFk
-			JOIN itemShelving is3 ON is3.itemFk = is2.itemFk AND is3.shelvingFk = vShelvingFk COLLATE utf8_unicode_ci
-		WHERE is2.shelvingFk <> vShelvingFk COLLATE utf8_unicode_ci
+			JOIN itemShelving is3 ON is3.itemFk = is2.itemFk
+				AND is3.shelvingFk = vShelvingFk
+		WHERE is2.shelvingFk <> vShelvingFk
 		GROUP BY is2.id
 		ORDER BY p.pickingOrder DESC;
 END$$

db/routines/vn/procedures/itemShelving_getInfo.sql

@@ -16,7 +16,7 @@ BEGIN
 			ish.itemFk itemFk,
 			sh.priority
 		FROM vn.itemShelving ish
-			JOIN vn.shelving sh ON sh.`code` = ish.shelvingFk
+			JOIN vn.shelving sh ON sh.id = ish.shelvingFk
 			JOIN vn.parking pk ON pk.id = sh.parkingFk
 		WHERE ish.itemFk = vItemFk
 		ORDER BY sh.priority DESC, created ASC;

db/routines/vn/procedures/itemShelving_getItemDetails.sql

@@ -1,14 +1,14 @@
 DELIMITER $$
 CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_getItemDetails`(
 	vBarcodeItem INT, 
-	vShelvingFK VARCHAR(10) 
+	vShelvingCode VARCHAR(10) 
 )
 BEGIN
 /**
  * Obtiene el precio y visible de un item
  *
  * @param vBarcodeItem barcode de artículo
- * @param vShelvingFK Ubicación actual del artículo
+ * @param vShelvingCode Ubicación actual del artículo
  */
 	DECLARE vIsItem BOOL;
 	DECLARE vBuyFk INT;
@@ -38,18 +38,19 @@ BEGIN
 	WITH visible AS(
 		SELECT itemFk,
 				IFNULL(buyingValue, 0) +
-							IFNULL(freightValue, 0) +
-							IFNULL(comissionValue, 0) +
-							IFNULL(packageValue, 0) itemCost
-			FROM vn.buy b 
+					IFNULL(freightValue, 0) +
+					IFNULL(comissionValue, 0) +
+					IFNULL(packageValue, 0) itemCost
+			FROM vn.buy b
 			WHERE b.id = vBuyFk
 	) SELECT v.itemFk,
-			vShelvingFK,
+			vShelvingCode,
 			v.itemCost,
 			SUM(ish.visible) visible
 		FROM vn.itemShelving ish
+			JOIN vn.shelving sh ON sh.id = ish.shelvingFK
 			JOIN visible v
-		WHERE ish.shelvingFK = vShelvingFK COLLATE utf8mb3_general_ci
-				AND ish.itemFk = v.itemFk;
+		WHERE sh.code = vShelvingCode COLLATE utf8mb3_general_ci
+			AND ish.itemFk = v.itemFk;
 END$$
 DELIMITER ;

db/routines/vn/procedures/itemShelving_getSaleDate.sql

@@ -1,14 +1,20 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_getSaleDate`(vShelvingFk VARCHAR(3))
+CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_getSaleDate`(
+	vShelvingCode VARCHAR(10)
+)
 BEGIN
-	
-	/* Devuelve la mínima fecha en que se necesita cada producto en esa matrícula.	
-	 * 
-	 *  @param vShelvingFk Matrícula del carro o pallet
-	 */
-
+/**
+ * Devuelve la mínima fecha en que se necesita cada producto en esa matrícula.	
+ * 
+ * @param vShelvingCode Matrícula del carro o pallet
+ */
 	DECLARE vWarehouseFk INT;
 	DECLARE vStockScopeDays INT;
+	DECLARE vShelvingFk INT;
+
+	SELECT id INTO vShelvingFk
+		FROM shelving
+		WHERE code COLLATE utf8_unicode_ci = vShelvingCode;
 
 	SELECT s.warehouseFk, stockScopeDays
 			INTO vWarehouseFk, vStockScopeDays
@@ -30,7 +36,7 @@ BEGIN
 			ENGINE = MEMORY
 			SELECT itemFk, SUM(visible) visible
 				FROM itemShelving
-				WHERE shelvingFk = vShelvingFk COLLATE utf8_unicode_ci
+				WHERE shelvingFk = vShelvingFk
 				GROUP BY itemFk;
 
 	CREATE OR REPLACE TEMPORARY TABLE tmp.tStockByDay
@@ -52,7 +58,7 @@ BEGIN
 									SELECT ish.itemFk, - SUM(ish.visible), util.VN_CURDATE()
 										FROM itemShelving ish 
 											JOIN tmp.tItems i ON i.itemFk = ish.itemFk
-											JOIN shelving sh ON sh.code = ish.shelvingFk 
+											JOIN shelving sh ON sh.id = ish.shelvingFk 
 											JOIN parking p ON sh.parkingFk = p.id 
 											JOIN sector s ON s.id = p.sectorFk
 										WHERE s.isReserve 
@@ -110,7 +116,7 @@ BEGIN
 		UPDATE tmp.tStockByDay sbd
 			JOIN (SELECT ish.itemFK, SUM(ish.visible) amount 
 						FROM itemShelving ish
-							JOIN shelving sh ON sh.code = ish.shelvingFk
+							JOIN shelving sh ON sh.id = ish.shelvingFk
 							JOIN parking p ON p.id = sh.parkingFk
 							JOIN sector s ON s.id = p.sectorFk
 						WHERE s.warehouseFk = vWarehouseFk
@@ -150,10 +156,10 @@ BEGIN
 								p.sectorFk,
 								ish.shelvingFk
 							FROM itemShelving ish
-								JOIN vn.shelving sh ON sh.code = ish.shelvingFk
+								JOIN vn.shelving sh ON sh.id = ish.shelvingFk
 								LEFT JOIN parking p ON p.id = parkingFk
 								LEFT JOIN vn.sector s ON s.id = p.sectorFk
-							WHERE ish.shelvingFk = vShelvingFk COLLATE utf8_unicode_ci
+							WHERE ish.shelvingFk = vShelvingFk
 					) sub4 ON sub4.itemFk = ts.itemFk
 					LEFT JOIN sector s ON s.id = sub4.sectorFk
 					LEFT JOIN item i ON i.id = ts.itemFk

db/routines/vn/procedures/itemShelving_inventory.sql

@@ -42,7 +42,7 @@ BEGIN
 			JOIN item i ON i.id = ish.itemFk
 			JOIN itemType it ON it.id = i.typeFk
 			JOIN tmp.stockMisfit sm ON sm.itemFk = ish.itemFk
-			JOIN shelving sh ON sh.code = ish.shelvingFk
+			JOIN shelving sh ON sh.id = ish.shelvingFk
 			JOIN parking p ON p.id = sh.parkingFk
 			LEFT JOIN (
 				SELECT s.itemFk, sum(s.quantity) notPrepared

db/routines/vn/procedures/itemShelving_selfConsumption.sql

@@ -1,6 +1,6 @@
 DELIMITER $$
 CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_selfConsumption`(
-	vShelvingFk VARCHAR(10) COLLATE utf8_general_ci, 
+	vShelvingCode VARCHAR(10) COLLATE utf8_general_ci, 
 	vItemFk INT, 
 	vQuantity INT
 )
@@ -9,9 +9,9 @@ BEGIN
  * Leave the indicated amount on the shelve
  * and create a ticket with the difference.
  * 
- * @param vShelvingFk id of the shelve where the item is located.
- * @param vItemFk article of which the self-consumption ticket is to be created.
- * @param vQuantity amount that will stay on the shelve
+ * @param vShelvingCode Code of the shelve where the item is located
+ * @param vItemFk Item of which the self-consumption ticket is to be created
+ * @param vQuantity Amount that will stay on the shelve
  */
 	DECLARE vVisible INT;
 	DECLARE vClientFk INT;
@@ -21,6 +21,11 @@ BEGIN
 	DECLARE vAgencyModeFk INT;
 	DECLARE vItemShelvingFk INT;
 	DECLARE vAddressFk INT;
+	DECLARE vShelvingFk INT;
+
+	SELECT id INTO vShelvingFk
+		FROM shelving
+		WHERE code = vShelvingCode;
 
 	SELECT c.id,
 			pc.clientSelfConsumptionFk,
@@ -37,7 +42,7 @@ BEGIN
 			JOIN parking p ON p.sectorFk = s.id
 			JOIN shelving s2 ON s2.parkingFk = p.id
 			JOIN productionConfig pc
-		WHERE s2.code = vShelvingFk;
+		WHERE s2.id = vShelvingFk;
 
 	IF vClientFk IS NULL THEN
 		CALL util.throw('The company does not have a customer assigned');
@@ -47,7 +52,7 @@ BEGIN
 		CALL util.throw('The shelf cannot have NULL or negative quantities');
 	END IF;
 
-	IF vShelvingFk IS NULL THEN
+	IF vShelvingCode IS NULL THEN
 		CALL util.throw('The shelf is necessary');
 	END IF;
 

db/routines/vn/procedures/itemShelving_transfer.sql

@@ -1,7 +1,7 @@
 DELIMITER $$
 CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`itemShelving_transfer`(
 	vItemShelvingFk INT, 
-	vShelvingFk VARCHAR(10)
+	vShelvingCode VARCHAR(10)
 )
 BEGIN
 /**
@@ -9,9 +9,14 @@ BEGIN
  * fusionando si coincide el packing y la fecha.
  *
  * @param vItemShelvingFk Identificador de itemShelving
- * @param vShelvingFk Identificador de shelving
+ * @param vShelvingCode Código de shelving
  */
 	DECLARE vNewItemShelvingFk INT;
+	DECLARE vShelvingFk INT;
+
+	SELECT id INTO vShelvingFk
+		FROM shelving
+		WHERE code COLLATE utf8_unicode_ci = vShelvingCode;
 
 	SELECT MAX(ish.id) INTO vNewItemShelvingFk
 		FROM itemShelving ish
@@ -26,7 +31,7 @@ BEGIN
 				AND ish2.packing = ish.packing
 				AND DATE(ish2.created) = DATE(ish.created)
 				AND ish2.buyFk = ish.buyFk
-		WHERE ish.shelvingFk = vShelvingFk COLLATE utf8_unicode_ci;
+		WHERE ish.shelvingFk = vShelvingFk;
 
 	IF vNewItemShelvingFk THEN
 		UPDATE itemShelving ish
@@ -38,9 +43,7 @@ BEGIN
 		DELETE FROM itemShelving
 			WHERE id = vItemShelvingFk;
 	ELSE
-		IF (SELECT EXISTS(SELECT id FROM shelving
-			WHERE code = vShelvingFk COLLATE utf8_unicode_ci)) THEN
-
+		IF (SELECT EXISTS(SELECT id FROM shelving WHERE id = vShelvingFk)) THEN
 			UPDATE itemShelving
 				SET shelvingFk = vShelvingFk
 				WHERE id = vItemShelvingFk;

db/routines/vn/procedures/item_devalueA2.sql

@@ -1,7 +1,7 @@
 DELIMITER $$
 CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`item_devalueA2`(
 	vSelf INT, 
-	vShelvingFK VARCHAR(10), 
+	vShelvingCode VARCHAR(10) COLLATE utf8mb3_general_ci, 
 	vBuyingValue DECIMAL(10,4),
 	vQuantity INT
 )
@@ -12,7 +12,7 @@ BEGIN
  * de almacén y shelvings correspondientes
  *
  * @param vSelf Id de artículo a devaluar
- * @param vShelvingFK Ubicación actual del artículo
+ * @param vShelvingCode Código de shelving / ubicación
  * @param vBuyingValue Nuevo precio de coste
  * @param vQuantity Cantidad del ítem a pasar a A2
  */
@@ -109,10 +109,11 @@ BEGIN
 		CALL util.throw ('The item has not a buy');
 	END IF;
 
-	SELECT id,visible INTO vTargetItemShelvingFk, vCurrentVisible
-		FROM itemShelving
-		WHERE shelvingFk = vShelvingFK COLLATE utf8mb3_general_ci
-			AND itemFk = vSelf
+	SELECT ish.id, ish.visible INTO vTargetItemShelvingFk, vCurrentVisible
+		FROM itemShelving ish
+			JOIN shelving sh ON sh.id = ish.shelvingFk
+		WHERE sh.code = vShelvingCode
+			AND ish.itemFk = vSelf
 		LIMIT 1;
 	
 	IF vCurrentVisible IS NULL THEN
@@ -388,16 +389,17 @@ BEGIN
 			userFk, 
 			isChecked) 
 		SELECT vItemA2Fk, 
-				shelvingFk, 
+				ish.shelvingFk, 
 				vQuantity ,
-				`grouping`, 
-				packing, 
-				packagingFk, 
+				ish.`grouping`, 
+				ish.packing, 
+				ish.packagingFk, 
 				account.myUser_getId(), 
-				isChecked
-			FROM itemShelving
-			WHERE itemFK = vSelf
-				AND shelvingFk = vShelvingFK COLLATE utf8mb3_general_ci
+				ish.isChecked
+			FROM itemShelving ish
+				JOIN shelving sh ON sh.id = ish.shelvingFk
+			WHERE ish.itemFK = vSelf
+				AND sh.code = vShelvingCode
 			ON DUPLICATE KEY UPDATE 
 				visible = vQuantity + VALUES(visible);
 

db/routines/vn/procedures/productionControl.sql

@@ -217,7 +217,7 @@ proc: BEGIN
 				st.code = 'previousPrepared' isPreviousPrepared,
 				sc.itemPackingTypeFk
 			FROM itemShelving ish
-				JOIN shelving sh ON sh.code = ish.shelvingFk
+				JOIN shelving sh ON sh.id = ish.shelvingFk
 				JOIN parking p ON p.id = sh.parkingFk
 				JOIN sector sc ON sc.id = p.sectorFk
 				JOIN sectorType st ON st.id = sc.typeFk

db/routines/vn/procedures/sale_boxPickingPrint.sql

@@ -27,7 +27,7 @@ BEGIN
 	DECLARE vQuantity INT;
 	DECLARE vRemainder INT DEFAULT 0;
 	DECLARE vRemainderSaleFk INT;
-	DECLARE vShelving VARCHAR(10);
+	DECLARE vShelvingFk VARCHAR(10);
 	DECLARE vTicketFk INT;
 
 	SELECT 	s.quantity,
@@ -74,7 +74,7 @@ w1:	WHILE vQuantity >= vPacking DO
 						p.pickingOrder,
 						ish.created
 						FROM itemShelving ish 
-							JOIN shelving sh ON sh.code = ish.shelvingFk
+							JOIN shelving sh ON sh.id = ish.shelvingFk
 							JOIN parking p ON p.id = sh.parkingFk
 							LEFT JOIN itemShelvingSale iss
 								ON iss.itemShelvingFk = ish.id
@@ -262,9 +262,9 @@ w1:	WHILE vQuantity >= vPacking DO
 		CALL dipole.expedition_Add(vExpeditionFk,vPrinterFk, TRUE);
 
 		SELECT shelvingFk, p.code 
-			INTO vShelving, vParkingCode
+			INTO vShelvingFk, vParkingCode
 			FROM itemShelving ish
-				JOIN shelving sh ON sh.code = ish.shelvingFk
+				JOIN shelving sh ON sh.id = ish.shelvingFk
 				JOIN parking p ON p.id = sh.parkingFk
 			WHERE ish.id = vItemShelvingFk;
 
@@ -273,7 +273,7 @@ w1:	WHILE vQuantity >= vPacking DO
 				itemFk = vItemFk,
 				quantity = vPacking,
 				longName = vConcept,
-				shelvingFk = vShelving,
+				shelvingFk = vShelvingFk,
 				parkingCode = vParkingCode,
 				phone = RIGHT(phone,vMaxPhoneLength),
 				street = RIGHT(street, vMAxStreetLength)

db/routines/vn/procedures/sale_getBoxPickingList.sql

@@ -41,7 +41,7 @@ BEGIN
 								AND iss.created >= vDated
 							GROUP BY iss.itemShelvingFk, s.itemFk) tISS 
 				ON tISS.itemFk = ish.itemFk AND tISS.itemShelvingFk = ish.id
-			JOIN shelving sh ON sh.code = ish.shelvingFk
+			JOIN shelving sh ON sh.id = ish.shelvingFk
 			JOIN parking p ON p.id = sh.parkingFk
 			JOIN tmp.productionBuffer pb ON pb.ticketFk = s.ticketFk
 			JOIN agencyMode am ON am.id = pb.agencyModeFk

db/routines/vn/procedures/sale_getProblems.sql

@@ -87,7 +87,7 @@ BEGIN
 				SUM(ish.visible) visible,
 				s.warehouseFk warehouseFk
 			FROM itemShelving ish
-				JOIN shelving sh ON sh.code = ish.shelvingFk
+				JOIN shelving sh ON sh.id = ish.shelvingFk
 				JOIN parking p ON p.id = sh.parkingFk
 				JOIN sector s ON s.id = p.sectorFk
 			GROUP BY ish.itemFk, s.warehouseFk;

db/routines/vn/procedures/shelvingChange.sql

@@ -1,11 +1,13 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`shelvingChange`(IN `vShelvingO` VARCHAR(8), IN `vShelvingD` VARCHAR(8))
+CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`shelvingChange`(
+	`vShelvingO` VARCHAR(10),
+	`vShelvingD` VARCHAR(10)
+)
 BEGIN
-
-     UPDATE vn.itemShelving
-     SET shelvingFk =  vShelvingD COLLATE utf8_unicode_ci 
-     WHERE shelvingFk = vShelvingO COLLATE utf8_unicode_ci;  
-     
-    
+	UPDATE itemShelving ish
+		JOIN shelving sh1 ON sh1.code = vShelvingD COLLATE utf8_unicode_ci
+		JOIN shelving sh2 ON sh2.code = vShelvingO COLLATE utf8_unicode_ci
+	SET ish.shelvingFk =  sh1.id
+	WHERE ish.shelvingFk = sh2.id;
 END$$
 DELIMITER ;

db/routines/vn/procedures/shelvingParking_get.sql

@@ -1,8 +1,10 @@
 DELIMITER $$
-CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`shelvingParking_get`(vShelvingFk VARCHAR(10), vWarehouseFk INT, vDayRange INT)
-BEGIN
-
-	
+CREATE OR REPLACE DEFINER=`vn`@`localhost` PROCEDURE `vn`.`shelvingParking_get`(
+	vShelvingCode VARCHAR(10),
+	vWarehouseFk INT,
+	vDayRange INT
+)
+BEGIN	
 SELECT 	s.itemFk, 
 	s.concept,
 	CAST(SUM(s.quantity) AS DECIMAL(10,0)) as sinServir, 
@@ -10,14 +12,15 @@ SELECT 	s.itemFk,
 	FROM vn.sale s
 		LEFT JOIN vn.itemShelvingSale iss ON iss.saleFk = s.id
 		JOIN vn.ticket t ON t.id = s.ticketFk
-		LEFT JOIN vn.itemShelvingStock ist ON ist.itemFk = s.itemFk AND ist.warehouseFk = vWarehouseFk
-		JOIN vn.itemShelving ish ON ish.itemFk = s.itemFk AND ish.shelvingFk = vShelvingFk COLLATE utf8_general_ci
+		LEFT JOIN vn.itemShelvingStock ist ON ist.itemFk = s.itemFk
+			AND ist.warehouseFk = vWarehouseFk
+		JOIN vn.itemShelving ish ON ish.itemFk = s.itemFk
+		JOIN shelving sh ON sh.id = ish.shelvingFk
+			AND sh.code = vShelvingCode COLLATE utf8_general_ci
 	WHERE t.shipped BETWEEN util.VN_CURDATE() AND util.dayend(TIMESTAMPADD(DAY, GREATEST(0,vDayRange), util.VN_CURDATE())) 
 		AND iss.saleFk IS NULL
 		AND t.warehouseFk = vWarehouseFk
 	GROUP BY s.itemFk
 	HAVING sinServir > aparcado;
-			
-
 END$$
 DELIMITER ;

db/routines/vn/procedures/shelving_clean.sql

@@ -12,12 +12,12 @@ BEGIN
 
 	DELETE ish.* 
 		FROM itemShelving ish
-			JOIN vn.shelving sh ON sh.code = ish.shelvingFk
+			JOIN vn.shelving sh ON sh.id = ish.shelvingFk
 			WHERE sh.parkingFk IS NULL
 			AND ish.created < TIMESTAMPADD(WEEK,-1,util.VN_CURDATE());
 
 UPDATE shelving sh
-	LEFT JOIN itemShelving its ON its.shelvingFk = sh.`code`
+	LEFT JOIN itemShelving its ON its.shelvingFk = sh.id
 		SET isPrinted = 0,
 		parkingFk = NULL
 	WHERE its.id IS NULL
@@ -27,11 +27,11 @@ UPDATE shelving sh
 			OR
 			sh.parked < util.VN_CURDATE() - INTERVAL 2 WEEK
 		)
-			
 		AND IF(code REGEXP '^[A-Za-z]{2}[0-9]', LEFT (code, 2) NOT IN (
-				SELECT DISTINCT LEFT(its.shelvingFk, 2)
+				SELECT DISTINCT LEFT(sh.code, 2)
 					FROM itemShelving its
-					WHERE its.shelvingFk REGEXP '^[A-Za-z]{2}[0-9]'
+						JOIN shelving sh ON sh.id = its.shelvingFk
+					WHERE sh.code REGEXP '^[A-Za-z]{2}[0-9]'
 				), TRUE);
 
 END$$

db/routines/vn/procedures/shelving_getSpam.sql

@@ -25,7 +25,7 @@ BEGIN
 		LEFT JOIN (
 			SELECT ish.itemFk, CAST(SUM(ish.visible) AS DECIMAL(10,0)) AS reserva
 				FROM vn.itemShelving ish
-					JOIN vn.shelving sh ON sh.code = ish.shelvingFk
+					JOIN vn.shelving sh ON sh.id = ish.shelvingFk
 					JOIN vn.parking p ON p.id = sh.parkingFk
 					JOIN vn.sector s ON s.id = p.sectorFk
 				WHERE s.code = 'FUENTES_PICASSE'
@@ -68,7 +68,7 @@ BEGIN
 			sh.isSpam
 		FROM vn.itemShelving ish
 			JOIN vn.item i ON i.id = ish.itemFk
-			JOIN vn.shelving sh ON sh.code = ish.shelvingFk
+			JOIN vn.shelving sh ON sh.id = ish.shelvingFk
 			JOIN vn.parking p ON p.id = sh.parkingFk
 			JOIN vn.sector s ON s.id = p.sectorFk
 			JOIN vn.warehouse w ON w.id = s.warehouseFk

db/routines/vn/procedures/stockBought_calculate.sql

@@ -59,7 +59,7 @@ proc: BEGIN
 	
 	INSERT INTO stockBought(workerFk, bought, dated)
 		SELECT tb.workerFk, 
-				ROUND(GREATEST(tb.bought - IFNULL(ts.sold, 0), 0), 1), 
+				ROUND(GREATEST(tb.bought - IFNULL(ts.sold, 0), 0), 2), 
 				vDated
 			FROM tStockBought tb 
 				LEFT JOIN tStockSold ts ON ts.workerFk = tb.workerFk;

db/routines/vn/procedures/ticketDown_PrintableSelection.sql

@@ -9,7 +9,7 @@ BEGIN
 					JOIN vn.sale s ON s.ticketFk = t.id
                     JOIN vn.itemShelvingSale iss ON iss.saleFk = s.id
                     JOIN vn.itemShelving ish ON ish.id = iss.itemShelvingFk
-                    JOIN vn.shelving sh ON sh.code = ish.shelvingFk
+                    JOIN vn.shelving sh ON sh.id = ish.shelvingFk
                     JOIN vn.parking p ON p.id = sh.parkingFk
 					WHERE p.sectorFk = vSectorFk
 			) sub ON sub.id = td.ticketFk

db/routines/vn/procedures/ticket_DelayTruckSplit.sql

@@ -27,7 +27,7 @@ BEGIN
 							SUM(ish.visible) visible,
 							s.warehouseFk warehouseFk
 						FROM itemShelving ish
-							JOIN shelving sh ON sh.code = ish.shelvingFk
+							JOIN shelving sh ON sh.id = ish.shelvingFk
 							JOIN parking p ON p.id = sh.parkingFk
 							JOIN sector s ON s.id = p.sectorFk
 						GROUP BY ish.itemFk,

db/routines/vn/procedures/ticket_getSplitList.sql

@@ -28,7 +28,7 @@ BEGIN
 				SUM(ish.visible) visible,
 				s.warehouseFk warehouseFk
 			FROM itemShelving ish
-				JOIN shelving sh ON sh.code = ish.shelvingFk
+				JOIN shelving sh ON sh.id = ish.shelvingFk
 				JOIN parking p ON p.id = sh.parkingFk
 				JOIN sector s ON s.id = p.sectorFk
 			GROUP BY ish.itemFk,

db/routines/vn/views/itemShelvingList.sql

@@ -15,7 +15,7 @@ FROM (
 		(
 			(
 				`vn`.`itemShelving` `ish`
-				JOIN `vn`.`shelving` `sh` ON(`sh`.`code` = `ish`.`shelvingFk`)
+				JOIN `vn`.`shelving` `sh` ON(`sh`.`id` = `ish`.`shelvingFk`)
 			)
 			JOIN `vn`.`item` `i` ON(`i`.`id` = `ish`.`itemFk`)
 		)

db/routines/vn/views/itemShelvingPlacementSupplyStock.sql

@@ -18,7 +18,7 @@ FROM (
 		(
 			(
 				`vn`.`itemShelving` `ish`
-				JOIN `vn`.`shelving` `sh` ON(`sh`.`code` = `ish`.`shelvingFk`)
+				JOIN `vn`.`shelving` `sh` ON(`sh`.`id` = `ish`.`shelvingFk`)
 			)
 			LEFT JOIN `vn`.`parking` `p` ON(`p`.`id` = `sh`.`parkingFk`)
 		)

db/routines/vn/views/itemShelvingSaleSum.sql

@@ -13,7 +13,7 @@ FROM (
 				`vn`.`itemShelvingSale` `iss`
 				JOIN `vn`.`itemShelving` `ish` ON(`ish`.`id` = `iss`.`itemShelvingFk`)
 			)
-			JOIN `vn`.`shelving` `sh` ON(`sh`.`code` = `ish`.`shelvingFk`)
+			JOIN `vn`.`shelving` `sh` ON(`sh`.`id` = `ish`.`shelvingFk`)
 		)
 		JOIN `vn`.`parking` `p` ON(`p`.`id` = `sh`.`parkingFk`)
 	)

db/routines/vn/views/itemShelvingStock.sql

@@ -21,7 +21,7 @@ FROM (
 			(
 				(
 					`vn`.`itemShelving` `ish`
-					LEFT JOIN `vn`.`shelving` `sh` ON(`sh`.`code` = `ish`.`shelvingFk`)
+					LEFT JOIN `vn`.`shelving` `sh` ON(`sh`.`id` = `ish`.`shelvingFk`)
 				)
 				LEFT JOIN `vn`.`parking` `p` ON(`p`.`id` = `sh`.`parkingFk`)
 			)

db/routines/vn/views/itemShelvingStockFull.sql

@@ -19,7 +19,7 @@ FROM (
 			(
 				(
 					`vn`.`itemShelving` `ish`
-					JOIN `vn`.`shelving` `sh` ON(`sh`.`code` = `ish`.`shelvingFk`)
+					JOIN `vn`.`shelving` `sh` ON(`sh`.`id` = `ish`.`shelvingFk`)
 				)
 				JOIN `vn`.`parking` `p` ON(`p`.`id` = `sh`.`parkingFk`)
 			)

db/versions/11251-navyChrysanthemum/00-firstScript.sql

@@ -1,3 +1,2 @@
-UPDATE vn.sale
-    SET originalQuantity = quantity
-    WHERE originalQuantity IS NULL
+-- Debido a que tardaba mucho en la subida a master, se ha creado una nueva versión para que el proceso no se vea afectado y se ejecute por la noche.
+-- Se crea de nuevo en la versión 11344-grayBamboo

db/versions/11336-chocolateRaphis/00-firstScript.sql

@@ -0,0 +1,8 @@
+DELETE FROM salix.ACL
+	WHERE property IN ('cmrs', 'cmr', 'downloadCmrsZip')
+		AND model = 'Route';
+	
+INSERT INTO salix.ACL (model,property,principalId)
+	VALUES ('Cmr','filter','production'),
+		('Cmr','downloadZip','production'),
+		('Cmr','print','production')

db/versions/11342-crimsonDendro/00-itemShelving.sql

@@ -0,0 +1,6 @@
+CREATE OR REPLACE TEMPORARY TABLE tmp.tItemShelving
+	(PRIMARY KEY (id))
+	ENGINE = MEMORY
+	SELECT ish.id, s.id shelvingFk
+		FROM vn.itemShelving ish
+			JOIN vn.shelving s ON s.code = ish.shelvingFk COLLATE utf8mb3_unicode_ci;

db/versions/11342-crimsonDendro/01-itemShelving.sql

@@ -0,0 +1,2 @@
+ALTER TABLE vn.itemShelving DROP FOREIGN KEY itemShelving_fk2,
+	MODIFY COLUMN shelvingFk int(11) NOT NULL;

db/versions/11342-crimsonDendro/02-itemShelving.sql

@@ -0,0 +1,3 @@
+UPDATE vn.itemShelving ish
+		JOIN tmp.tItemShelving tish ON tish.id = ish.id
+	SET ish.shelvingFk = tish.shelvingFk;

db/versions/11342-crimsonDendro/03-itemShelving.sql

@@ -0,0 +1,4 @@
+ALTER TABLE vn.itemShelving
+	ADD CONSTRAINT itemShelving_shelving_FK FOREIGN KEY (shelvingFk) REFERENCES vn.shelving(id)
+		ON DELETE RESTRICT
+		ON UPDATE CASCADE;

db/versions/11342-crimsonDendro/04-itemShelvingLog.sql

@@ -0,0 +1,8 @@
+/*
+CREATE OR REPLACE TEMPORARY TABLE tmp.tItemShelvingLog
+	(PRIMARY KEY (id))
+	ENGINE = MEMORY
+	SELECT ishl.id, s.id shelvingFk
+		FROM vn.itemShelvingLog ishl
+			JOIN vn.shelving s ON s.code = ishl.shelvingFk COLLATE utf8mb3_unicode_ci;
+*/

db/versions/11342-crimsonDendro/05-itemShelvingLog.sql

@@ -0,0 +1 @@
+-- ALTER TABLE vn.itemShelvingLog MODIFY COLUMN shelvingFk int(11) NOT NULL;

db/versions/11342-crimsonDendro/06-itemShelvingLog.sql

@@ -0,0 +1,7 @@
+/*
+UPDATE vn.itemShelvingLog ishl
+		JOIN tmp.tItemShelvingLog tishl ON tishl.id = ishl.id
+	SET ishl.shelvingFk = tishl.shelvingFk;
+
+DROP TEMPORARY TABLE tmp.tItemShelvingLog;
+*/

db/versions/11343-silverAsparagus/00-firstScript.sql

@@ -0,0 +1,9 @@
+INSERT INTO salix.ACL (model, property, accessType, principalId)
+	VALUES ('Collection', 'create', 'WRITE', 'productionBoss'),
+		('Collection', 'upsert', 'WRITE', 'productionBoss'),
+		('Collection', 'replaceById', 'WRITE', 'productionBoss'),
+		('Collection', 'updateAll', 'WRITE', 'productionBoss'),
+		('Collection', 'updateAttributes', 'WRITE', 'productionBoss'),
+		('Collection', 'deleteById', 'WRITE', 'productionBoss'),
+		('Collection', 'destroyAll', 'WRITE', 'productionBoss'),
+		('Collection', 'destroyById', 'WRITE', 'productionBoss');

db/versions/11344-grayBamboo/00-firstScript.sql

@@ -0,0 +1,3 @@
+UPDATE vn.sale
+    SET originalQuantity = quantity
+    WHERE originalQuantity IS NULL

db/versions/11345-salmonEucalyptus/00-firstScript.sql

@@ -0,0 +1,2 @@
+ALTER TABLE account.user CHANGE recoverPass recoverPass__ tinyint(3) unsigned NOT NULL DEFAULT 1 COMMENT '@deprecated 2024-11-13';
+ALTER TABLE account.user CHANGE sync sync__ tinyint(4) NOT NULL DEFAULT 0 COMMENT '@deprecated 2024-11-13';

db/versions/11347-redErica/00-firstScript.sql

@@ -0,0 +1,9 @@
+DROP TABLE IF EXISTS vn.saySimpleConfig;
+
+CREATE TABLE vn.saySimpleConfig(
+	id INT AUTO_INCREMENT PRIMARY KEY,
+	url VARCHAR(255) NOT NULL,
+	defaultChannel VARCHAR(128)
+);
+
+ALTER TABLE vn.saySimpleCountry MODIFY COLUMN channel VARCHAR(128);

db/versions/11348-bronzeCamellia/00-firstScript.sql

@@ -0,0 +1,2 @@
+ALTER TABLE vn.clientObservation MODIFY COLUMN observationTypeFk tinyint(3) unsigned DEFAULT 4 NOT NULL;
+UPDATE vn.clientObservation SET observationTypeFk=4 WHERE observationTypeFk=0;

db/versions/11350-silverArborvitae/00-firstScript.sql

@@ -0,0 +1,2 @@
+ALTER TABLE vn.shelvingLog
+    MODIFY COLUMN changedModel enum('Shelving', 'ItemShelving') CHARACTER SET utf8mb3 COLLATE utf8mb3_unicode_ci DEFAULT 'Shelving' NOT NULL;

e2e/paths/04-item/01_summary.spec.js

@@ -1,133 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Item summary path', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('employee', 'item');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should search for an item', async() => {
-        await page.doSearch('Ranged weapon');
-        const resultsCount = await page.countElement(selectors.itemsIndex.searchResult);
-
-        await page.waitForTextInElement(selectors.itemsIndex.firstSearchResult, 'Ranged weapon');
-        await page.waitToClick(selectors.itemsIndex.firstResultPreviewButton);
-        const isVisible = await page.isVisible(selectors.itemSummary.basicData);
-
-        expect(resultsCount).toBe(4);
-        expect(isVisible).toBeTruthy();
-    });
-
-    it(`should check the item summary preview shows fields from basic data`, async() => {
-        await page.waitForTextInElement(selectors.itemSummary.basicData, 'Ranged weapon longbow 200cm');
-        const result = await page.waitToGetProperty(selectors.itemSummary.basicData, 'innerText');
-
-        expect(result).toContain('Ranged weapon longbow 200cm');
-    });
-
-    it(`should check the item summary preview shows fields from tags`, async() => {
-        await page.waitForTextInElement(selectors.itemSummary.tags, 'Brown');
-        const result = await page.waitToGetProperty(selectors.itemSummary.tags, 'innerText');
-
-        expect(result).toContain('Brown');
-    });
-
-    it(`should check the item summary preview shows fields from botanical`, async() => {
-        await page.waitForTextInElement(selectors.itemSummary.botanical, 'Abelia');
-        const result = await page.waitToGetProperty(selectors.itemSummary.botanical, 'innerText');
-
-        expect(result).toContain('Abelia');
-    });
-
-    it(`should check the item summary preview shows fields from barcode`, async() => {
-        await page.waitForTextInElement(selectors.itemSummary.barcode, '1');
-        const result = await page.waitToGetProperty(selectors.itemSummary.barcode, 'innerText');
-
-        expect(result).toContain('1');
-    });
-
-    it(`should close the summary popup`, async() => {
-        await page.closePopup();
-        await page.waitForSelector(selectors.itemSummary.basicData, {hidden: true});
-    });
-
-    it('should search for other item', async() => {
-        await page.doSearch('Melee Reinforced');
-        const resultsCount = await page.countElement(selectors.itemsIndex.searchResult);
-
-        await page.waitToClick(selectors.itemsIndex.firstResultPreviewButton);
-        await page.waitForSelector(selectors.itemSummary.basicData, {visible: true});
-
-        expect(resultsCount).toBe(3);
-    });
-
-    it(`should now check the item summary preview shows fields from basic data`, async() => {
-        await page.waitForTextInElement(selectors.itemSummary.basicData, 'Melee Reinforced weapon combat fist 15cm');
-        const result = await page.waitToGetProperty(selectors.itemSummary.basicData, 'innerText');
-
-        expect(result).toContain('Melee Reinforced weapon combat fist 15cm');
-    });
-
-    it(`should now check the item summary preview shows fields from tags`, async() => {
-        await page.waitForTextInElement(selectors.itemSummary.tags, 'Silver');
-        const result = await page.waitToGetProperty(selectors.itemSummary.tags, 'innerText');
-
-        expect(result).toContain('Silver');
-    });
-
-    it(`should now check the item summary preview shows fields from botanical`, async() => {
-        await page.waitForTextInElement(selectors.itemSummary.botanical, '-');
-        const result = await page.waitToGetProperty(selectors.itemSummary.botanical, 'innerText');
-
-        expect(result).toContain('-');
-    });
-
-    it(`should now close the summary popup`, async() => {
-        await page.closePopup();
-        await page.waitForSelector(selectors.itemSummary.basicData, {hidden: true});
-    });
-
-    it(`should navigate to one of the items detailed section`, async() => {
-        await page.accessToSearchResult('Melee weapon combat fist 15cm');
-        await page.waitForState('item.card.summary');
-    });
-
-    it(`should check the descritor edit button is not visible for employee`, async() => {
-        const visibleButton = await page.isVisible(selectors.itemDescriptor.editButton);
-
-        expect(visibleButton).toBeFalsy();
-    });
-
-    it(`should check the item summary shows fields from basic data section`, async() => {
-        await page.waitForTextInElement(selectors.itemSummary.basicData, 'Melee weapon combat fist 15cm');
-        const result = await page.waitToGetProperty(selectors.itemSummary.basicData, 'innerText');
-
-        expect(result).toContain('Melee weapon combat fist 15cm');
-    });
-
-    it(`should check the item summary shows fields from tags section`, async() => {
-        const result = await page.waitToGetProperty(selectors.itemSummary.tags, 'innerText');
-
-        expect(result).toContain('Silver');
-    });
-
-    it(`should check the item summary shows fields from botanical section`, async() => {
-        const result = await page.waitToGetProperty(selectors.itemSummary.botanical, 'innerText');
-
-        expect(result).toContain('procera');
-    });
-
-    it(`should check the item summary shows fields from barcodes section`, async() => {
-        const result = await page.waitToGetProperty(selectors.itemSummary.barcode, 'innerText');
-
-        expect(result).toContain('4');
-    });
-});

e2e/paths/04-item/02_basic_data.spec.js

@@ -1,64 +0,0 @@
-import getBrowser from '../../helpers/puppeteer';
-
-const $ = {
-    form: 'vn-item-basic-data form',
-    intrastatForm: '.vn-dialog.shown form',
-    newIntrastatButton: 'vn-item-basic-data vn-icon-button[vn-tooltip="New intrastat"] > button'
-};
-
-describe('Item Edit basic data path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('buyer', 'item');
-        await page.accessToSearchResult('Melee weapon combat fist 15cm');
-    });
-
-    beforeEach(async() => {
-        await page.accessToSection('item.card.basicData');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it(`should edit the item basic data and confirm the item data was edited`, async() => {
-        const values = {
-            type: 'Anthurium',
-            intrastat: 'Coral y materiales similares',
-            relevancy: 1,
-            generic: 'Pallet',
-            isActive: false,
-            priceInKg: true,
-            isFragile: true,
-            packingOut: 5
-        };
-
-        const message = await page.sendForm($.form, values);
-        await page.reloadSection('item.card.basicData');
-        const formValues = await page.fetchForm($.form, Object.keys(values));
-
-        expect(message.isSuccess).toBeTrue();
-        expect(formValues).toEqual(values);
-    });
-
-    it(`should create a new intrastat and save it`, async() => {
-        await page.click($.newIntrastatButton);
-        await page.waitForSelector($.intrastatForm);
-        await page.fillForm($.intrastatForm, {
-            id: '588420239',
-            description: 'Tropical Flowers'
-        });
-        await page.respondToDialog('accept');
-
-        const message = await page.sendForm($.form);
-        await page.reloadSection('item.card.basicData');
-        const formValues = await page.fetchForm($.form, ['intrastat']);
-
-        expect(message.isSuccess).toBeTrue();
-        expect(formValues).toEqual({intrastat: 'Tropical Flowers'});
-    });
-});

e2e/paths/04-item/03_tax.spec.js

@@ -1,48 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Item edit tax path', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('buyer', 'item');
-        await page.accessToSearchResult('Ranged weapon longbow 200cm');
-        await page.accessToSection('item.card.tax');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it(`should add the item tax to all countries`, async() => {
-        await page.autocompleteSearch(selectors.itemTax.firstClass, 'General VAT');
-        await page.autocompleteSearch(selectors.itemTax.secondClass, 'General VAT');
-        await page.waitToClick(selectors.itemTax.submitTaxButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should confirm the first item tax class was edited`, async() => {
-        await page.reloadSection('item.card.tax');
-        const firstVatType = await page.waitToGetProperty(selectors.itemTax.firstClass, 'value');
-
-        expect(firstVatType).toEqual('General VAT');
-    });
-
-    it(`should confirm the second item tax class was edited`, async() => {
-        const secondVatType = await page
-            .waitToGetProperty(selectors.itemTax.secondClass, 'value');
-
-        expect(secondVatType).toEqual('General VAT');
-    });
-
-    it(`should edit the first class without saving the form`, async() => {
-        await page.autocompleteSearch(selectors.itemTax.firstClass, 'Reduced VAT');
-        const firstVatType = await page.waitToGetProperty(selectors.itemTax.firstClass, 'value');
-
-        expect(firstVatType).toEqual('Reduced VAT');
-    });
-});

e2e/paths/04-item/04_tags.spec.js

@@ -1,79 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Item create tags path', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('buyer', 'item');
-        await page.accessToSearchResult('Ranged weapon longbow 200cm');
-        await page.accessToSection('item.card.tags');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should create a new tag and delete a former one', async() => {
-        await page.waitToClick(selectors.itemTags.fourthRemoveTagButton);
-        await page.waitToClick(selectors.itemTags.addItemTagButton);
-        await page.autocompleteSearch(selectors.itemTags.seventhTag, 'Ancho de la base');
-        await page.write(selectors.itemTags.seventhValue, '50');
-        await page.clearInput(selectors.itemTags.seventhRelevancy);
-        await page.write(selectors.itemTags.seventhRelevancy, '4');
-        await page.waitToClick(selectors.itemTags.submitItemTagsButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should confirm the fourth row data is the expected one', async() => {
-        await page.reloadSection('item.card.tags');
-        await page.waitForSelector('vn-item-tags');
-        let result = await page.waitToGetProperty(selectors.itemTags.fourthTag, 'value');
-
-        expect(result).toEqual('Ancho de la base');
-
-        result = await page
-            .waitToGetProperty(selectors.itemTags.fourthValue, 'value');
-
-        expect(result).toEqual('50');
-
-        result = await page
-            .waitToGetProperty(selectors.itemTags.fourthRelevancy, 'value');
-
-        expect(result).toEqual('4');
-    });
-
-    it('should confirm the fifth row data is the expected one', async() => {
-        let tag = await page
-            .waitToGetProperty(selectors.itemTags.fifthTag, 'value');
-
-        let value = await page
-            .waitToGetProperty(selectors.itemTags.fifthValue, 'value');
-
-        let relevancy = await page
-            .waitToGetProperty(selectors.itemTags.fifthRelevancy, 'value');
-
-        expect(tag).toEqual('Color');
-        expect(value).toEqual('Brown');
-        expect(relevancy).toEqual('5');
-    });
-
-    it('should confirm the sixth row data is the expected one', async() => {
-        let tag = await page
-            .waitToGetProperty(selectors.itemTags.sixthTag, 'value');
-
-        let value = await page
-            .waitToGetProperty(selectors.itemTags.sixthValue, 'value');
-
-        let relevancy = await page
-            .waitToGetProperty(selectors.itemTags.sixthRelevancy, 'value');
-
-        expect(tag).toEqual('Categoria');
-        expect(value).toEqual('+1 precission');
-        expect(relevancy).toEqual('6');
-    });
-});

e2e/paths/04-item/05_botanical.spec.js

@@ -1,66 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Item Create botanical path', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('buyer', 'item');
-        await page.accessToSearchResult('Ranged weapon pistol 9mm');
-        await page.accessToSection('item.card.botanical');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it(`should create a new botanical for the item`, async() => {
-        await page.autocompleteSearch(selectors.itemBotanical.genus, 'Abelia');
-        await page.autocompleteSearch(selectors.itemBotanical.species, 'dealbata');
-        await page.waitToClick(selectors.itemBotanical.submitBotanicalButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should confirm the Genus for the item was created`, async() => {
-        await page.waitForTextInField(selectors.itemBotanical.genus, 'Abelia');
-        const result = await page
-            .waitToGetProperty(selectors.itemBotanical.genus, 'value');
-
-        expect(result).toEqual('Abelia');
-    });
-
-    it(`should confirm the Species for the item was created`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.itemBotanical.species, 'value');
-
-        expect(result).toEqual('dealbata');
-    });
-
-    it(`should edit botanical for the item`, async() => {
-        await page.autocompleteSearch(selectors.itemBotanical.genus, 'Abies');
-        await page.autocompleteSearch(selectors.itemBotanical.species, 'decurrens');
-        await page.waitToClick(selectors.itemBotanical.submitBotanicalButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should confirm the Genus for the item was edited`, async() => {
-        await page.waitForTextInField(selectors.itemBotanical.genus, 'Abies');
-        const result = await page
-            .waitToGetProperty(selectors.itemBotanical.genus, 'value');
-
-        expect(result).toEqual('Abies');
-    });
-
-    it(`should confirm the Species for the item was edited`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.itemBotanical.species, 'value');
-
-        expect(result).toEqual('decurrens');
-    });
-});

e2e/paths/04-item/06_barcode.spec.js

@@ -1,37 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Item Create barcodes path', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('buyer', 'item');
-        await page.accessToSearchResult('Ranged weapon longbow 200cm');
-        await page.accessToSection('item.card.itemBarcode');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it(`should click create a new code and delete a former one`, async() => {
-        await page.waitToClick(selectors.itemBarcodes.firstCodeRemoveButton);
-        await page.waitToClick(selectors.itemBarcodes.addBarcodeButton);
-        await page.write(selectors.itemBarcodes.thirdCode, '5');
-        await page.waitToClick(selectors.itemBarcodes.submitBarcodesButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should confirm the barcode 5 is created and it is now the third barcode as the first was deleted`, async() => {
-        await page.reloadSection('item.card.itemBarcode');
-        await page.waitForTextInField(selectors.itemBarcodes.thirdCode, '5');
-        const result = await page
-            .waitToGetProperty(selectors.itemBarcodes.thirdCode, 'value');
-
-        expect(result).toEqual('5');
-    });
-});

e2e/paths/04-item/07_create.spec.js

@@ -1,65 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-const $ = {
-    form: 'vn-item-create form'
-};
-
-describe('Item Create', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('buyer', 'item');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should access to the create item view by clicking the create floating button', async() => {
-        await page.waitToClick(selectors.itemsIndex.createItemButton);
-        await page.waitForState('item.create');
-    });
-
-    it('should return to the item index by clickig the cancel button', async() => {
-        await page.waitToClick(selectors.itemCreateView.cancelButton);
-        await page.waitForState('item.index');
-    });
-
-    it('should now access to the create item view by clicking the create floating button', async() => {
-        await page.waitToClick(selectors.itemsIndex.createItemButton);
-        await page.waitForState('item.create');
-    });
-
-    it('should throw an error when insert an invalid priority', async() => {
-        const values = {
-            name: 'Infinity Gauntlet',
-            type: 'Crisantemo',
-            intrastat: 'Coral y materiales similares',
-            origin: 'Holand',
-            priority: null
-        };
-        const message = await page.sendForm($.form, values);
-
-        expect(message.text).toContain('Valid priorities');
-    });
-
-    it('should create the Infinity Gauntlet item', async() => {
-        const values = {
-            name: 'Infinity Gauntlet',
-            type: 'Crisantemo',
-            intrastat: 'Coral y materiales similares',
-            origin: 'Holand',
-            priority: '2'
-        };
-
-        await page.fillForm($.form, values);
-        const formValues = await page.fetchForm($.form, Object.keys(values));
-        const message = await page.sendForm($.form);
-
-        expect(message.isSuccess).toBeTrue();
-        expect(formValues).toEqual(values);
-    });
-});

e2e/paths/04-item/08_regularize.spec.js

@@ -1,141 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Item regularize path', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('employee', 'item');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should edit the user local warehouse', async() => {
-        await page.waitForSpinnerLoad();
-        await page.waitToClick(selectors.globalItems.userMenuButton);
-        await page.autocompleteSearch(selectors.globalItems.userLocalWarehouse, 'Warehouse Four');
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should check the local settings were saved', async() => {
-        const userLocalWarehouse = await page
-            .waitToGetProperty(selectors.globalItems.userLocalWarehouse, 'value');
-
-        await page.closePopup();
-
-        expect(userLocalWarehouse).toContain('Warehouse Four');
-    });
-
-    it('should search for a specific item', async() => {
-        await page.accessToSearchResult('Ranged weapon pistol 9mm');
-        await page.waitForState('item.card.summary');
-    });
-
-    it('should open the regularize dialog and check the warehouse matches the local user settings', async() => {
-        await page.waitToClick(selectors.itemDescriptor.moreMenu);
-        await page.waitToClick(selectors.itemDescriptor.moreMenuRegularizeButton);
-        const result = await page.waitToGetProperty(selectors.itemDescriptor.regularizeWarehouse, 'value');
-
-        expect(result).toEqual('Warehouse Four');
-    });
-
-    it('should regularize the item', async() => {
-        await page.write(selectors.itemDescriptor.regularizeQuantity, '100');
-        await page.autocompleteSearch(selectors.itemDescriptor.regularizeWarehouse, 'Warehouse One');
-        await page.waitToClick(selectors.itemDescriptor.regularizeSaveButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should click on the Tickets button of the top bar menu', async() => {
-        await page.waitToClick(selectors.globalItems.applicationsMenuButton);
-        await page.waitForSelector(selectors.globalItems.applicationsMenuVisible);
-        await Promise.all([
-            page.waitForNavigation({waitUntil: ['load', 'networkidle0', 'domcontentloaded']}),
-            page.waitToClick(selectors.globalItems.ticketsButton)
-        ]);
-        await page.waitForState('ticket.index');
-    });
-
-    it('should clear the user local settings now', async() => {
-        await page.waitToClick(selectors.globalItems.userMenuButton);
-        await page.waitForContentLoaded();
-        await page.clearInput(selectors.globalItems.userConfigFirstAutocomplete);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should search for the ticket with alias missing', async() => {
-        await page.keyboard.press('Escape');
-        await page.accessToSearchResult('missing');
-        await page.waitForState('ticket.card.summary');
-    });
-
-    it(`should check the ticket sale quantity is showing a negative value`, async() => {
-        await page.waitForTextInElement(selectors.ticketSummary.firstSaleQuantity, '-100');
-        const result = await page
-            .waitToGetProperty(selectors.ticketSummary.firstSaleQuantity, 'innerText');
-
-        expect(result).toContain('-100');
-    });
-
-    it(`should check the ticket sale discount is 100%`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.ticketSummary.firstSaleDiscount, 'innerText');
-
-        expect(result).toContain('100 %');
-    });
-
-    it('should now click on the Items button of the top bar menu', async() => {
-        await page.waitToClick(selectors.globalItems.applicationsMenuButton);
-        await page.waitForSelector(selectors.globalItems.applicationsMenuVisible);
-        await page.waitToClick(selectors.globalItems.itemsButton);
-        await page.waitForState('item.index');
-    });
-
-    it('should search for the item once again', async() => {
-        await page.accessToSearchResult('Ranged weapon pistol 9mm');
-        await page.waitForState('item.card.summary');
-    });
-
-    it('should regularize the item once more', async() => {
-        await page.waitToClick(selectors.itemDescriptor.moreMenu);
-        await page.waitToClick(selectors.itemDescriptor.moreMenuRegularizeButton);
-        await page.write(selectors.itemDescriptor.regularizeQuantity, '100');
-        await page.autocompleteSearch(selectors.itemDescriptor.regularizeWarehouse, 'Warehouse One');
-        await page.waitToClick(selectors.itemDescriptor.regularizeSaveButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should again click on the Tickets button of the top bar menu', async() => {
-        await page.waitToClick(selectors.globalItems.applicationsMenuButton);
-        await page.waitForSelector(selectors.globalItems.applicationsMenuVisible);
-        await Promise.all([
-            page.waitForNavigation({waitUntil: ['load', 'networkidle0', 'domcontentloaded']}),
-            page.waitToClick(selectors.globalItems.ticketsButton)
-        ]);
-        await page.waitForState('ticket.index');
-    });
-
-    it('should search for the ticket missing once again', async() => {
-        await page.accessToSearchResult('Missing');
-        await page.waitForState('ticket.card.summary');
-    });
-
-    it(`should check the ticket contains now two sales`, async() => {
-        await page.waitForTextInElement(selectors.ticketSummary.firstSaleQuantity, '-100');
-        const result = await page.countElement(selectors.ticketSummary.sale);
-
-        expect(result).toEqual(2);
-    });
-});

e2e/paths/04-item/09_index.spec.js

@@ -1,84 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Item index path', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('salesPerson', 'item');
-        await page.waitToClick(selectors.globalItems.searchButton);
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should click on the fields to show button to open the list of columns to show', async() => {
-        await page.waitToClick(selectors.itemsIndex.shownColumns);
-        const visible = await page.isVisible(selectors.itemsIndex.shownColumnsList);
-
-        expect(visible).toBeTruthy();
-    });
-
-    it('should unmark all checkboxes except the first and the last ones', async() => {
-        await page.waitToClick(selectors.itemsIndex.idCheckbox);
-        await page.waitToClick(selectors.itemsIndex.stemsCheckbox);
-        await page.waitToClick(selectors.itemsIndex.sizeCheckbox);
-        await page.waitToClick(selectors.itemsIndex.typeCheckbox);
-        await page.waitToClick(selectors.itemsIndex.categoryCheckbox);
-        await page.waitToClick(selectors.itemsIndex.intrastadCheckbox);
-        await page.waitToClick(selectors.itemsIndex.originCheckbox);
-        await page.waitToClick(selectors.itemsIndex.buyerCheckbox);
-        await page.waitToClick(selectors.itemsIndex.weightByPieceCheckbox);
-        await page.waitToClick(selectors.itemsIndex.saveFieldsButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should navigate forth and back to see the images column is still visible', async() => {
-        await page.closePopup();
-        await page.waitToClick(selectors.itemsIndex.firstSearchResult);
-        await page.waitToClick(selectors.itemDescriptor.goBackToModuleIndexButton);
-        await page.waitToClick(selectors.globalItems.searchButton);
-        await page.waitForSelector(selectors.itemsIndex.searchResult);
-        await page.waitImgLoad(selectors.itemsIndex.firstItemImage);
-        const imageVisible = await page.isVisible(selectors.itemsIndex.firstItemImageTd);
-
-        expect(imageVisible).toBeTruthy();
-    });
-
-    it('should check the ids column is not visible', async() => {
-        await page.waitForSelector(selectors.itemsIndex.firstItemId, {hidden: true});
-    });
-
-    it('should mark all unchecked boxes to leave the index as it was', async() => {
-        await page.waitToClick(selectors.itemsIndex.shownColumns);
-        await page.waitToClick(selectors.itemsIndex.idCheckbox);
-        await page.waitToClick(selectors.itemsIndex.stemsCheckbox);
-        await page.waitToClick(selectors.itemsIndex.sizeCheckbox);
-        await page.waitToClick(selectors.itemsIndex.typeCheckbox);
-        await page.waitToClick(selectors.itemsIndex.categoryCheckbox);
-        await page.waitToClick(selectors.itemsIndex.intrastadCheckbox);
-        await page.waitToClick(selectors.itemsIndex.originCheckbox);
-        await page.waitToClick(selectors.itemsIndex.buyerCheckbox);
-        await page.waitToClick(selectors.itemsIndex.weightByPieceCheckbox);
-        await page.waitToClick(selectors.itemsIndex.saveFieldsButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should now navigate forth and back to see the ids column is now visible', async() => {
-        await page.closePopup();
-        await page.waitToClick(selectors.itemsIndex.firstSearchResult);
-        await page.waitToClick(selectors.itemDescriptor.goBackToModuleIndexButton);
-        await page.waitToClick(selectors.globalItems.searchButton);
-        await page.waitForSelector(selectors.itemsIndex.searchResult);
-        const idVisible = await page.isVisible(selectors.itemsIndex.firstItemId);
-
-        expect(idVisible).toBeTruthy();
-    });
-});

e2e/paths/04-item/10_item_log.spec.js

@@ -1,45 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Item log path', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('developer', 'item');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it(`should search for the Knowledge artifact to confirm it isn't created yet`, async() => {
-        await page.doSearch('Knowledge artifact');
-        const nResults = await page.countElement(selectors.itemsIndex.searchResult);
-
-        expect(nResults).toEqual(1);
-    });
-
-    it('should access to the create item view by clicking the create floating button', async() => {
-        await page.waitToClick(selectors.itemsIndex.createItemButton);
-        await page.waitForState('item.create');
-    });
-
-    it('should create the Knowledge artifact item', async() => {
-        await page.write(selectors.itemCreateView.temporalName, 'Knowledge artifact');
-        await page.autocompleteSearch(selectors.itemCreateView.type, 'Crisantemo');
-        await page.autocompleteSearch(selectors.itemCreateView.intrastat, 'Coral y materiales similares');
-        await page.autocompleteSearch(selectors.itemCreateView.origin, 'Holand');
-        await page.waitToClick(selectors.itemCreateView.createButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should return to the items index by clicking the return to items button', async() => {
-        await page.waitToClick(selectors.itemBasicData.goToItemIndexButton);
-        await page.waitForSelector(selectors.itemsIndex.createItemButton);
-        await page.waitForState('item.index');
-    });
-});

e2e/paths/04-item/11_descriptor.spec.js

@@ -1,41 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Item descriptor path', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('buyer', 'item');
-        await page.accessToSearchResult('1');
-        await page.accessToSection('item.card.basicData');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should set the item to inactive', async() => {
-        await page.waitToClick(selectors.itemBasicData.isActiveCheckbox);
-        await page.waitToClick(selectors.itemBasicData.submitBasicDataButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should reload the section and check the inactive icon is visible', async() => {
-        await page.reloadSection('item.card.basicData');
-        const visibleIcon = await page.isVisible(selectors.itemDescriptor.inactiveIcon);
-
-        expect(visibleIcon).toBeTruthy();
-    });
-
-    it('should set the item back to active', async() => {
-        await page.waitToClick(selectors.itemBasicData.isActiveCheckbox);
-        await page.waitToClick(selectors.itemBasicData.submitBasicDataButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-});

e2e/paths/04-item/12_request.spec.js

@@ -1,45 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Item request path', () => {
-    let browser;
-    let page;
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('buyer', 'item');
-        await page.accessToSection('item.request');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should reach the item request section', async() => {
-        await page.waitForState('item.request');
-    });
-
-    it('should fill the id and quantity then check the concept was updated', async() => {
-        await page.writeOnEditableTD(selectors.itemRequest.firstRequestItemID, '4');
-        await page.writeOnEditableTD(selectors.itemRequest.firstRequestQuantity, '10');
-        await page.waitForTextInElement(selectors.itemRequest.firstRequestConcept, 'Melee weapon heavy shield 100cm');
-        let filledConcept = await page.waitToGetProperty(selectors.itemRequest.firstRequestConcept, 'innerText');
-
-        expect(filledConcept).toContain('Melee weapon heavy shield 100cm');
-    });
-
-    it('should check the status of the request should now be accepted', async() => {
-        let status = await page.waitToGetProperty(selectors.itemRequest.firstRequestStatus, 'innerText');
-
-        expect(status).toContain('Accepted');
-    });
-
-    it('should now click on the second declain request icon then type the reason', async() => {
-        await page.waitToClick(selectors.itemRequest.secondRequestDecline);
-        await page.write(selectors.itemRequest.declineReason, 'Not quite as expected');
-        await page.respondToDialog('accept');
-        let status = await page.waitToGetProperty(selectors.itemRequest.secondRequestStatus, 'innerText');
-
-        expect(status).toContain('Denied');
-    });
-});

e2e/paths/04-item/13_fixedPrice.spec.js

@@ -1,97 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-const $ = selectors.itemFixedPrice;
-
-describe('Item fixed prices path', () => {
-    let browser;
-    let page;
-    let httpRequest;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('buyer', 'item');
-        await page.accessToSection('item.fixedPrice');
-        page.on('request', req => {
-            if (req.url().includes(`FixedPrices/filter`))
-                httpRequest = req.url();
-        });
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should filter using all the fields', async() => {
-        await page.write($.generalSearchFilter, 'item');
-        await page.keyboard.press('Enter');
-
-        expect(httpRequest).toContain('search=item');
-
-        await page.click($.chip);
-        await page.click($.reignFilter);
-
-        expect(httpRequest).toContain('categoryFk');
-
-        await page.autocompleteSearch($.typeFilter, 'Alstroemeria');
-
-        expect(httpRequest).toContain('typeFk');
-
-        await page.click($.chip);
-        await page.autocompleteSearch($.buyerFilter, 'buyerNick');
-
-        expect(httpRequest).toContain('buyerFk');
-
-        await page.click($.chip);
-        await page.autocompleteSearch($.warehouseFilter, 'Algemesi');
-
-        expect(httpRequest).toContain('warehouseFk');
-
-        await page.click($.chip);
-        await page.click($.mineFilter);
-
-        expect(httpRequest).toContain('mine=true');
-
-        await page.click($.chip);
-        await page.click($.hasMinPriceFilter);
-
-        expect(httpRequest).toContain('hasMinPrice=true');
-
-        await page.click($.chip);
-        await page.click($.addTag);
-        await page.autocompleteSearch($.tagFilter, 'Color');
-        await page.autocompleteSearch($.tagValueFilter, 'Brown');
-
-        expect(httpRequest).toContain('tags');
-
-        await page.click($.chip);
-    });
-
-    it('should click on the add new fixed price button', async() => {
-        await page.waitToClick($.add);
-        await page.waitForSelector($.fourthFixedPrice);
-    });
-
-    it('should fill the fixed price data', async() => {
-        const now = Date.vnNew();
-        await page.autocompleteSearch($.fourthWarehouse, 'Warehouse one');
-        await page.writeOnEditableTD($.fourthGroupingPrice, '1');
-        await page.writeOnEditableTD($.fourthPackingPrice, '1');
-        await page.write($.fourthMinPrice, '1');
-        await page.pickDate($.fourthStarted, now);
-        await page.pickDate($.fourthEnded, now);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should reload the section and check the created price has the expected ID', async() => {
-        await page.goto(`http://localhost:5000/#!/item/fixed-price`);
-        await page.autocompleteSearch($.warehouseFilter, 'Warehouse one');
-        await page.click($.chip);
-        const result = await page.waitToGetProperty($.fourthItemID, 'value');
-
-        expect(result).toContain('13');
-    });
-});

e2e/paths/05-ticket/01-sale/01_list_sales.spec.js

@@ -1,99 +0,0 @@
-import selectors from '../../../helpers/selectors.js';
-import getBrowser from '../../../helpers/puppeteer';
-
-describe('Ticket List sale path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('employee', 'ticket');
-        await page.accessToSearchResult('13');
-        await page.accessToSection('ticket.card.sale');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should confirm the first ticket sale contains the colour tag', async() => {
-        const value = await page
-            .waitToGetProperty(selectors.ticketSales.firstSaleColour, 'innerText');
-
-        expect(value).toContain('Black');
-    });
-
-    it('should confirm the first sale contains the price', async() => {
-        const value = await page
-            .waitToGetProperty(selectors.ticketSales.firstSalePrice, 'innerText');
-
-        expect(value).toContain('1.72');
-    });
-
-    it('should confirm the first sale contains the discount', async() => {
-        const value = await page
-            .waitToGetProperty(selectors.ticketSales.firstSaleDiscount, 'innerText');
-
-        expect(value).toContain('0.00%');
-    });
-
-    it('should confirm the first sale contains the total import', async() => {
-        const value = await page
-            .waitToGetProperty(selectors.ticketSales.firstSaleImport, 'innerText');
-
-        expect(value).toContain('34.40');
-    });
-
-    it('should add an empty item to the sale list', async() => {
-        await page.waitToClick(selectors.ticketSales.newItemButton);
-        const sales = await page
-            .countElement(selectors.ticketSales.saleLine);
-
-        expect(sales).toEqual(2);
-    });
-
-    it('should select a valid item to be added as the second item in the sales list', async() => {
-        let searchValue = 'Melee weapon heavy shield 100cm';
-        await page.autocompleteSearch(selectors.ticketSales.secondSaleIdAutocomplete, searchValue);
-        await page.waitToClick(selectors.ticketSales.secondSaleQuantityCell);
-        await page.type(selectors.ticketSales.secondSaleQuantity, '8');
-        await page.keyboard.press('Enter');
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should update the description of the new sale', async() => {
-        await page.click(selectors.ticketSales.secondSaleConceptCell);
-        await page.write(selectors.ticketSales.secondSaleConceptInput, 'Aegis of Valor');
-        await page.keyboard.press('Enter');
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should add a third empty item to the sale list', async() => {
-        await page.waitToClick(selectors.ticketSales.newItemButton);
-        await page.waitForNumberOfElements(selectors.ticketSales.saleLine, 3);
-        const sales = await page.countElement(selectors.ticketSales.saleLine);
-
-        expect(sales).toEqual(3);
-    });
-
-    it('should select the 2nd and 3th item and delete both', async() => {
-        await page.waitToClick(selectors.ticketSales.secondSaleCheckbox);
-        await page.waitToClick(selectors.ticketSales.thirdSaleCheckbox);
-        await page.waitToClick(selectors.ticketSales.deleteSaleButton);
-        await page.waitToClick(selectors.globalItems.acceptButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should verify there's only 1 single line remaining`, async() => {
-        const sales = await page.countElement(selectors.ticketSales.saleLine);
-
-        expect(sales).toEqual(1);
-    });
-});

e2e/paths/05-ticket/01-sale/02_edit_sale.spec.js

@@ -1,415 +0,0 @@
-import selectors from '../../../helpers/selectors.js';
-import getBrowser from '../../../helpers/puppeteer';
-
-describe('Ticket Edit sale path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('salesPerson', 'ticket');
-        await page.accessToSearchResult('16');
-        await page.accessToSection('ticket.card.sale');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it(`should click on the first sale claim icon to navigate over there`, async() => {
-        await page.waitToClick(selectors.ticketSales.firstSaleClaimIcon);
-        await page.waitForNavigation();
-        await page.goBack();
-        await page.goBack();
-    });
-
-    it('should navigate to the tickets index', async() => {
-        await page.waitToClick(selectors.globalItems.applicationsMenuButton);
-        await page.waitForSelector(selectors.globalItems.applicationsMenuVisible);
-        await page.waitToClick(selectors.globalItems.ticketsButton);
-        await page.waitForState('ticket.index');
-    });
-
-    it(`should search for a ticket and then navigate to it's sales`, async() => {
-        await page.accessToSearchResult('16');
-        await page.accessToSection('ticket.card.sale');
-    });
-
-    it(`should set the ticket as libre`, async() => {
-        const searchValue = 'libre';
-        await page.waitToClick(selectors.ticketSales.stateMenuButton);
-        await page.write(selectors.ticketSales.moreMenuState, searchValue);
-        try {
-            await page.waitForFunction(searchValue => {
-                const element = document.querySelector('li.active');
-                if (element)
-                    return element.innerText.toLowerCase().includes(searchValue.toLowerCase());
-            }, {}, searchValue);
-        } catch (error) {
-            const builtSelector = await page.selectorFormater(selectors.ticketSales.moreMenuState);
-            const inputValue = await page.evaluate(() => {
-                return document.querySelector('.vn-drop-down.shown vn-textfield input').value;
-            });
-            throw new Error(`${builtSelector} value is ${inputValue}! ${error}`);
-        }
-        await page.waitForState('ticket.card.sale');
-        await page.keyboard.press('Enter');
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should check it's state is libre now`, async() => {
-        await page.waitForTextInElement(selectors.ticketDescriptor.stateLabelValue, 'Libre');
-        const result = await page.waitToGetProperty(selectors.ticketDescriptor.stateLabelValue, 'innerText');
-
-        expect(result).toEqual('State Libre');
-    });
-
-    it(`should set the ticket as OK`, async() => {
-        await page.waitToClick(selectors.ticketSales.setOk);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should check it's state is OK now`, async() => {
-        await page.waitForTextInElement(selectors.ticketDescriptor.stateLabelValue, 'OK');
-        const result = await page.waitToGetProperty(selectors.ticketDescriptor.stateLabelValue, 'innerText');
-
-        expect(result).toEqual('State OK');
-    });
-
-    it(`should check the zoomed image isn't present`, async() => {
-        const result = await page.countElement(selectors.ticketSales.firstSaleZoomedImage);
-
-        expect(result).toEqual(0);
-    });
-
-    it(`should click on the thumbnail image of the 1st sale and see the zoomed image`, async() => {
-        await page.waitToClick(selectors.ticketSales.firstSaleThumbnailImage);
-        const result = await page.countElement(selectors.ticketSales.firstSaleZoomedImage);
-
-        expect(result).toEqual(1);
-    });
-
-    it(`should click on the zoomed image to close it`, async() => {
-        await page.waitToClick(selectors.ticketSales.firstSaleZoomedImage);
-        const result = await page.countElement(selectors.ticketSales.firstSaleZoomedImage);
-
-        expect(result).toEqual(0);
-    });
-
-    it(`should click on the first sale ID making now the item descriptor visible`, async() => {
-        await page.waitToClick(selectors.ticketSales.firstSaleId);
-        await page.waitImgLoad(selectors.ticketSales.firstSaleDescriptorImage);
-        const visible = await page.isVisible(selectors.ticketSales.saleDescriptorPopover);
-
-        expect(visible).toBeTruthy();
-    });
-
-    it(`should click on the descriptor image of the 1st sale and see the zoomed image`, async() => {
-        await page.waitToClick('vn-item-descriptor img');
-        const result = await page.countElement(selectors.ticketSales.firstSaleZoomedImage);
-
-        expect(result).toEqual(1);
-    });
-
-    it(`should now click on the zoomed image to close it`, async() => {
-        await page.waitToClick(selectors.ticketSales.firstSaleZoomedImage);
-        const result = await page.countElement(selectors.ticketSales.firstSaleZoomedImage);
-
-        expect(result).toEqual(0);
-    });
-
-    it(`should click on the summary icon of the item-descriptor to access to the item summary`, async() => {
-        await page.waitToClick(selectors.ticketSales.saleDescriptorPopoverSummaryButton);
-        await page.waitForState('item.card.summary');
-    });
-
-    it('should return to ticket sales section', async() => {
-        await page.waitToClick(selectors.globalItems.applicationsMenuButton);
-        await page.waitForSelector(selectors.globalItems.applicationsMenuVisible);
-        await page.waitToClick(selectors.globalItems.ticketsButton);
-        await page.accessToSearchResult('16');
-        await page.accessToSection('ticket.card.sale');
-    });
-
-    it('should remove 1 from the first sale quantity', async() => {
-        await page.waitToClick(selectors.ticketSales.firstSaleQuantityCell);
-        await page.waitForSelector(selectors.ticketSales.firstSaleQuantity);
-        await page.type(selectors.ticketSales.firstSaleQuantity, '9\u000d');
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should update the price', async() => {
-        await page.waitToClick(selectors.ticketSales.firstSalePrice);
-        await page.waitForSelector(selectors.ticketSales.firstSalePriceInput);
-        await page.type(selectors.ticketSales.firstSalePriceInput, '5\u000d');
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should confirm the price have been updated', async() => {
-        const result = await page.waitToGetProperty(selectors.ticketSales.firstSalePrice, 'innerText');
-
-        expect(result).toContain('5.00');
-    });
-
-    it('should confirm the total price for that item have been updated', async() => {
-        const result = await page.waitToGetProperty(selectors.ticketSales.firstSaleImport, 'innerText');
-
-        expect(result).toContain('45.00');
-    });
-
-    it('should update the discount', async() => {
-        await page.waitToClick(selectors.ticketSales.firstSaleDiscount);
-        await page.waitForSelector(selectors.ticketSales.firstSaleDiscountInput);
-        await page.type(selectors.ticketSales.firstSaleDiscountInput, '50');
-        await page.waitToClick(selectors.ticketSales.saveSaleDiscountButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should confirm the discount have been updated', async() => {
-        await page.waitForTextInElement(selectors.ticketSales.firstSaleDiscount, '50.00%');
-        const result = await page.waitToGetProperty(selectors.ticketSales.firstSaleDiscount, 'innerText');
-
-        expect(result).toContain('50.00%');
-    });
-
-    it('should confirm the total import for that item have been updated', async() => {
-        await page.waitForTextInElement(selectors.ticketSales.firstSaleImport, '22.50');
-        const result = await page.waitToGetProperty(selectors.ticketSales.firstSaleImport, 'innerText');
-
-        expect(result).toContain('22.50');
-    });
-
-    it('should recalculate price of sales', async() => {
-        await page.waitToClick(selectors.ticketSales.firstSaleCheckbox);
-        await page.waitToClick(selectors.ticketSales.secondSaleCheckbox);
-
-        await page.waitToClick(selectors.ticketSales.moreMenu);
-        await page.waitToClick(selectors.ticketSales.moreMenuRecalculatePrice);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should log in as salesAssistant and navigate to ticket sales', async() => {
-        await page.loginAndModule('salesAssistant', 'ticket');
-        await page.accessToSearchResult('15');
-        await page.accessToSection('ticket.card.sale');
-    });
-
-    it('should select the first sale and create a refund with warehouse', async() => {
-        await page.waitToClick(selectors.ticketSales.firstSaleCheckbox);
-        await page.waitToClick(selectors.ticketSales.moreMenu);
-        await page.waitToClick(selectors.ticketSales.moreMenuRefund);
-        await page.waitToClick(selectors.ticketSales.refundWithWarehouse);
-        await page.waitForSnackbar();
-        await page.waitForState('ticket.card.sale');
-    });
-
-    it('should select the first sale and create a refund without warehouse', async() => {
-        await page.accessToSearchResult('18');
-        await page.waitToClick(selectors.ticketSales.firstSaleCheckbox);
-        await page.waitToClick(selectors.ticketSales.moreMenu);
-        await page.waitToClick(selectors.ticketSales.moreMenuRefund);
-        await page.waitToClick(selectors.ticketSales.refundWithoutWarehouse);
-        await page.waitForSnackbar();
-        await page.waitForState('ticket.card.sale');
-    });
-
-    it('should show error trying to delete a ticket with a refund', async() => {
-        await page.loginAndModule('salesPerson', 'ticket');
-        await page.accessToSearchResult('8');
-        await page.waitToClick(selectors.ticketDescriptor.moreMenu);
-        await page.waitToClick(selectors.ticketDescriptor.moreMenuDeleteTicket);
-        await page.waitToClick(selectors.globalItems.acceptButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Tickets with associated refunds can\'t be deleted');
-        await page.waitToClick(selectors.globalItems.cancelButton);
-    });
-
-    it('should select the third sale and create a claim of it', async() => {
-        await page.accessToSearchResult('16');
-        await page.accessToSection('ticket.card.sale');
-        await page.waitToClick(selectors.ticketSales.thirdSaleCheckbox);
-        await page.waitToClick(selectors.ticketSales.moreMenu);
-        await page.waitToClick(selectors.ticketSales.moreMenuCreateClaim);
-        await page.waitToClick(selectors.globalItems.acceptButton);
-        await page.waitForNavigation();
-    });
-
-    it('should search for a ticket then access to the sales section', async() => {
-        await page.goBack();
-        await page.goBack();
-        await page.loginAndModule('salesPerson', 'ticket');
-        await page.accessToSearchResult('16');
-        await page.accessToSection('ticket.card.sale');
-    });
-
-    it('should select the third sale and delete it', async() => {
-        await page.waitToClick(selectors.ticketSales.thirdSaleCheckbox);
-        await page.waitToClick(selectors.ticketSales.deleteSaleButton);
-        await page.waitToClick(selectors.globalItems.acceptButton);
-        await page.waitForSpinnerLoad();
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should confirm the third sale was deleted`, async() => {
-        const result = await page.countElement(selectors.ticketSales.saleLine);
-
-        expect(result).toEqual(3);
-    });
-
-    it('should select the second sale and transfer it to a valid ticket', async() => {
-        const targetTicketId = '12';
-
-        await page.waitToClick(selectors.ticketSales.secondSaleCheckbox);
-        await page.waitToClick(selectors.ticketSales.transferSaleButton);
-        await page.waitToClick(selectors.ticketSales.transferQuantityCell);
-        await page.type(selectors.ticketSales.transferQuantityInput, '10\u000d');
-        await page.type(selectors.ticketSales.moveToTicketInput, targetTicketId);
-        await page.waitToClick(selectors.ticketSales.moveToTicketButton);
-        await page.expectURL(`ticket/${targetTicketId}/sale`);
-    });
-
-    it('should confirm the transfered line is the correct one', async() => {
-        await page.waitForSelector(selectors.ticketSales.secondSaleText);
-        const result = await page.waitToGetProperty(selectors.ticketSales.secondSaleText, 'innerText');
-
-        expect(result).toContain(`Melee weapon heavy shield`);
-    });
-
-    it('should confirm the transfered quantity is the correct one', async() => {
-        const result = await page.waitToGetProperty(selectors.ticketSales.firstSaleQuantityCell, 'innerText');
-
-        expect(result).toContain('20');
-    });
-
-    it('should go back to the original ticket sales section', async() => {
-        await page.waitToClick(selectors.ticketDescriptor.goBackToModuleIndexButton);
-        await page.accessToSearchResult('16');
-        await page.accessToSection('ticket.card.sale');
-    });
-
-    it(`should confirm the original ticket has still three lines`, async() => {
-        await page.waitForSelector(selectors.ticketSales.saleLine);
-        const result = await page.countElement(selectors.ticketSales.saleLine);
-
-        expect(result).toEqual(3);
-    });
-
-    it(`should confirm the second sale quantity is now half of it's original value after the transfer`, async() => {
-        const result = await page.waitToGetProperty(selectors.ticketSales.secondSaleQuantityCell, 'innerText');
-
-        expect(result).toContain('10');
-    });
-
-    it('should go back to the receiver ticket sales section', async() => {
-        await page.waitToClick(selectors.ticketDescriptor.goBackToModuleIndexButton);
-        await page.accessToSearchResult('12');
-        await page.accessToSection('ticket.card.sale');
-    });
-
-    it('should transfer the sale back to the original ticket', async() => {
-        const targetTicketId = '16';
-
-        await page.waitToClick(selectors.ticketSales.secondSaleCheckbox);
-        await page.waitToClick(selectors.ticketSales.transferSaleButton);
-        await page.type(selectors.ticketSales.moveToTicketInput, targetTicketId);
-        await page.waitToClick(selectors.ticketSales.moveToTicketButton);
-        await page.expectURL(`ticket/${targetTicketId}/sale`);
-    });
-
-    it('should confirm the original ticket received the line', async() => {
-        const expectedLines = 4;
-        await page.waitForNumberOfElements(selectors.ticketSales.saleLine, expectedLines);
-        const result = await page.countElement(selectors.ticketSales.saleLine);
-
-        expect(result).toEqual(expectedLines);
-    });
-
-    it(`should throw an error when attempting to create a ticket for an inactive client`, async() => {
-        await page.waitToClick(selectors.ticketSales.firstSaleCheckbox);
-        await page.waitToClick(selectors.ticketSales.transferSaleButton);
-        await page.waitToClick(selectors.ticketSales.moveToNewTicketButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain(`You can't create a ticket for an inactive client`);
-
-        await page.closePopup();
-    });
-
-    it('should go now to the ticket sales section of an active, not frozen client', async() => {
-        await page.waitToClick(selectors.ticketDescriptor.goBackToModuleIndexButton);
-        await page.accessToSearchResult('13');
-        await page.accessToSection('ticket.card.sale');
-    });
-
-    it(`should select all sales, tranfer them to a new ticket and delete the sender ticket as it would've been left empty`, async() => {
-        const senderTicketId = '13';
-
-        await page.waitToClick(selectors.ticketSales.selectAllSalesCheckbox);
-        await page.waitToClick(selectors.ticketSales.transferSaleButton);
-        await page.waitToClick(selectors.ticketSales.moveToNewTicketButton);
-        await page.evaluate((selector, ticketId) => {
-            return document.querySelector(selector).innerText.toLowerCase().indexOf(`#${ticketId}`) == -1;
-        }, selectors.ticketDescriptor.id, senderTicketId);
-        await page.waitForState('ticket.card.sale');
-    });
-
-    it('should confirm the new ticket received the line', async() => {
-        const expectedLines = 1;
-        const result = await page.countElement(selectors.ticketSales.saleLine);
-
-        expect(result).toEqual(expectedLines);
-    });
-
-    it('should check the first sale reserved icon isnt visible', async() => {
-        const result = await page.isVisible(selectors.ticketSales.firstSaleReservedIcon);
-
-        expect(result).toBeFalsy();
-    });
-
-    it('should mark the first sale as reserved', async() => {
-        await page.waitToClick(selectors.ticketSales.firstSaleCheckbox);
-
-        await page.waitToClick(selectors.ticketSales.moreMenu);
-        await page.waitToClick(selectors.ticketSales.moreMenuReserve);
-        await page.closePopup();
-        await page.waitForClassNotPresent(selectors.ticketSales.firstSaleReservedIcon, 'ng-hide');
-        const result = await page.isVisible(selectors.ticketSales.firstSaleReservedIcon);
-
-        expect(result).toBeTruthy();
-    });
-
-    it('should unmark the first sale as reserved', async() => {
-        await page.waitToClick(selectors.ticketSales.moreMenu);
-        await page.waitToClick(selectors.ticketSales.moreMenuUnmarkReseved);
-        await page.waitForClassPresent(selectors.ticketSales.firstSaleReservedIcon, 'ng-hide');
-        const result = await page.isVisible(selectors.ticketSales.firstSaleReservedIcon);
-
-        expect(result).toBeFalsy();
-    });
-
-    it('should log in as Production role and go to a target ticket summary', async() => {
-        await page.loginAndModule('production', 'ticket');
-        await page.accessToSearchResult('13');
-        await page.waitForState('ticket.card.summary');
-    });
-
-    it(`should check the ticket is deleted`, async() => {
-        await page.waitForSelector(selectors.ticketDescriptor.isDeletedIcon);
-    });
-});

e2e/paths/05-ticket/01_observations.spec.js

@@ -1,50 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket Create notes path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('employee', 'ticket');
-        await page.accessToSearchResult('5');
-        await page.accessToSection('ticket.card.observation');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should create a new note', async() => {
-        await page.waitToClick(selectors.ticketNotes.addNoteButton);
-        await page.autocompleteSearch(selectors.ticketNotes.firstNoteType, 'ItemPicker');
-        await page.write(selectors.ticketNotes.firstDescription, 'description');
-        await page.waitToClick(selectors.ticketNotes.submitNotesButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should confirm the note is the expected one', async() => {
-        await page.reloadSection('ticket.card.observation');
-        const result = await page
-            .waitToGetProperty(selectors.ticketNotes.firstNoteType, 'value');
-
-        expect(result).toEqual('ItemPicker');
-
-        const firstDescription = await page
-            .waitToGetProperty(selectors.ticketNotes.firstDescription, 'value');
-
-        expect(firstDescription).toEqual('description');
-    });
-
-    it('should delete the note', async() => {
-        await page.waitToClick(selectors.ticketNotes.firstNoteRemoveButton);
-        await page.waitToClick(selectors.ticketNotes.submitNotesButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-});

e2e/paths/05-ticket/02_expeditions_and_log.spec.js

@@ -1,32 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket expeditions and log path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('production', 'ticket');
-        await page.accessToSearchResult('1');
-        await page.accessToSection('ticket.card.expedition');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it(`should delete a former expedition and confirm the remaining expedition are the expected ones`, async() => {
-        await page.waitToClick(selectors.ticketExpedition.thirdSaleCheckbox);
-        await page.waitToClick(selectors.ticketExpedition.deleteExpeditionButton);
-        await page.waitToClick(selectors.globalItems.acceptButton);
-        await page.reloadSection('ticket.card.expedition');
-
-        await page.waitForSelector(selectors.ticketExpedition.expeditionRow, {});
-        const result = await page
-            .countElement(selectors.ticketExpedition.expeditionRow);
-
-        expect(result).toEqual(6);
-    });
-});

e2e/paths/05-ticket/04_packages.spec.js

@@ -1,78 +0,0 @@
-import getBrowser from '../../helpers/puppeteer';
-
-const $ = {
-    firstPackage: 'vn-autocomplete[label="Package"]',
-    firstQuantity: 'vn-ticket-package vn-horizontal:nth-child(1) vn-input-number[ng-model="package.quantity"]',
-    firstRemovePackageButton: 'vn-icon-button[vn-tooltip="Remove package"]',
-    addPackageButton: 'vn-icon-button[vn-tooltip="Add package"]',
-    savePackagesButton: `button[type=submit]`
-};
-
-describe('Ticket Create packages path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('employee', 'ticket');
-        await page.accessToSearchResult('1');
-        await page.accessToSection('ticket.card.package');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it(`should attempt create a new package but receive an error if package is blank`, async() => {
-        await page.waitToClick($.firstRemovePackageButton);
-        await page.waitToClick($.addPackageButton);
-        await page.write($.firstQuantity, '99');
-        await page.waitToClick($.savePackagesButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Package cannot be blank');
-    });
-
-    it(`should delete the first package and receive and error to save a new one with blank quantity`, async() => {
-        await page.clearInput($.firstQuantity);
-        await page.autocompleteSearch($.firstPackage, 'Container medical box 100cm');
-        await page.waitToClick($.savePackagesButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Some fields are invalid');
-    });
-
-    it(`should confirm the quantity input isn't invalid yet`, async() => {
-        const result = await page
-            .evaluate(selector => {
-                return document.querySelector(`${selector} input`).checkValidity();
-            }, $.firstQuantity);
-
-        expect(result).toBeTruthy();
-    });
-
-    it(`should create a new package with correct data`, async() => {
-        await page.clearInput($.firstQuantity);
-        await page.write($.firstQuantity, '-99');
-        await page.waitToClick($.savePackagesButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should confirm the first select is the expected one`, async() => {
-        await page.reloadSection('ticket.card.package');
-        await page.waitForTextInField($.firstPackage, 'Container medical box 100cm');
-        const result = await page.waitToGetProperty($.firstPackage, 'value');
-
-        expect(result).toEqual('Container medical box 100cm');
-    });
-
-    it(`should confirm quantity is just a number and the string part was ignored by the imput number`, async() => {
-        await page.waitForTextInField($.firstQuantity, '-99');
-        const result = await page.waitToGetProperty($.firstQuantity, 'value');
-
-        expect(result).toEqual('-99');
-    });
-});

e2e/paths/05-ticket/05_tracking_state.spec.js

@@ -1,72 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket Create new tracking state path', () => {
-    let browser;
-    let page;
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    describe('as production', () => {
-        it('should log into the ticket 1 tracking', async() => {
-            browser = await getBrowser();
-            page = browser.page;
-            await page.loginAndModule('production', 'ticket');
-            await page.accessToSearchResult('1');
-            await page.accessToSection('ticket.card.tracking.index');
-        });
-
-        it('should access to the create state view by clicking the create floating button', async() => {
-            await page.waitToClick(selectors.ticketTracking.createStateButton);
-            await page.waitForSelector(selectors.createStateView.state, {visible: true});
-            await page.waitForState('ticket.card.tracking.edit');
-        });
-
-        it(`should create a new state`, async() => {
-            await page.autocompleteSearch(selectors.createStateView.state, 'OK');
-            await page.waitToClick(selectors.createStateView.saveStateButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain('Data saved!');
-        });
-    });
-
-    describe('as salesPerson', () => {
-        it('should now log into the ticket 1 tracking', async() => {
-            await page.loginAndModule('salesPerson', 'ticket');
-            await page.accessToSearchResult('1');
-            await page.accessToSection('ticket.card.tracking.index');
-        });
-
-        it('should now access to the create state view by clicking the create floating button', async() => {
-            await page.waitForSelector('.vn-popup', {hidden: true});
-            await page.waitToClick(selectors.ticketTracking.createStateButton);
-            await page.waitForState('ticket.card.tracking.edit');
-        });
-
-        it(`should attemp to create an state for which salesPerson doesn't have permissions`, async() => {
-            await page.autocompleteSearch(selectors.createStateView.state, 'Encajado');
-            await page.waitToClick(selectors.createStateView.saveStateButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain(`You don't have enough privileges`);
-        });
-
-        it(`should make sure the worker gets autocomplete uppon selecting the assigned state`, async() => {
-            await page.autocompleteSearch(selectors.createStateView.state, 'asignado');
-            const result = await page
-                .waitToGetProperty(selectors.createStateView.worker, 'value');
-
-            expect(result).toEqual('salesperson');
-        });
-
-        it(`should succesfully create a valid state`, async() => {
-            await page.waitToClick(selectors.createStateView.saveStateButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain('Data saved!');
-        });
-    });
-});

e2e/paths/05-ticket/06_basic_data_steps.spec.js

@@ -1,143 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket Edit basic data path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('employee', 'ticket');
-        await page.accessToSearchResult('11');
-        await page.accessToSection('ticket.card.basicData.stepOne');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it(`should confirm the zone autocomplete is disabled unless your role is productionBoss`, async() => {
-        await page.waitForSelector(selectors.ticketBasicData.zone, {});
-        const disabled = await page.evaluate(selector => {
-            return document.querySelector(selector).disabled;
-        }, `${selectors.ticketBasicData.zone} input`);
-
-        expect(disabled).toBeTruthy();
-    });
-
-    it(`should now log as productionBoss to perform the rest of the tests`, async() => {
-        await page.loginAndModule('productionBoss', 'ticket');
-        await page.accessToSearchResult('11');
-        await page.accessToSection('ticket.card.basicData.stepOne');
-    });
-
-    it(`should confirm the zone autocomplete is enabled for the role productionBoss`, async() => {
-        await page.waitForSpinnerLoad();
-        await page.waitForSelector(selectors.ticketBasicData.zone);
-        const disabled = await page.evaluate(selector => {
-            return document.querySelector(selector).disabled;
-        }, `${selectors.ticketBasicData.zone} input`);
-
-        expect(disabled).toBeFalsy();
-    });
-
-    it(`should check the zone is for Gotham247`, async() => {
-        let zone = await page
-            .waitToGetProperty(selectors.ticketBasicData.zone, 'value');
-
-        expect(zone).toContain('Zone 247 A');
-    });
-
-    it(`should edit the ticket agency then check there are no zones for it`, async() => {
-        await page.autocompleteSearch(selectors.ticketBasicData.agency, 'Super-Man delivery');
-        let emptyZone = await page
-            .expectPropertyValue(selectors.ticketBasicData.zone, 'value', '');
-
-        expect(emptyZone).toBeTruthy();
-    });
-
-    it(`should edit the ticket zone then check the agency is for the new zone`, async() => {
-        await page.clearInput(selectors.ticketBasicData.agency);
-        await page.autocompleteSearch(selectors.ticketBasicData.zone, 'Zone expensive A');
-        let zone = await page
-            .waitToGetProperty(selectors.ticketBasicData.agency, 'value');
-
-        expect(zone).toContain('Gotham247Expensive');
-    });
-
-    it(`should click next`, async() => {
-        await page.waitToClick(selectors.ticketBasicData.nextStepButton);
-        await page.waitForState('ticket.card.basicData.stepTwo');
-    });
-
-    it(`should have a price diference`, async() => {
-        const result = await page
-            .waitToGetProperty(selectors.ticketBasicData.stepTwoTotalPriceDif, 'innerText');
-
-        expect(result).toContain('-€228.25');
-    });
-
-    it(`should select a new reason for the changes made then click on finalize`, async() => {
-        await page.waitToClick(selectors.ticketBasicData.chargesReason);
-        await page.waitToClick(selectors.ticketBasicData.finalizeButton);
-        await page.waitForState('ticket.card.summary');
-    });
-
-    it(`should not find ticket`, async() => {
-        await page.doSearch('29');
-        const count = await page.countElement(selectors.ticketsIndex.searchResult);
-
-        expect(count).toEqual(0);
-    });
-
-    it(`should split ticket without negatives`, async() => {
-        const newAgency = 'Gotham247';
-        const newDate = Date.vnNew();
-        newDate.setDate(newDate.getDate() - 1);
-
-        await page.accessToSearchResult('14');
-        await page.accessToSection('ticket.card.basicData.stepOne');
-
-        await page.autocompleteSearch(selectors.ticketBasicData.agency, newAgency);
-        await page.pickDate(selectors.ticketBasicData.shipped, newDate);
-
-        await page.waitToClick(selectors.ticketBasicData.nextStepButton);
-
-        await page.waitToClick(selectors.ticketBasicData.finalizeButton);
-
-        await page.waitForState('ticket.card.summary');
-
-        const newTicketAgency = await page
-            .waitToGetProperty(selectors.ticketDescriptor.descriptorDeliveryAgency, 'innerText');
-        const newTicketDate = await page
-            .waitToGetProperty(selectors.ticketDescriptor.descriptorDeliveryDate, 'innerText');
-
-        expect(newAgency).toEqual(newTicketAgency);
-        expect(newTicketDate).toContain(newDate.getDate());
-    });
-
-    it(`should new ticket have sale of old ticket`, async() => {
-        await page.accessToSection('ticket.card.sale');
-        await page.waitForState('ticket.card.sale');
-
-        const item = await page.waitToGetProperty(selectors.ticketSales.firstSaleId, 'innerText');
-
-        expect(item).toEqual('4');
-    });
-
-    it(`should old ticket have old date and agency`, async() => {
-        const oldDate = Date.vnNew();
-        const oldAgency = 'Super-Man delivery';
-
-        await page.accessToSearchResult('14');
-
-        const oldTicketAgency = await page
-            .waitToGetProperty(selectors.ticketDescriptor.descriptorDeliveryAgency, 'innerText');
-        const oldTicketDate = await page
-            .waitToGetProperty(selectors.ticketDescriptor.descriptorDeliveryDate, 'innerText');
-
-        expect(oldTicketAgency).toEqual(oldAgency);
-        expect(oldTicketDate).toContain(oldDate.getDate());
-    });
-});

e2e/paths/05-ticket/08_components.spec.js

@@ -1,30 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket List components path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('employee', 'ticket');
-        await page.accessToSearchResult('1');
-        await page.accessToSection('ticket.card.components');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should confirm the total base is correct', async() => {
-        const name = 'Base €';
-        const minLength = name.length;
-
-        await page.waitPropertyLength(selectors.ticketComponents.base, 'innerText', minLength);
-        const base = await page.waitToGetProperty(selectors.ticketComponents.base, 'innerText');
-
-        expect(base).toContain('Base');
-        expect(base.length).toBeGreaterThan(minLength);
-    });
-});

e2e/paths/05-ticket/09_weekly.spec.js

@@ -1,123 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket descriptor path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('buyerBoss', 'ticket');
-        await page.accessToSection('ticket.weekly.index');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should count the amount of tickets in the turns section', async() => {
-        const result = await page.countElement(selectors.ticketsIndex.weeklyTicket);
-
-        expect(result).toEqual(6);
-    });
-
-    it('should go back to the ticket index then search and access a ticket summary', async() => {
-        await page.accessToSection('ticket.index');
-        await page.accessToSearchResult('33');
-    });
-
-    it('should add the ticket to thursday turn using the descriptor more menu', async() => {
-        await page.waitToClick(selectors.ticketDescriptor.moreMenu);
-        await page.waitToClick(selectors.ticketDescriptor.moreMenuAddToTurn);
-        await page.waitToClick(selectors.ticketDescriptor.thursdayButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Current ticket deleted and added to shift');
-    });
-
-    it('should again click on the Tickets button of the top bar menu', async() => {
-        await page.waitToClick(selectors.globalItems.applicationsMenuButton);
-        await page.waitForSelector(selectors.globalItems.applicationsMenuVisible);
-        await page.waitToClick(selectors.globalItems.ticketsButton);
-        await page.waitForState('ticket.index');
-    });
-
-    it('should confirm the ticket 33 was added to thursday', async() => {
-        await page.accessToSection('ticket.weekly.index');
-        const result = await page.waitToGetProperty(selectors.ticketsIndex.thirdWeeklyTicket, 'value');
-
-        expect(result).toEqual('Thursday');
-    });
-
-    it('should click on the Tickets button of the top bar menu once more', async() => {
-        await page.waitToClick(selectors.globalItems.applicationsMenuButton);
-        await page.waitForSelector(selectors.globalItems.applicationsMenuVisible);
-        await page.waitToClick(selectors.globalItems.ticketsButton);
-        await page.waitForState('ticket.index');
-    });
-
-    it('should now search for the ticket 33', async() => {
-        await page.accessToSearchResult('33');
-        await page.waitForState('ticket.card.summary');
-    });
-
-    it('should add the ticket to saturday turn using the descriptor more menu', async() => {
-        await page.waitToClick(selectors.ticketDescriptor.moreMenu);
-        await page.waitToClick(selectors.ticketDescriptor.moreMenuAddToTurn);
-        await page.waitToClick(selectors.ticketDescriptor.saturdayButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Current ticket deleted and added to shift');
-    });
-
-    it('should click on the Tickets button of the top bar menu once again', async() => {
-        await page.waitToClick(selectors.globalItems.applicationsMenuButton);
-        await page.waitForSelector(selectors.globalItems.applicationsMenuVisible);
-        await page.waitToClick(selectors.globalItems.ticketsButton);
-        await page.waitForState('ticket.index');
-    });
-
-    it('should confirm the ticket 33 was added on saturday', async() => {
-        await page.accessToSection('ticket.weekly.index');
-        await page.waitForTimeout(5000);
-
-        const result = await page.waitToGetProperty(selectors.ticketsIndex.thirdWeeklyTicket, 'value');
-
-        expect(result).toEqual('Saturday');
-    });
-
-    it('should now search for the weekly ticket 33', async() => {
-        await page.doSearch('33');
-        const nResults = await page.countElement(selectors.ticketsIndex.searchWeeklyResult);
-
-        expect(nResults).toEqual(2);
-    });
-
-    it('should delete the weekly ticket 33', async() => {
-        await page.waitToClick(selectors.ticketsIndex.firstWeeklyTicketDeleteIcon);
-        await page.waitToClick(selectors.ticketsIndex.acceptDeleteTurn);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should confirm the sixth weekly ticket was deleted', async() => {
-        await page.doSearch();
-        const nResults = await page.countElement(selectors.ticketsIndex.searchWeeklyResult);
-
-        expect(nResults).toEqual(6);
-    });
-
-    it('should update the agency then remove it afterwards', async() => {
-        await page.autocompleteSearch(selectors.ticketsIndex.firstWeeklyTicketAgency, 'Gotham247');
-        let message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-
-        await page.clearInput(selectors.ticketsIndex.firstWeeklyTicketAgency);
-        message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-});

e2e/paths/05-ticket/10_request.spec.js

@@ -1,77 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket purchase request path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('salesPerson', 'ticket');
-        await page.accessToSearchResult('1');
-        await page.accessToSection('ticket.card.request.index');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should add a new request', async() => {
-        await page.waitToClick(selectors.ticketRequests.addRequestButton);
-        await page.write(selectors.ticketRequests.descriptionInput, 'New stuff');
-        await page.write(selectors.ticketRequests.quantity, '9');
-        await page.autocompleteSearch(selectors.ticketRequests.atender, 'buyerNick');
-        await page.write(selectors.ticketRequests.price, '999');
-        await page.waitToClick(selectors.ticketRequests.saveButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should have been redirected to the request index', async() => {
-        await page.waitForState('ticket.card.request.index');
-    });
-
-    it(`should edit the third request quantity as it's state is still new`, async() => {
-        await page.write(selectors.ticketRequests.thirdRequestQuantity, '9');
-        await page.keyboard.press('Enter');
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should check the new request was added', async() => {
-        await page.reloadSection('ticket.card.request.index');
-        const result = await page.waitToGetProperty(selectors.ticketRequests.thirdRequestQuantity, 'value');
-
-        expect(result).toEqual('99');
-    });
-
-    it(`should check the first request can't be edited as its state is different to new`, async() => {
-        await page.waitForClassPresent(selectors.ticketRequests.firstRequestQuantity, 'disabled');
-        const result = await page.isDisabled(selectors.ticketRequests.firstRequestQuantity);
-
-        expect(result).toBe(true);
-    });
-
-    it(`should check the second request can't be edited as its state is different to new`, async() => {
-        await page.waitForClassPresent(selectors.ticketRequests.secondRequestQuantity, 'disabled');
-        const result = await page.isDisabled(selectors.ticketRequests.secondRequestQuantity);
-
-        expect(result).toBe(true);
-    });
-
-    it('should delete the added request', async() => {
-        await page.waitToClick(selectors.ticketRequests.thirdRemoveRequestButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should check the request was deleted', async() => {
-        await page.reloadSection('ticket.card.request.index');
-        await page.waitForSelector(selectors.ticketRequests.addRequestButton);
-        await page.waitForSelector(selectors.ticketRequests.thirdDescription, {hidden: true});
-    });
-});

e2e/paths/05-ticket/12_descriptor.spec.js

@@ -1,148 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket descriptor path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('salesperson', 'ticket');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    describe('Delete ticket', () => {
-        it('should search for an specific ticket', async() => {
-            await page.accessToSearchResult('18');
-            await page.waitForState('ticket.card.summary');
-        });
-
-        it(`should update the shipped hour using the descriptor menu`, async() => {
-            await page.waitToClick(selectors.ticketDescriptor.moreMenu);
-            await page.waitToClick(selectors.ticketDescriptor.moreMenuChangeShippedHour);
-            await page.pickTime(selectors.ticketDescriptor.changeShippedHour, '08:15');
-            await page.waitToClick(selectors.ticketDescriptor.acceptChangeHourButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain('Shipped hour updated');
-        });
-
-        it(`should confirm the ticket descriptor shows the correct shipping hour`, async() => {
-            await page.waitForState('ticket.card.summary');
-            const result = await page
-                .waitToGetProperty(selectors.ticketDescriptor.descriptorDeliveryDate, 'innerText');
-
-            expect(result).toContain('08:15');
-        });
-
-        it('should delete the ticket using the descriptor menu', async() => {
-            await page.waitToClick(selectors.ticketDescriptor.moreMenu);
-            await page.waitToClick(selectors.ticketDescriptor.moreMenuDeleteTicket);
-            await page.waitToClick(selectors.ticketDescriptor.acceptDialog);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain('Ticket deleted. You can undo this action within the first hour');
-        });
-
-        it('should have been relocated to the ticket index', async() => {
-            await page.waitForState('ticket.index');
-        });
-
-        it(`should search for the deleted ticket and check the deletedTicket icon and it's date`, async() => {
-            await page.write(selectors.ticketsIndex.topbarSearch, '18');
-            await page.waitToClick(selectors.globalItems.searchButton);
-            await page.waitForState('ticket.card.summary');
-            await page.isVisible(selectors.ticketDescriptor.isDeletedIcon);
-            const result = await page.waitToGetProperty(selectors.ticketsIndex.searchResultDate, 'innerText');
-
-            expect(result).toContain(2000);
-        });
-    });
-
-    describe('Restore ticket', () => {
-        it('should restore the ticket using the descriptor menu', async() => {
-            await page.waitToClick(selectors.ticketDescriptor.moreMenu);
-            await page.waitToClick(selectors.ticketDescriptor.moreMenuRestoreTicket);
-            await page.waitToClick(selectors.ticketDescriptor.acceptDialog);
-            await page.waitForState('ticket.card.summary');
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain('Data saved!');
-        });
-    });
-
-    describe('Make invoice', () => {
-        it('should login as administrative role then search for a ticket', async() => {
-            const invoiceableTicketId = '14';
-
-            await page.loginAndModule('administrative', 'ticket');
-            await page.accessToSearchResult(invoiceableTicketId);
-            await page.waitForState('ticket.card.summary');
-        });
-
-        it(`should make sure the ticket doesn't have an invoiceOutFk yet`, async() => {
-            const result = await page
-                .waitToGetProperty(selectors.ticketSummary.invoiceOutRef, 'innerText');
-
-            expect(result).toEqual('-');
-        });
-
-        it('should invoice the ticket using the descriptor menu', async() => {
-            await page.waitToClick(selectors.ticketDescriptor.moreMenu);
-            await page.waitForContentLoaded();
-            await page.waitToClick(selectors.ticketDescriptor.moreMenuMakeInvoice);
-            await page.waitToClick(selectors.ticketDescriptor.acceptInvoiceOutButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain('Ticket invoiced');
-        });
-
-        it(`should make sure the ticket summary have an invoiceOutFk`, async() => {
-            await page.waitForTextInElement(selectors.ticketSummary.invoiceOutRef, 'T4444445');
-            const result = await page.waitToGetProperty(selectors.ticketSummary.invoiceOutRef, 'innerText');
-
-            expect(result).toEqual('T4444445');
-        });
-
-        it(`should regenerate the invoice using the descriptor menu`, async() => {
-            const expectedMessage = 'The invoice PDF document has been regenerated';
-
-            await page.waitToClick(selectors.ticketDescriptor.moreMenu);
-            await page.waitForContentLoaded();
-            await page.waitToClick(selectors.ticketDescriptor.moreMenuRegenerateInvoice);
-            await page.respondToDialog('accept');
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain(expectedMessage);
-        });
-    });
-
-    describe('SMS', () => {
-        it('should send the payment SMS using the descriptor menu', async() => {
-            await page.waitToClick(selectors.ticketDescriptor.moreMenu);
-            await page.waitToClick(selectors.ticketDescriptor.moreMenuSMSOptions);
-            await page.waitToClick(selectors.ticketDescriptor.moreMenuPaymentSMS);
-            await page.waitForSelector(selectors.ticketDescriptor.SMStext);
-            await page.waitPropertyLength(selectors.ticketDescriptor.SMStext, 'value', 128);
-            await page.waitToClick(selectors.ticketDescriptor.sendSMSbutton);
-            const message = await page.waitForSnackbar();
-
-            expect(message).toBeDefined();
-        });
-
-        it('should send the import SMS using the descriptor menu', async() => {
-            await page.waitToClick(selectors.ticketDescriptor.moreMenuSMSOptions);
-            await page.waitToClick(selectors.ticketDescriptor.moreMenuSendImportSms);
-            await page.waitForSelector(selectors.ticketDescriptor.SMStext);
-            await page.waitPropertyLength(selectors.ticketDescriptor.SMStext, 'value', 144);
-            await page.waitToClick(selectors.ticketDescriptor.sendSMSbutton);
-            const message = await page.waitForSnackbar();
-
-            expect(message).toBeDefined();
-        });
-    });
-});

e2e/paths/05-ticket/13_services.spec.js

@@ -1,127 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket services path', () => {
-    let browser;
-    let page;
-    const invoicedTicketId = '1';
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    describe('as employee', () => {
-        it('should log in as employee, search for an invoice and get to services', async() => {
-            browser = await getBrowser();
-            page = browser.page;
-            await page.loginAndModule('employee', 'ticket');
-            await page.accessToSearchResult(invoicedTicketId);
-            await page.accessToSection('ticket.card.service');
-        });
-
-        it('should find the add descripton button disabled for this user role', async() => {
-            await page.waitForClassPresent(selectors.ticketService.firstAddServiceTypeButton, 'disabled');
-            await page.waitToClick(selectors.ticketService.addServiceButton);
-            await page.waitForSelector(selectors.ticketService.firstAddServiceTypeButton);
-            const disabled = await page.isDisabled(selectors.ticketService.firstAddServiceTypeButton);
-
-            expect(disabled).toBe(true);
-        });
-
-        it('should receive an error if you attempt to save a service without access rights', async() => {
-            await page.clearInput(selectors.ticketService.firstPrice);
-            await page.write(selectors.ticketService.firstPrice, '999');
-            await page.waitToClick(selectors.ticketService.saveServiceButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain(`The current ticket can't be modified`);
-        });
-    });
-
-    describe('as administrative', () => {
-        let editableTicketId = '16';
-        it('should navigate to the services of a target ticket', async() => {
-            await page.loginAndModule('administrative', 'ticket');
-            await page.accessToSearchResult(editableTicketId);
-            await page.accessToSection('ticket.card.service');
-        });
-
-        it('should click on the add button to prepare the form to create a new service', async() => {
-            await page.waitToClick(selectors.ticketService.addServiceButton);
-            const result = await page
-                .isVisible(selectors.ticketService.firstServiceType);
-
-            expect(result).toBeTruthy();
-        });
-
-        it('should receive an error if you attempt to save it with empty fields', async() => {
-            await page.waitToClick(selectors.ticketService.saveServiceButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain(`can't be blank`);
-        });
-
-        it('should click on the add new service type to open the dialog', async() => {
-            await page.waitToClick(selectors.ticketService.firstAddServiceTypeButton);
-            await page.waitForSelector('.vn-dialog.shown');
-            const result = await page.isVisible(selectors.ticketService.newServiceTypeName);
-
-            expect(result).toBeTruthy();
-        });
-
-        it('should receive an error if service type is empty on submit', async() => {
-            await page.waitToClick(selectors.ticketService.saveServiceTypeButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain(`Name can't be empty`);
-        });
-
-        it('should create a new service type then add price then create the service', async() => {
-            await page.write(selectors.ticketService.newServiceTypeName, 'Documentos');
-            await page.waitToClick(selectors.ticketService.saveServiceTypeButton);
-            await page.write(selectors.ticketService.firstPrice, '999');
-            await page.waitToClick(selectors.ticketService.saveServiceButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain('Data saved!');
-        });
-
-        it('should confirm the service description was created correctly', async() => {
-            await page.reloadSection('ticket.card.service');
-            const result = await page
-                .waitToGetProperty(selectors.ticketService.firstServiceType, 'value');
-
-            expect(result).toEqual('Documentos');
-        });
-
-        it('should confirm the service quantity was created correctly', async() => {
-            const result = await page
-                .waitToGetProperty(selectors.ticketService.firstQuantity, 'value');
-
-            expect(result).toEqual('1');
-        });
-
-        it('should confirm the service price was created correctly', async() => {
-            const result = await page
-                .waitToGetProperty(selectors.ticketService.firstPrice, 'value');
-
-            expect(result).toEqual('999');
-        });
-
-        it('should delete the service', async() => {
-            await page.waitToClick(selectors.ticketService.fistDeleteServiceButton);
-            await page.waitForNumberOfElements(selectors.ticketService.serviceLine, 0);
-            await page.waitToClick(selectors.ticketService.saveServiceButton);
-            const message = await page.waitForSnackbar();
-
-            expect(message.text).toContain('Data saved!');
-        });
-
-        it(`should confirm the service was removed`, async() => {
-            await page.reloadSection('ticket.card.service');
-            const nResults = await page.countElement(selectors.ticketService.serviceLine);
-
-            expect(nResults).toEqual(0);
-        });
-    });
-});

e2e/paths/05-ticket/14_create_ticket.spec.js

@@ -1,69 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket create path', () => {
-    let browser;
-    let page;
-    let nextMonth = Date.vnNew();
-    nextMonth.setMonth(nextMonth.getMonth() + 1);
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('salesPerson', 'ticket');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should open the new ticket form', async() => {
-        await page.waitToClick(selectors.ticketsIndex.newTicketButton);
-        await page.waitForState('ticket.create');
-    });
-
-    it('should succeed to create a ticket', async() => {
-        await page.autocompleteSearch(selectors.createTicketView.client, 'Clark Kent');
-        await page.pickDate(selectors.createTicketView.deliveryDate, nextMonth);
-        await page.autocompleteSearch(selectors.createTicketView.warehouse, 'Warehouse Two');
-        await page.autocompleteSearch(selectors.createTicketView.agency, 'Gotham247');
-        await page.waitToClick(selectors.createTicketView.createButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should check the url is now the summary of the ticket', async() => {
-        await page.waitForState('ticket.card.summary');
-    });
-
-    it('should again open the new ticket form', async() => {
-        await page.waitToClick(selectors.globalItems.returnToModuleIndexButton);
-        await page.waitToClick(selectors.ticketsIndex.newTicketButton);
-        await page.waitForState('ticket.create');
-    });
-
-    it('should succeed to create another ticket for the same client', async() => {
-        await page.autocompleteSearch(selectors.createTicketView.client, 'Clark Kent');
-        await page.pickDate(selectors.createTicketView.deliveryDate, nextMonth);
-        await page.autocompleteSearch(selectors.createTicketView.warehouse, 'Warehouse One');
-        await page.autocompleteSearch(selectors.createTicketView.agency, 'Gotham247');
-        await page.waitToClick(selectors.createTicketView.createButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should check the url is now the summary of the created ticket', async() => {
-        await page.waitForState('ticket.card.summary');
-    });
-
-    it('should delete the current ticket', async() => {
-        await page.waitToClick(selectors.ticketDescriptor.moreMenu);
-        await page.waitToClick(selectors.ticketDescriptor.moreMenuDeleteTicket);
-        await page.waitToClick(selectors.ticketDescriptor.acceptDialog);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Ticket deleted. You can undo this action within the first hour');
-    });
-});

e2e/paths/05-ticket/15_create_ticket_from_client.spec.js

@@ -1,37 +0,0 @@
-import getBrowser from '../../helpers/puppeteer';
-
-const $ = {
-    form: 'vn-ticket-create-card',
-    moreMenu: 'vn-client-descriptor vn-icon-button[icon=more_vert]',
-    simpleTicketButton: '.vn-menu [name="simpleTicket"]'
-};
-
-describe('Ticket create from client path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('employee', 'client');
-        await page.accessToSearchResult('Petter Parker');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should create simple ticket and check if the client details are the expected ones', async() => {
-        await page.waitToClick($.moreMenu);
-        await page.waitToClick($.simpleTicketButton);
-        await page.waitForState('ticket.create');
-
-        const values = {
-            client: 'Petter Parker',
-            address: 'Petter Parker'
-        };
-        const formValues = await page.fetchForm($.form, Object.keys(values));
-
-        expect(formValues).toEqual(values);
-    });
-});

e2e/paths/05-ticket/16_summary.spec.js

@@ -1,108 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket Summary path', () => {
-    let browser;
-    let page;
-    const ticketId = '20';
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should navigate to the target ticket summary section', async() => {
-        await page.loginAndModule('employee', 'ticket');
-        await page.accessToSearchResult(ticketId);
-        await page.waitForState('ticket.card.summary');
-    });
-
-    it(`should display details from the ticket and it's client on the top of the header`, async() => {
-        await page.waitForTextInElement(selectors.ticketSummary.header, 'Bruce Banner');
-        const result = await page.waitToGetProperty(selectors.ticketSummary.header, 'innerText');
-
-        expect(result).toContain(`Ticket #${ticketId}`);
-        expect(result).toContain('Bruce Banner (1109)');
-        expect(result).toContain('Somewhere in Thailand');
-    });
-
-    it('should display ticket details', async() => {
-        let result = await page
-            .waitToGetProperty(selectors.ticketSummary.state, 'innerText');
-
-        expect(result).toContain('Arreglar');
-    });
-
-    it('should display delivery details', async() => {
-        let result = await page
-            .waitToGetProperty(selectors.ticketSummary.route, 'innerText');
-
-        expect(result).toContain('3');
-    });
-
-    it('should display the ticket total', async() => {
-        let result = await page
-            .waitToGetProperty(selectors.ticketSummary.total, 'innerText');
-
-        expect(result).toContain('€155.54');
-    });
-
-    it('should display the ticket line(s)', async() => {
-        let result = await page
-            .waitToGetProperty(selectors.ticketSummary.firstSaleItemId, 'innerText');
-
-        expect(result).toContain('2');
-    });
-
-    it(`should click on the first sale ID to make the item descriptor visible`, async() => {
-        await page.waitToClick(selectors.ticketSummary.firstSaleItemId);
-        await page.waitImgLoad(selectors.ticketSummary.firstSaleDescriptorImage);
-        const visible = await page.isVisible(selectors.ticketSummary.itemDescriptorPopover);
-
-        expect(visible).toBeTruthy();
-    });
-
-    it(`should check the url for the item diary link of the descriptor is for the right item id`, async() => {
-        await page.waitForSelector(selectors.ticketSummary.itemDescriptorPopoverItemDiaryButton, {visible: true});
-    });
-
-    it('should log in as production then navigate to the summary of the same ticket', async() => {
-        await page.loginAndModule('production', 'ticket');
-        await page.accessToSearchResult(ticketId);
-        await page.waitForState('ticket.card.summary');
-    });
-
-    it('should set the ticket state to OK using the top right button', async() => {
-        const searchValue = 'OK';
-        await page.waitToClick(selectors.ticketSummary.stateButton);
-        await page.write(selectors.ticketSummary.stateAutocomplete, searchValue);
-        try {
-            await page.waitForFunction(text => {
-                const element = document.querySelector('li.active');
-                if (element)
-                    return element.innerText.toLowerCase().includes(text.toLowerCase());
-            }, {}, searchValue);
-        } catch (error) {
-            const state = await page.evaluate(() => {
-                const stateSelector = 'vn-ticket-summary vn-label-value:nth-child(1) > section > span';
-                return document.querySelector(stateSelector).value;
-            });
-            throw new Error(`${stateSelector} innerText is ${state}! ${error}`);
-        }
-        await page.keyboard.press('Enter');
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it('should confirm the ticket state was updated', async() => {
-        await page.waitForSpinnerLoad();
-        const result = await page.waitToGetProperty(selectors.ticketSummary.state, 'innerText');
-
-        expect(result).toContain('OK');
-    });
-});

e2e/paths/05-ticket/17_log.spec.js

@@ -1,34 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket log path', () => {
-    let browser;
-    let page;
-    const ticketId = '5';
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should navigate to the target ticket notes section', async() => {
-        await page.loginAndModule('employee', 'ticket');
-        await page.accessToSearchResult(ticketId);
-        await page.accessToSection('ticket.card.observation');
-        await page.waitForState('ticket.card.observation');
-    });
-
-    it('should create a new note for the test', async() => {
-        await page.waitToClick(selectors.ticketNotes.addNoteButton);
-        await page.autocompleteSearch(selectors.ticketNotes.firstNoteType, 'ItemPicker');
-        await page.write(selectors.ticketNotes.firstDescription, 'description');
-        await page.waitToClick(selectors.ticketNotes.submitNotesButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-});

e2e/paths/05-ticket/18_index_payout.spec.js

@@ -1,70 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-const $ = {
-    newPayment: '.vn-dialog.shown',
-    anyBalanceLine: 'vn-client-balance-index vn-tbody > vn-tr',
-    firstLineReference: 'vn-client-balance-index vn-tbody > vn-tr:nth-child(1) > vn-td-editable'
-};
-
-describe('Ticket index payout path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('administrative', 'ticket');
-        await page.waitForState('ticket.index');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should check the second ticket from a client and 1 of another', async() => {
-        await page.waitToClick(selectors.globalItems.searchButton);
-        await page.waitToClick(selectors.ticketsIndex.thirdTicketCheckbox);
-        await page.waitToClick(selectors.ticketsIndex.fifthTicketCheckbox);
-        await page.waitToClick(selectors.ticketsIndex.payoutButton);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('You cannot make a payment on account from multiple clients');
-    });
-
-    it('should search for tickets of the same client then open the payout form', async() => {
-        await page.waitToClick(selectors.ticketsIndex.openAdvancedSearchButton);
-        await page.write(selectors.ticketsIndex.advancedSearchClient, '1101');
-        await page.keyboard.press('Enter');
-        await page.waitForNumberOfElements(selectors.ticketsIndex.anySearchResult, 10);
-        await page.waitToClick(selectors.ticketsIndex.firstTicketCheckbox);
-        await page.waitToClick(selectors.ticketsIndex.secondTicketCheckbox);
-
-        await page.waitToClick(selectors.ticketsIndex.payoutButton);
-
-        await page.waitForSelector(selectors.ticketsIndex.payoutCompany);
-    });
-
-    it('should fill the company and bank to perform a payout  and check a new balance line was entered', async() => {
-        await page.fillForm($.newPayment, {
-            company: 'VNL',
-            bank: 'cash',
-            amountPaid: 100,
-            description: 'Payment',
-            viewReceipt: false
-        });
-        await page.respondToDialog('accept');
-        const message = await page.waitForSnackbar();
-
-        await page.waitToClick(selectors.globalItems.homeButton);
-        await page.selectModule('client');
-        await page.accessToSearchResult('1101');
-        await page.accessToSection('client.card.balance.index');
-        await page.waitForSelector($.anyBalanceLine);
-        const count = await page.countElement($.anyBalanceLine);
-        const reference = await page.innerText($.firstLineReference);
-
-        expect(message.isSuccess).toBeTrue();
-        expect(count).toEqual(4);
-        expect(reference).toContain('Payment');
-    });
-});

e2e/paths/05-ticket/19_dms.spec.js

@@ -1,49 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket DMS path', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('employee', 'ticket');
-        await page.accessToSearchResult('1');
-        await page.accessToSection('ticket.card.dms.index');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should import a document', async() => {
-        await page.waitToClick(selectors.ticketDms.import);
-        await page.autocompleteSearch(selectors.ticketDms.document, '1');
-        await page.waitToClick(selectors.ticketDms.saveImport);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Data saved!');
-    });
-
-    it(`should check there's a listed document now`, async() => {
-        const result = await page.countElement(selectors.ticketDms.anyDocument);
-
-        expect(result).toEqual(1);
-    });
-
-    it('should attempt to import an existing document on this ticket', async() => {
-        await page.waitToClick(selectors.ticketDms.import);
-        await page.autocompleteSearch(selectors.ticketDms.document, '1');
-        await page.waitToClick(selectors.ticketDms.saveImport);
-        const message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('This document already exists on this ticket');
-    });
-
-    it(`should check there's still one document`, async() => {
-        const result = await page.countElement(selectors.ticketDms.anyDocument);
-
-        expect(result).toEqual(1);
-    });
-});

e2e/paths/05-ticket/20_moveExpedition.spec.js

@@ -1,50 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket expeditions', () => {
-    let browser;
-    let page;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('production', 'ticket');
-        await page.accessToSearchResult('1');
-        await page.accessToSection('ticket.card.expedition');
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it(`should move one expedition to new ticket withoute route`, async() => {
-        await page.waitToClick(selectors.ticketExpedition.thirdSaleCheckbox);
-        await page.waitToClick(selectors.ticketExpedition.moveExpeditionButton);
-        await page.waitToClick(selectors.ticketExpedition.moreMenuWithoutRoute);
-        await page.waitToClick(selectors.ticketExpedition.saveButton);
-        await page.waitForState('ticket.card.summary');
-        await page.accessToSection('ticket.card.expedition');
-
-        await page.waitForSelector(selectors.ticketExpedition.expeditionRow, {});
-        const result = await page
-            .countElement(selectors.ticketExpedition.expeditionRow);
-
-        expect(result).toEqual(2);
-    });
-
-    it(`should move one expedition to new ticket with route`, async() => {
-        await page.waitToClick(selectors.ticketExpedition.firstSaleCheckbox);
-        await page.waitToClick(selectors.ticketExpedition.moveExpeditionButton);
-        await page.waitToClick(selectors.ticketExpedition.moreMenuWithRoute);
-        await page.write(selectors.ticketExpedition.newRouteId, '1');
-        await page.waitToClick(selectors.ticketExpedition.saveButton);
-        await page.waitForState('ticket.card.summary');
-        await page.accessToSection('ticket.card.expedition');
-
-        await page.waitForSelector(selectors.ticketExpedition.expeditionRow, {});
-        const result = await page
-            .countElement(selectors.ticketExpedition.expeditionRow);
-
-        expect(result).toEqual(2);
-    });
-});

e2e/paths/05-ticket/21_future.spec.js

@@ -1,99 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket Future path', () => {
-    let browser;
-    let page;
-    let httpRequest;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('employee', 'ticket');
-        await page.accessToSection('ticket.future');
-        page.on('request', req => {
-            if (req.url().includes(`Tickets/getTicketsFuture`))
-                httpRequest = req.url();
-        });
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should search with required data, check three last tickets and move to the future', async() => {
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketFuture.warehouseFk);
-        await page.waitToClick(selectors.ticketFuture.submit);
-        let message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('warehouseFk is a required argument');
-
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketFuture.futureScopeDays);
-        await page.waitToClick(selectors.ticketFuture.submit);
-        message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('futureScopeDays is a required argument');
-
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketFuture.originScopeDays);
-        await page.waitToClick(selectors.ticketFuture.submit);
-        message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('originScopeDays is a required argument');
-
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.waitToClick(selectors.ticketFuture.submit);
-
-        expect(httpRequest).toBeDefined();
-
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-
-        await page.autocompleteSearch(selectors.ticketFuture.ipt, 'H');
-        await page.waitToClick(selectors.ticketFuture.submit);
-
-        expect(httpRequest).toContain('ipt=H');
-
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-
-        await page.clearInput(selectors.ticketFuture.ipt);
-
-        await page.autocompleteSearch(selectors.ticketFuture.futureIpt, 'H');
-        await page.waitToClick(selectors.ticketFuture.submit);
-
-        expect(httpRequest).toContain('futureIpt=H');
-
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-
-        await page.clearInput(selectors.ticketFuture.futureIpt);
-
-        await page.autocompleteSearch(selectors.ticketFuture.state, 'Free');
-        await page.waitToClick(selectors.ticketFuture.submit);
-
-        expect(httpRequest).toContain('state=0');
-
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-
-        await page.clearInput(selectors.ticketFuture.state);
-
-        await page.autocompleteSearch(selectors.ticketFuture.futureState, 'Free');
-        await page.waitToClick(selectors.ticketFuture.submit);
-
-        expect(httpRequest).toContain('futureState=0');
-
-        await page.waitToClick(selectors.ticketFuture.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketFuture.state);
-        await page.clearInput(selectors.ticketFuture.futureState);
-        await page.waitToClick(selectors.ticketFuture.submit);
-
-        await page.waitForNumberOfElements(selectors.ticketFuture.searchResult, 5);
-        await page.waitToClick(selectors.ticketFuture.multiCheck);
-        await page.waitToClick(selectors.ticketFuture.firstCheck);
-        await page.waitToClick(selectors.ticketFuture.moveButton);
-        await page.waitToClick(selectors.globalItems.acceptButton);
-        message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Tickets moved successfully!');
-    });
-});

e2e/paths/05-ticket/22_advance.spec.js

@@ -1,79 +0,0 @@
-import selectors from '../../helpers/selectors.js';
-import getBrowser from '../../helpers/puppeteer';
-
-describe('Ticket Advance path', () => {
-    let browser;
-    let page;
-    let httpRequest;
-
-    beforeAll(async() => {
-        browser = await getBrowser();
-        page = browser.page;
-        await page.loginAndModule('employee', 'ticket');
-        await page.accessToSection('ticket.advance');
-        page.on('request', req => {
-            if (req.url().includes(`Tickets/getTicketsAdvance`))
-                httpRequest = req.url();
-        });
-    });
-
-    afterAll(async() => {
-        await browser.close();
-    });
-
-    it('should search with the required data, check the first ticket and move to the present', async() => {
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketAdvance.warehouseFk);
-
-        await page.waitToClick(selectors.ticketAdvance.submit);
-        let message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('warehouseFk is a required argument');
-
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketAdvance.dateToAdvance);
-        await page.waitToClick(selectors.ticketAdvance.submit);
-        message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('dateToAdvance is a required argument');
-
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketAdvance.dateFuture);
-        await page.waitToClick(selectors.ticketAdvance.submit);
-        message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('dateFuture is a required argument');
-
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.waitToClick(selectors.ticketAdvance.submit);
-
-        expect(httpRequest).toBeDefined();
-
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.autocompleteSearch(selectors.ticketAdvance.futureIpt, 'H');
-        await page.waitToClick(selectors.ticketAdvance.submit);
-
-        expect(httpRequest).toContain('futureIpt=H');
-
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketAdvance.futureIpt);
-        await page.waitToClick(selectors.ticketAdvance.submit);
-
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.autocompleteSearch(selectors.ticketAdvance.ipt, 'H');
-        await page.waitToClick(selectors.ticketAdvance.submit);
-
-        expect(httpRequest).toContain('ipt=H');
-
-        await page.waitToClick(selectors.ticketAdvance.openAdvancedSearchButton);
-        await page.clearInput(selectors.ticketAdvance.ipt);
-        await page.waitToClick(selectors.ticketAdvance.submit);
-
-        await page.waitToClick(selectors.ticketAdvance.firstCheck);
-        await page.waitToClick(selectors.ticketAdvance.moveButton);
-        await page.waitToClick(selectors.ticketAdvance.acceptButton);
-        message = await page.waitForSnackbar();
-
-        expect(message.text).toContain('Tickets moved successfully!');
-    });
-});

loopback/common/methods/vn-model/printService.js

@@ -2,7 +2,7 @@ const {Report, Email} = require('vn-print');
 
 module.exports = Self => {
     Self.printReport = async function(ctx, id, reportName) {
-        const args = Object.assign({}, ctx.args);
+        const args = Object.assign({id}, ctx.args);
         const params = {lang: ctx.req.getLocale()};
 
         delete args.ctx;

loopback/locale/en.json

@@ -241,9 +241,8 @@
 	"The height must be greater than 50cm": "The height must be greater than 50cm",
 	"The maximum height of the wagon is 200cm": "The maximum height of the wagon is 200cm",
 	"The quantity claimed cannot be greater than the quantity of the line": "The quantity claimed cannot be greater than the quantity of the line",
-	"There are tickets for this area, delete them first": "There are tickets for this area, delete them first",
-	"ticketLostExpedition": "The ticket [{{ticketId}}]({{{ticketUrl}}}) has the following lost expedition:{{ expeditionId }}",
-	"null": "null",
 	"Invalid or expired verification code": "Invalid or expired verification code",
+    "There are tickets for this area, delete them first": "There are tickets for this area, delete them first",
+	"ticketLostExpedition": "The ticket [{{ticketId}}]({{{ticketUrl}}}) has the following lost expedition:{{ expeditionId }}",
 	"Payment method is required": "Payment method is required"
-}
+}

modules/account/back/locale/vn-user/en.yml

@@ -15,7 +15,5 @@ columns:
     image: image
     hasGrant: has grant
     userFk: user
-    recoverPass: recover password
     role: role
-    sync: pending sync
     lastPassChange: password changed