4369-ticket.request.create_getItemTypeWorker #1061

Merged
joan merged 6 commits from 4369-ticket.request.create_getItemTypeWorker into dev 2022-10-06 11:30:52 +00:00
Contributor
No description provided.
vicent added the
CR / Tests passed
label 2022-09-22 06:33:34 +00:00
vicent added 1 commit 2022-09-22 06:33:36 +00:00
gitea/salix/pipeline/head This commit looks good Details
0fb7487191
feat: add getItemTypeWorker endpoint
vicent changed title from feat: add getItemTypeWorker endpoint to 4369-ticket.request.create_getItemTypeWorker 2022-09-22 06:33:42 +00:00
vicent removed the
CR / Tests passed
label 2022-09-22 06:36:18 +00:00
vicent added 2 commits 2022-09-22 11:55:30 +00:00
gitea/salix/pipeline/head This commit looks good Details
a486b1593b
fix: backTest
vicent added the
CR / Tests passed
label 2022-09-22 11:55:50 +00:00
joan requested changes 2022-09-28 06:26:03 +00:00
@ -0,0 +29,4 @@
Object.assign(myOptions, options);
if (!myOptions.transaction) {
tx = await Self.beginTransaction({});
Contributor

En este caso no necesitas crear una transacción, ya que la ruta no hace modificaciones, ni tampoco requiere que esté transaccionado. (Pero si es correcto aceptar transacciones desde el options, linea 28)

En este caso no necesitas crear una transacción, ya que la ruta no hace modificaciones, ni tampoco requiere que esté transaccionado. (Pero si es correcto aceptar transacciones desde el options, linea 28)
vicent marked this conversation as resolved
@ -0,0 +35,4 @@
try {
const query =
`SELECT DISTINCT w.id, w.firstName, w.lastName, u.name, u.nickname
Contributor

No necesitas seleccionar todas las columnas por las que filtras con el where. Dejar solo las necesarias

No necesitas seleccionar todas las columnas por las que filtras con el where. Dejar solo las necesarias
vicent marked this conversation as resolved
@ -0,0 +16,4 @@
const result = await models.TicketRequest.getItemTypeWorker(ctx, filter);
expect(result.length).toEqual(2);
Contributor

En vez de contabilizar el número exacto, conviene comprobar que devuelva más de un resultado.

En vez de contabilizar el número exacto, conviene comprobar que devuelva más de un resultado.
vicent marked this conversation as resolved
vicent added 1 commit 2022-10-04 06:19:20 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
5c76437498
refator: delete unnecessary transaction
vicent added 1 commit 2022-10-04 06:19:55 +00:00
vicent requested review from joan 2022-10-04 06:20:09 +00:00
vicent added 91 commits 2022-10-06 09:48:58 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
409e935cc7
feat: add fields
gitea/salix/pipeline/head There was a failure building this commit Details
afd95872c8
feat: drag and drop
gitea/salix/pipeline/head There was a failure building this commit Details
931c4fb259
refactor: translate
gitea/salix/pipeline/head This commit looks good Details
e61784b6ba
refactor: undo chages about drag&drop
gitea/salix/pipeline/head This commit looks good Details
980ac50ba9
feat: add frontTets
gitea/salix/pipeline/head There was a failure building this commit Details
3e43bf2024
feat(route.index): can edit fields
gitea/salix/pipeline/head This commit looks good Details
1e521f1a8b
feat: delete link
gitea/salix/pipeline/head This commit looks good Details
bddc998b86
feat: allow update route.isOk field
gitea/salix/pipeline/head There was a failure building this commit Details
3bf5f5f86e
fix: tfront
gitea/salix/pipeline/head This commit looks good Details
eb7bd3dc59
update brach
gitea/salix/pipeline/head This commit looks good Details
182fe4a38e
fix: te2e
gitea/salix/pipeline/head This commit looks good Details
18ac0a0b61
Export Email and Report classes
gitea/salix/pipeline/head There was a failure building this commit Details
09bdee8b34
View & send PDF from loopback endpoint
gitea/salix/pipeline/head There was a failure building this commit Details
664fd444cc
Sample refactor
gitea/salix/pipeline/head There was a failure building this commit Details
85698410db
Templates refactor
gitea/salix/pipeline/head There was a failure building this commit Details
7f78286d6b
Reports refactor
gitea/salix/pipeline/head There was a failure building this commit Details
410e651edd
Buyer waste
gitea/salix/pipeline/head There was a failure building this commit Details
660842ca31
Osticket & waste refactor
gitea/salix/pipeline/head There was a failure building this commit Details
d7ab95fcc8
closure
gitea/salix/pipeline/head There was a failure building this commit Details
fe5eb3e13d
Changes
gitea/salix/pipeline/head There was a failure building this commit Details
5aec280adb
Closure migration
gitea/salix/pipeline/head There was a failure building this commit Details
7a7ad6ac5f
InvoiceOut_sendQueued
gitea/salix/pipeline/head There was a failure building this commit Details
3601881026
Client consumption queue
gitea/salix/pipeline/head There was a failure building this commit Details
ccec38ef97
Renamed table
gitea/salix/pipeline/head There was a failure building this commit Details
3b0f1efbf4
ACL's
gitea/salix/pipeline/head There was a failure building this commit Details
21bb95fc88
CSV refactor
gitea/salix/pipeline/head There was a failure building this commit Details
c177c0366d
Item PDF
gitea/salix/pipeline/head There was a failure building this commit Details
c8bad23621
Tests
gitea/salix/pipeline/head There was a failure building this commit Details
3dbd304217
Updated unit tests
gitea/salix/pipeline/head There was a failure building this commit Details
1598b6c703
Back unit tests
gitea/salix/pipeline/head There was a failure building this commit Details
eadff3fff9
Updated back unit tests
gitea/salix/pipeline/head There was a failure building this commit Details
0fc2801f2f
fix: te2e
gitea/salix/pipeline/head There was a failure building this commit Details
6a01aa0f9f
delete focus
gitea/salix/pipeline/head This commit looks good Details
21cf18f70c
jenkins testBack relaunch
gitea/salix/pipeline/head There was a failure building this commit Details
377a0f7228
Attachments refactor
gitea/salix/pipeline/head This commit is unstable Details
f256af3d02
Log host ip
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
98a2f79691
Run container on jenkins network
gitea/salix/pipeline/head This commit is unstable Details
13bfed6955
use jenkins network
gitea/salix/pipeline/head This commit is unstable Details
1534bdd188
Syntax error
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
b0dac6c12d
Use jenkins network
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
80d0b415ec
Host log
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
ee0938d7d6
Test
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
239c324eff
Log network settings
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
0fccae0113
Network ip address
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
0ad583f22f
Log host & port
gitea/salix/pipeline/head This commit is unstable Details
0502f9ebf0
Log port
gitea/salix/pipeline/head This commit looks good Details
e6512d00a1
Use port 3306
gitea/salix/pipeline/head This commit looks good Details
1cafbdab6e
Connect to docker network
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
627f0d762e
attach to network
gitea/salix/pipeline/head There was a failure building this commit Details
aa51fa1722
feat: check the client to edit is in vn.client and not in account.account
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
9644e1e5ec
Removed console.log
gitea/salix/pipeline/head This commit looks good Details
8468eda05a
run with network
gitea/salix/pipeline/head This commit looks good Details
6f8e2c8e79
Disabled junit
gitea/salix/pipeline/head This commit is unstable Details
3e4fb87f6b
fix: te2e
gitea/salix/pipeline/head This commit is unstable Details
f2407ceb0e
Removed focus
gitea/salix/pipeline/head This commit looks good Details
726b2d5eb2
Exit on completion
gitea/salix/pipeline/head This commit is unstable Details
26d655075e
fix: bad pull
gitea/salix/pipeline/head This commit looks good Details
df929c77ce
Test
gitea/salix/pipeline/head This commit looks good Details
edb02cccdd
fix: bad pull dev
gitea/salix/pipeline/head This commit looks good Details
076fce058c
Exit on completion
gitea/salix/pipeline/head There was a failure building this commit Details
45ccf782f8
3 workers
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
182d47f3ef
two workers
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
7844ae2795
3 workers
gitea/salix/pipeline/head This commit looks good Details
5fa96277ab
two workers
gitea/salix/pipeline/head There was a failure building this commit Details
3d36c0339a
Merge branch 'dev' into 4592-jenkins_tests
gitea/salix/pipeline/head There was a failure building this commit Details
68d7bc8e20
Test
gitea/salix/pipeline/head There was a failure building this commit Details
b8615fef46
Upgraded puppeteer
gitea/salix/pipeline/head There was a failure building this commit Details
045825b45d
Merge pull request '4592-jenkins_tests' (#1075) from 4592-jenkins_tests into dev
Reviewed-on: #1075
gitea/salix/pipeline/head This commit looks good Details
b134aeb0ea
Mock report pdf
gitea/salix/pipeline/head This commit looks good Details
fd219f853f
Merge branch 'dev' into 4581-client.web-access
gitea/salix/pipeline/head There was a failure building this commit Details
1bf090b6ee
Pass network name
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
954c4d5d85
Merge pull request '4581-client.web-access' (#1074) from 4581-client.web-access into dev
Reviewed-on: #1074
Reviewed-by: Joan Sanchez <joan@verdnatura.es>
gitea/salix/pipeline/head Something is wrong with the build of this commit Details
8f3e09b88f
Merge branch 'dev' into 4033-route
gitea/salix/pipeline/head This commit looks good Details
2cfc3cfe42
Merge pull request '4033-route' (#1050) from 4033-route into dev
Reviewed-on: #1050
Reviewed-by: Joan Sanchez <joan@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
11da463972
Renamed puppeteer method
gitea/salix/pipeline/head There was a failure building this commit Details
22187c1450
Enforce npm node version
joan merged commit dd9b517883 into dev 2022-10-06 11:30:52 +00:00
joan deleted branch 4369-ticket.request.create_getItemTypeWorker 2022-10-06 11:30:52 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1061
No description provided.