verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

refs #5250 campo de notes #1407

Merged
joan merged 12 commits from 5250-observacionesWorker into dev 2023-04-11 07:07:56 +00:00
Conversation 0 Commits 12 Files Changed 16 +274
carlossa commented 2023-03-23 07:40:24 +00:00
Member
Copy Link
No description provided.
carlossa added 1 commit 2023-03-23 07:40:25 +00:00
gitea/salix/pipeline/head This commit looks good Details
fde854f5c2 refs #5250 campo de notes
carlossa added 1 commit 2023-03-24 11:11:54 +00:00
gitea/salix/pipeline/head This commit looks good Details
c68c78cc5b refs #5250 solucion error WorkerObserv
carlossa changed title from WIP: refs #5250 campo de notes to refs #5250 campo de notes 2023-03-24 11:48:21 +00:00
carlossa requested review from jgallego 2023-03-24 11:48:36 +00:00
carlossa added 1 commit 2023-03-24 11:49:09 +00:00
gitea/salix/pipeline/head This commit looks good Details
b199ca4a6e Merge branch 'dev' into 5250-observacionesWorker
jgallego requested review from joan 2023-03-27 13:14:11 +00:00
jgallego approved these changes 2023-03-27 13:14:17 +00:00
joan requested changes 2023-03-28 05:09:47 +00:00
modules/worker/back/models/worker-observation.js Outdated
@ -0,0 +1,13 @@
module.exports = function(Self) {
Self.validate('text', isEnabled, {message: 'Description cannot be blank'});
joan commented 2023-03-28 05:07:03 +00:00
Contributor
Copy Link

Aci pots gastar Self.validatesPresenceOf

Aci pots gastar Self.validatesPresenceOf
carlossa commented 2023-03-28 08:08:34 +00:00
Author
Member
Copy Link

Actualitzat en la nova versió

Actualitzat en la nova versió
joan commented 2023-03-30 05:17:00 +00:00
Contributor
Copy Link

La funció isEnabled no es necesaria si gastes validatesPresenceOf(): Exemple

Self.validatesPresenceOf('name', {
        message: 'Name cannot be blank'
});
La funció isEnabled no es necesaria si gastes validatesPresenceOf(): Exemple ``` Self.validatesPresenceOf('name', { message: 'Name cannot be blank' }); ```
carlossa commented 2023-03-31 13:03:34 +00:00
Author
Member
Copy Link

Solucionat en la nova versió

Solucionat en la nova versió
modules/worker/front/routes.json
@ -73,2 +74,4 @@
"description": "Log",
"acl": ["salesAssistant"]
}, {
"url": "/note",
joan commented 2023-03-28 05:09:17 +00:00
Contributor
Copy Link

Veig un ACL per a HHRR, pero pareix que esta secció no te restriccions de accés. Es correcte?

Veig un ACL per a HHRR, pero pareix que esta secció no te restriccions de accés. Es correcte?
carlossa commented 2023-03-28 08:09:02 +00:00
Author
Member
Copy Link

Com se demana que siga com en el de clients, el accés es per a tots

Com se demana que siga com en el de clients, el accés es per a tots
carlossa added 2 commits 2023-03-28 08:07:42 +00:00
carlossa requested review from joan 2023-03-28 08:09:05 +00:00
joan requested changes 2023-03-30 05:17:55 +00:00
modules/worker/back/models/worker-observation.js Outdated
@ -0,0 +1,13 @@
module.exports = function(Self) {
Self.validatesPresenceOf('text', isEnabled, {message: 'Description cannot be blank'});
function isEnabled(err) {
joan commented 2023-03-30 05:17:46 +00:00
Contributor
Copy Link

La funció isEnabled no es necesaria si gastes validatesPresenceOf(): Exemple

Self.validatesPresenceOf('name', {
        message: 'Name cannot be blank'
});
La funció isEnabled no es necesaria si gastes validatesPresenceOf(): Exemple ``` Self.validatesPresenceOf('name', { message: 'Name cannot be blank' }); ```
carlossa added 63 commits 2023-03-31 12:48:53 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
be1993cf8b refs #5206 version with top-searcher and two fields for reference and id
gitea/salix/pipeline/head There was a failure building this commit Details
dbe42e3bf4 refs #5206 version with plane added, needs to implement general search
gitea/salix/pipeline/head There was a failure building this commit Details
ed5208c9e4 refs #5206 implemented general search, missing tests
gitea/salix/pipeline/head There was a failure building this commit Details
874fd0656c refs #5206 url gets params
gitea/salix/pipeline/head There was a failure building this commit Details
0248c3c9e0 refs #5056 models and tables added
gitea/salix/pipeline/head There was a failure building this commit Details
6a2542758b refs #5056 added fixtures
gitea/salix/pipeline/head This commit looks good Details
53bca1e8a3 refs #5056 added fixtures
gitea/salix/pipeline/head There was a failure building this commit Details
f706b66efc refs #5056 added divisible in wagonType
gitea/salix/pipeline/head This commit looks good Details
6609cce065 refs #5056 minHeightBetweenTrays
gitea/salix/pipeline/head There was a failure building this commit Details
1cd768f7b8 refs #5056 moved sql
gitea/salix/pipeline/head This commit looks good Details
9565bb33f2 refs #5425 modificacion de los campos
gitea/salix/pipeline/head There was a failure building this commit Details
9e42ab52ce refs #5425 modificación usuario
gitea/salix/pipeline/head There was a failure building this commit Details
f0f2a8c731 refs #5432 quitar comentario
gitea/salix/pipeline/head This commit looks good Details
1198ad3b01 refs #5056 wagonType backs and test
gitea/salix/pipeline/head There was a failure building this commit Details
b2cc79a98e Merge branch 'dev' into 5432-propiedadesBotonMas
gitea/salix/pipeline/head There was a failure building this commit Details
1ab8570ed3 Merge branch 'dev' into 5425-modCamposBasicos(pesoycaja)
gitea/salix/pipeline/head This commit looks good Details
3fcfc3d640 refs #5056 adding fixtures
gitea/salix/pipeline/head There was a failure building this commit Details
6738243534 refs #5206 added e2e
gitea/salix/pipeline/head There was a failure building this commit Details
74312a3cdf refs #5056 changed acl
gitea/salix/pipeline/head This commit looks good Details
0baccc4745 refs #5206 fix tests front
gitea/salix/pipeline/head This commit looks good Details
cfe4570d3b refs #5206 e2es fixed
gitea/salix/pipeline/head This commit looks good Details
925774c75b refs #5331 add changelog
gitea/salix/pipeline/head There was a failure building this commit Details
c65f01b689 refs #5416 delete: supplierAccount triggers
gitea/salix/pipeline/head This commit looks good Details
39af68c3dc Merge branch 'dev' into 5056-gestion-vagones
gitea/salix/pipeline/head This commit looks good Details
93a34d6235 fix e2e: cambiado el ticket id
gitea/salix/pipeline/head This commit looks good Details
4cc5bff914 delete focus
gitea/salix/pipeline/head This commit looks good Details
ec4b76a0f8 Merge pull request 'fix e2e: cambiado el ticket id' (!1413) from fix_e2e into dev 
Reviewed-on: #1413
Reviewed-by: Alexandre Riera <alexandre@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
6f2de903bc refs #5184 working on search panel
gitea/salix/pipeline/head This commit looks good Details
695444f6ae refs #5184 back and front tests added
gitea/salix/pipeline/head This commit looks good Details
69be91b964 refs #5184 fix back test, added e2e
gitea/salix/pipeline/head This commit looks good Details
4a84ceba53 Merge branch 'dev' into 5184-invoiceIn-serial
gitea/salix/pipeline/head There was a failure building this commit Details
bf5f1011e8 refs #5490 traducción corregida
gitea/salix/pipeline/head There was a failure building this commit Details
3ad85c0de3 refs #5184 subselect deleted
gitea/salix/pipeline/head There was a failure building this commit Details
9a713d2753 refs #5184 stmts removed
gitea/salix/pipeline/head There was a failure building this commit Details
8f2735e126 Merge pull request '5331-monitor.tickets_actualizarFiltro' (!1410) from 5331-monitor.tickets_actualizarFiltro into dev 
Reviewed-on: #1410
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
Reviewed-by: Alexandre Riera <alexandre@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
b0d205c4da refs #5464 fix: utiliza una sola cookie
gitea/salix/pipeline/head This commit looks good Details
b70acc5c46 Merge pull request '5464-hotfix_closeTicket' (!1416) from 5464-hotfix_closeTicket into master 
Reviewed-on: #1416
Reviewed-by: Joan Sanchez <joan@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
d5fd15224e fix(sqlConnector): handled malformed json parse 
Refs #4862
gitea/salix/pipeline/head This commit looks good Details
1258dd54b6 Merge pull request 'fix(sqlConnector): handled malformed json parse' (!1417) from 4862-sqlconnector_all into master 
Reviewed-on: #1417
Reviewed-by: Juan Ferrer <juan@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
14f64e8efa Merge branch 'dev' into 5416-supplierAccount_isPayMethodChecked
gitea/salix/pipeline/head This commit looks good Details
6366af9a15 Merge pull request 'refs #5490 traducción corregida' (!1415) from 5490-arregloExpedition into dev 
Reviewed-on: #1415
Reviewed-by: Carlos Andrés <carlosap@verdnatura.es>
Reviewed-by: Joan Sanchez <joan@verdnatura.es>
gitea/salix/pipeline/head Build queued... Details
30a4356139 Merge pull request 'fixes #5184 InvoiceIn crear seccion invoiceIn serial' (!1414) from 5184-invoiceIn-serial into dev 
Reviewed-on: #1414
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
cafb21d90b Merge pull request 'fixes #5206 travel buscador en el lateral' (!1384) from 5206-travel-buscadorLateral into dev 
Reviewed-on: #1384
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
Reviewed-by: Joan Sanchez <joan@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
6aca23e466 Merge pull request 'fixes #5056 Nuevo sistema de sacado de pedidos: Gestión de vagones' (!1386) from 5056-gestion-vagones into dev 
Reviewed-on: #1386
Reviewed-by: Joan Sanchez <joan@verdnatura.es>
carlossa requested review from joan 2023-03-31 13:03:41 +00:00
carlossa added 1 commit 2023-03-31 13:04:34 +00:00
gitea/salix/pipeline/head This commit looks good Details
9944e9a645 Merge branch 'dev' into 5250-observacionesWorker
joan approved these changes 2023-04-06 07:22:23 +00:00
joan requested changes 2023-04-06 07:23:23 +00:00
db/changes/231201/00-workerNotes.sql Outdated
@ -0,0 +1,14 @@
CREATE TABLE `vn`.`workerObservation` (
joan commented 2023-04-06 07:23:19 +00:00
Contributor
Copy Link

Mover a la versión 231401

Mover a la versión 231401
carlossa commented 2023-04-06 08:31:59 +00:00
Author
Member
Copy Link

solucionado en el nuevo commit

solucionado en el nuevo commit
carlossa added 3 commits 2023-04-06 07:34:58 +00:00
carlossa requested review from joan 2023-04-06 08:31:34 +00:00
carlossa added 1 commit 2023-04-06 08:32:44 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
b3f946e15f Merge branch 'dev' into 5250-observacionesWorker
joan approved these changes 2023-04-11 07:07:10 +00:00
joan merged commit 5732f9a33b into dev 2023-04-11 07:07:56 +00:00
joan deleted branch 5250-observacionesWorker 2023-04-11 07:07:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
joan
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1407
No description provided.
Delete Branch "5250-observacionesWorker"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?