verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 57 Releases Wiki Activity

refs #5816 Remove duplicated logs #1634

Merged
guillermo merged 14 commits from 5900-removeDuplicatedLogs into test 2023-06-29 13:35:50 +00:00
Conversation 0 Commits 14 Files Changed 32 +22 -680
juan commented 2023-06-25 17:08:53 +00:00
Owner
Copy Link
No description provided.
juan added 1 commit 2023-06-25 17:08:54 +00:00
gitea/salix/pipeline/head This commit looks good Details
e32a29fc09 refs #5900 Remove duplicated logs
juan requested review from jgallego 2023-06-25 17:09:03 +00:00
juan added 3 commits 2023-06-25 18:00:20 +00:00
gitea/salix/pipeline/head This commit looks good Details
d69cbe0ad4 refs #5900 Origin separator style fix
gitea/salix/pipeline/head This commit looks good Details
544445c4ae refs #5800 Origin separator style more clear
gitea/salix/pipeline/head This commit looks good Details
630ce40ef7 Merge branch 'test' into 5900-removeDuplicatedLogs
jgallego requested changes 2023-06-26 06:01:36 +00:00
modules/client/back/methods/client/sendSms.js Outdated
@ -40,4 +35,1 @@
const userId = ctx.req.accessToken.userId;
const sms = await models.Sms.send(ctx, destination, message);
const logRecord = {
jgallego commented 2023-06-26 05:45:34 +00:00
Owner
Copy Link

Esto lo pidieron para saber que a un cliente que info se le ha enviado, sobre todo durante el mismo dia

Esto lo pidieron para saber que a un cliente que info se le ha enviado, sobre todo durante el mismo dia
juan commented 2023-06-29 12:19:17 +00:00
Author
Owner
Copy Link

Se solucionará en la tarea https://redmine.verdnatura.es/issues/5934

Se solucionará en la tarea https://redmine.verdnatura.es/issues/5934
juan marked this conversation as resolved
modules/route/back/methods/route/updateVolume.js Outdated
@ -41,4 +39,1 @@
const updatedRoute = await models.Route.findById(id, null, myOptions);
await models.RouteLog.create({
jgallego commented 2023-06-26 05:43:37 +00:00
Owner
Copy Link

este se puso porque ellos necesitan saber si alguien ha ejecutado esa accion. Cual es la alternativa?

este se puso porque ellos necesitan saber si alguien ha ejecutado esa accion. Cual es la alternativa?
juan commented 2023-06-29 12:04:32 +00:00
Author
Owner
Copy Link

El procedimiento vn.routeUpdateM3 ya actualiza las rutas y ese registro ya se inserta con el log binario, además no se comprueba que si el nuevo valor es distinto del antiguo. Actualmente el log aparece duplicado.

El procedimiento `vn.routeUpdateM3` ya actualiza las rutas y ese registro ya se inserta con el log binario, además no se comprueba que si el nuevo valor es distinto del antiguo. Actualmente el log aparece duplicado.
juan marked this conversation as resolved
modules/ticket/back/methods/ticket-request/confirm.js Outdated
@ -97,22 +97,6 @@ module.exports = Self => {
});
await models.Chat.sendCheckingPresence(ctx, requesterId, message, myOptions);
const logRecord = {
jgallego commented 2023-06-26 06:01:34 +00:00
Owner
Copy Link

En este caso he hecho una prueba y no logea nada..

En este caso he hecho una prueba y no logea nada..
juan commented 2023-06-29 12:13:51 +00:00
Author
Owner
Copy Link

Esto ya se registra con el log binario y aparece duplicado.

Esto ya se registra con el log binario y aparece duplicado.
juan marked this conversation as resolved
guillermo added 11 commits 2023-06-26 08:06:50 +00:00
gitea/salix/pipeline/head This commit looks good Details
0afc26e20c refs #5728 remove add, quit e2e
gitea/salix/pipeline/head This commit looks good Details
9cdaf2e519 refs #5728 fix e2e buy
gitea/salix/pipeline/head This commit looks good Details
38de19f044 Merge branch 'dev' into 5728-bugEntry/buy
gitea/salix/pipeline/head This commit looks good Details
a173cb47f0 Merge branch 'dev' into 5728-bugEntry/buy
gitea/salix/pipeline/head This commit looks good Details
344ba298f8 refs #5832 232801 init
gitea/salix/pipeline/head This commit looks good Details
757360f3d1 Merge branch 'dev' into 5728-bugEntry/buy
gitea/salix/pipeline/head This commit looks good Details
cce837686d Merge pull request 'refs #5728 remove add, quit e2e' (!1598) from 5728-bugEntry/buy into dev 
Reviewed-on: #1598
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
2fec5bf2aa Merge pull request 'refs #5772 test into dev' (!1633) from test into dev 
Reviewed-on: #1633
gitea/salix/pipeline/head There was a failure building this commit Details
cc5021a75f refs #5684 Removed xxxLog.create and dependences
guillermo changed title from refs #5900 Remove duplicated logs to refs #5816Remove duplicated logs 2023-06-26 08:07:28 +00:00
guillermo changed title from refs #5816Remove duplicated logs to refs #5816 Remove duplicated logs 2023-06-26 08:07:31 +00:00
juan requested review from jgallego 2023-06-29 12:20:17 +00:00
jgallego approved these changes 2023-06-29 12:43:05 +00:00
jgallego added 32 commits 2023-06-29 12:43:20 +00:00
gitea/salix/pipeline/head There was a failure building this commit Details
b6c8ca20ee refs #5339 data
gitea/salix/pipeline/head This commit looks good Details
cea6fae649 fix: eliminada variable que no estaba definida
gitea/salix/pipeline/head This commit looks good Details
e99627c0b2 codigo innecesario
gitea/salix/pipeline/head This commit looks good Details
a4d3e8efd0 Merge pull request 'hotfix_errorEliminarTicket' (!1626) from hotfix_errorEliminarTicket into master 
Reviewed-on: #1626
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
aea32492e3 Merge branch 'master' into 5339_instance_vs_data
gitea/salix/pipeline/head This commit looks good Details
18a8106461 refs #5339 fix after save
gitea/salix/pipeline/head This commit looks good Details
207dcacf0f Merge pull request 'refs #5339 data' (!1623) from 5339_instance_vs_data into master 
Reviewed-on: #1623
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
c42b38c5cc refs #5900 Code clean, refactor & accurated
gitea/salix/pipeline/head This commit looks good Details
88e845b511 change applyFilters
gitea/salix/pipeline/head There was a failure building this commit Details
e980717d14 refs #5900, #5772 Changelog updated
gitea/salix/pipeline/head This commit looks good Details
ef8e1c4169 refs #5531 refs #5753 fix travelConfig sql
gitea/salix/pipeline/head This commit looks good Details
15c45bb544 Merge branch 'test' into hotfix-filterScopeDays
gitea/salix/pipeline/head This commit looks good Details
15e39b5fec Merge pull request 'change applyFilters' (!1636) from hotfix-filterScopeDays into test 
Reviewed-on: #1636
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
46ffd8d95a refs #5554 console.log
gitea/salix/pipeline/head This commit looks good Details
1cf5ff9a62 refs #5554 new Date()
gitea/salix/pipeline/head This commit looks good Details
8e5a6dbab3 fix warn
gitea/salix/pipeline/head This commit looks good Details
7e542f93a1 Merge branch 'test' into warnFix_travel_summary_entry
gitea/salix/pipeline/head This commit looks good Details
fe53abb24f Merge pull request 'fix warn' (!1641) from warnFix_travel_summary_entry into test 
Reviewed-on: #1641
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
f8a972c2f2 refs #5094 fix translation
gitea/salix/pipeline/head This commit looks good Details
12481b5f3d refs #5900 CSS fix
gitea/salix/pipeline/head This commit looks good Details
d200a1a695 refs #5900 CSS fixes
gitea/salix/pipeline/head This commit looks good Details
840a88bdc1 refs #5833 remove console.logs
gitea/salix/pipeline/head This commit looks good Details
1d993c74e5 refs #5590 fix total invoiceOut
gitea/salix/pipeline/head This commit looks good Details
79823605f6 refs #5554 fix: no te tira al hacer F5
gitea/salix/pipeline/head This commit looks good Details
1093d29fb6 Merge pull request 'test_hotfix_renewToken' (!1645) from test_hotfix_renewToken into test 
Reviewed-on: #1645
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
bc4058512a Merge branch 'test' into 5900-removeDuplicatedLogs
alexm approved these changes 2023-06-29 13:25:30 +00:00
guillermo merged commit 82e762ac09 into test 2023-06-29 13:35:50 +00:00
guillermo deleted branch 5900-removeDuplicatedLogs 2023-06-29 13:35:50 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
jgallego
alexm
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#1634
No description provided.
Delete Branch "5900-removeDuplicatedLogs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?