verdnatura/salix
verdnatura
/
salix
3
4
Fork 0
Code Issues Pull Requests 67 Releases Wiki Activity

3542-feat(ticket_sale): role restriction to create payBack #855

Merged
carlosjr merged 3 commits from 3542-ticket_sale_payback into dev 2022-01-25 15:30:07 +00:00
Conversation 0 Commits 3 Files Changed 5 +52 -4
alexm commented 2022-01-21 11:07:25 +00:00
Member
Copy Link
No description provided.
alexm added the
CR / Tests passed
Simple
 labels 2022-01-21 11:07:25 +00:00
alexm added 1 commit 2022-01-21 11:07:26 +00:00
gitea/salix/pipeline/head This commit looks good Details
6d9afd5f4c feat(ticket_sale): role restriction to create payBack
carlosjr requested changes 2022-01-21 13:47:02 +00:00
e2e/paths/05-ticket/01-sale/02_edit_sale.spec.js
@ -207,6 +207,10 @@ describe('Ticket Edit sale path', () => {
});
it('should select the third sale and create a pay back', async() => {
await page.loginAndModule('salesAssistant', 'ticket');
carlosjr commented 2022-01-21 13:42:36 +00:00
Contributor
Copy Link

would be better to split this test

it('should log in as salesAssistant and navigate to X place', async() => {
	...
});

it('should select the third sale and create a pay back', async() => {
	...
});

ie: this file's line 414 to 423
would be better to split this test it('should log in as salesAssistant and navigate to X place', async() => { ... }); it('should select the third sale and create a pay back', async() => { ... }); ie: this file's line 414 to 423
alexm marked this conversation as resolved
modules/ticket/back/methods/sale/payBack.js Outdated
@ -42,0 +45,4 @@
const isClaimManager = await Self.app.models.Account.hasRole(userId, 'claimManager');
const isSalesAssistant = await Self.app.models.Account.hasRole(userId, 'salesAssistant');
const checkRoles = isClaimManager || isSalesAssistant;
carlosjr commented 2022-01-21 13:44:33 +00:00
Contributor
Copy Link

hasValidRole
isValidRole
canPerformSomeAction
hasEligibleRole
isEligible

try boolean names

hasValidRole isValidRole canPerformSomeAction hasEligibleRole isEligible try boolean names
alexm marked this conversation as resolved
modules/ticket/back/methods/sale/specs/payBack.spec.js Outdated
@ -0,0 +26,4 @@
}
});
it('should throw error for not have privileges', async() => {
carlosjr commented 2022-01-21 13:45:40 +00:00
Contributor
Copy Link

should throw an error if the user doesn't have privileges to create a pay back

`should throw an error if the user doesn't have privileges to create a pay back`
alexm marked this conversation as resolved
alexm changed title from 3542-feat(ticket_sale): role restriction to create payBack to WIP: 3542-feat(ticket_sale): role restriction to create payBack 2022-01-24 08:34:51 +00:00
alexm removed the
CR / Tests passed
Simple
 labels 2022-01-24 08:34:59 +00:00
alexm added 2 commits 2022-01-25 14:09:44 +00:00
gitea/salix/pipeline/head This commit looks good Details
f67a4355db refactor(ticket_sale): split e2e, change name backTest
alexm changed title from WIP: 3542-feat(ticket_sale): role restriction to create payBack to 3542-feat(ticket_sale): role restriction to create payBack 2022-01-25 14:11:44 +00:00
alexm added the
CR / Tests passed
 label 2022-01-25 14:11:52 +00:00
alexm requested review from carlosjr 2022-01-25 14:19:12 +00:00
carlosjr approved these changes 2022-01-25 15:29:57 +00:00
carlosjr left a comment
Contributor
Copy Link

LGTM

LGTM
carlosjr merged commit 16fe26a2ab into dev 2022-01-25 15:30:07 +00:00
carlosjr deleted branch 3542-ticket_sale_payback 2022-01-25 15:30:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carlosjr
Labels
Clear labels   
CR / Tests passed

Unit tests and e2e passed

  
e2e

Implement e2e

  
Missing tests

Missing tests

  
Needs refactor

   
Simple

Simple check / No CR needed

No Label
CR / Tests passed
e2e
Missing tests
Needs refactor
Simple
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#855
No description provided.
Delete Branch "3542-ticket_sale_payback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?