2883-invoiceIn-Booking #786
No reviewers
Labels
No Milestone
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: verdnatura/salix#786
Loading…
Reference in New Issue
No description provided.
Delete Branch "2883-invoiceIn-Booking"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
2883-invoiceIn-Bookingto WIP: 2883-invoiceIn-BookingWIP: 2883-invoiceIn-Bookingto 2883-invoiceIn-Booking@ -211,5 +211,6 @@
"Can't verify data unless the client has a business type": "No se puede verificar datos de un cliente que no tiene tipo de negocio",
"You don't have enough privileges to set this credit amount": "No tienes suficientes privilegios para establecer esta cantidad de crédito",
"You can't change the credit set to zero from a manager": "No puedes cambiar el cŕedito establecido a cero por un gerente",
"Amounts do not match": "Amounts do not match",
this should be in spanish
@ -0,0 +26,4 @@
if (typeof options == 'object')
Object.assign(myOptions, options);
if (!myOptions.transaction) {
creating transaction on a read methods is required.
is not* required
@ -0,0 +32,4 @@
}
try {
return (await Self.rawSql(`
It is easier for code maintenance to extract values to constants or variables
@ -0,0 +45,4 @@
WHERE
ii.id = ?`, [id, id]))[0];
} catch (e) {
if (tx) await tx.rollback();
endpoints that don't create transactions should not attempt to rollback.
(also the commit was missing)
@ -0,0 +9,4 @@
try {
const invoiceIntotals = await models.InvoiceIn.getTotals(invoiceInId, options);
expect(invoiceIntotals.totalTaxableBase).toEqual(invoiceIntotals.totalDueDay);
will this fail if both properties are undefined?
@ -89,3 +91,1 @@
let summaryObj = await Self.app.models.InvoiceIn.findById(id, filter, myOptions);
summaryObj.totals = await getTotals(id);
summaryObj.totals = await models.InvoiceIn.getTotals(id);
doesn't getTotal expect a transaction?
@ -52,2 +52,4 @@
.then(res => this.entity = res.data);
}
checktoBook() {
function naming must be in lowerCamelCase
@ -0,0 +38,4 @@
WHERE
ii.id = ?`, [id, id]);
return (result);
remove the ()
@ -21,0 +37,4 @@
});
describe('checkToBook()', () => {
it(`should show both warning messages`, () => {
the description of the test states two warning messages will be shown but the test doesn't check that
LGTM