#2687 - Fix Travel_cloneWithEntries #2021

Merged
jsegarra merged 9 commits from 2687_fix_travel_cloneWithEntries into test 2024-02-15 07:34:50 +00:00
Member
No description provided.
jsegarra added 2 commits 2024-02-12 07:45:40 +00:00
jsegarra changed title from WIP: #2687 - Fix Travel_cloneWithEntries to #2687 - Fix Travel_cloneWithEntries 2024-02-12 07:45:46 +00:00
jsegarra requested review from alexm 2024-02-12 07:45:49 +00:00
jsegarra reviewed 2024-02-12 07:46:43 +00:00
@ -31,0 +30,4 @@
await models.Entry.destroyAll({
travelFk: newTravelId
}, options);
await models.Travel.destroyById(newTravelId, options);
Author
Member

Comentario de Alex: Aunque fasa rollback cal borrar les entrades i el travel???

Comentario de Alex: Aunque fasa rollback cal borrar les entrades i el travel???
Author
Member

Si, no hace rollback de las líneas clonadas

Si, no hace rollback de las líneas clonadas
alexm marked this conversation as resolved
alexm approved these changes 2024-02-13 09:00:28 +00:00
Dismissed
alexm requested changes 2024-02-13 09:05:21 +00:00
alexm left a comment
Member

Falta pasar de "versions" a archivos

Falta pasar de "versions" a archivos
jsegarra added 400 commits 2024-02-14 07:52:24 +00:00
gitea/salix/pipeline/head This commit looks good Details
3e522b08b6
refs #6184 Added saveCmr
gitea/salix/pipeline/head This commit looks good Details
d9339af87e
refs #6184 Insert in ticketCmr
gitea/salix/pipeline/head This commit looks good Details
c0089b1fa0
refs #6184 Added cmrFk in ticket model
gitea/salix/pipeline/head This commit looks good Details
3e70cb07e0
refs #6184 Changes
gitea/salix/pipeline/head This commit looks good Details
c79f706cdc
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head Build queued... Details
2cdebcd69f
check bank entity refs 5834
gitea/salix/pipeline/head There was a failure building this commit Details
0536486b8c
ref #5834 fix locale
gitea/salix/pipeline/head This commit looks good Details
0771548ef1
refs #6184 Requested changes
gitea/salix/pipeline/head This commit looks good Details
05a7498219
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head This commit looks good Details
2792efa9cd
perf: refs #6184 Requested changes
gitea/salix/pipeline/head This commit looks good Details
64ca72b1f4
refactor refs #6184 Changed downloadCmrsZip
gitea/salix/pipeline/head This commit looks good Details
4003e161ce
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head There was a failure building this commit Details
a89d1e883a
create rectification: refs #4466
gitea/salix/pipeline/head There was a failure building this commit Details
567879d64e
corrective back created: refs #4466
gitea/salix/pipeline/head There was a failure building this commit Details
b087f84629
Merge branch 'dev' into 4466-invoiceInRectificated
gitea/salix/pipeline/head There was a failure building this commit Details
fe4c529bfe
refs #5834 perf: remove front code
gitea/salix/pipeline/head There was a failure building this commit Details
f1b84ee7a0
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head There was a failure building this commit Details
45fd96cee6
feat: #6184 Modified uploadFile
gitea/salix/pipeline/head This commit looks good Details
1a52e58eaa
feat: #6184 Created generateCmrPdf
gitea/salix/pipeline/head There was a failure building this commit Details
85a0f8b323
feat: #6184 Minor change
gitea/salix/pipeline/head There was a failure building this commit Details
a486b7f2d4
feat: #6184 Minor change
gitea/salix/pipeline/head There was a failure building this commit Details
23b8703afc
refs #6397 emailValidation
gitea/salix/pipeline/head There was a failure building this commit Details
ce5a2ada62
feat: #6184 Requested changes
gitea/salix/pipeline/head This commit looks good Details
9faf889833
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head This commit looks good Details
7cb7c7dace
refs #6397 back validation
gitea/salix/pipeline/head This commit looks good Details
e9c1f125a5
refs #6397 test back
gitea/salix/pipeline/head There was a failure building this commit Details
391f418883
refs #6397 fix test back
gitea/salix/pipeline/head This commit looks good Details
73e1b52348
refs #6397 refactor
gitea/salix/pipeline/head There was a failure building this commit Details
6701f70a33
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head There was a failure building this commit Details
cf03982d0c
refs #6397 trad tback
gitea/salix/pipeline/head There was a failure building this commit Details
43bfb3cfde
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head This commit looks good Details
540c76005e
fix: #6742 calcula hasIncoterm a partir de la serie
gitea/salix/pipeline/head There was a failure building this commit Details
9005975f1c
feat: #6184 Modified email cmr
gitea/salix/pipeline/head There was a failure building this commit Details
ed77347fe1
fix: #6557 replace procedure
gitea/salix/pipeline/head This commit looks good Details
e5d466b697
fix: refs #6703 drop & replace sale refund by clone
gitea/salix/pipeline/head This commit looks good Details
5828fa9657
feat: #6184 Refactor saveSign
gitea/salix/pipeline/head This commit looks good Details
dec795d902
feat: #6184 Minor changes
gitea/salix/pipeline/head This commit looks good Details
d5a145ba1b
feat: #6184 Minor changes
gitea/salix/pipeline/head There was a failure building this commit Details
e33861a80d
fix: refs #6703 filter
gitea/salix/pipeline/head There was a failure building this commit Details
25fa154f60
feat: #6184 Minor changes
gitea/salix/pipeline/head There was a failure building this commit Details
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
ab3fdf4fe4
fix: refs #6703 remove console log
gitea/salix/pipeline/head Build queued... Details
567e480e3b
feat: #6184 Minor changes
gitea/salix/pipeline/head This commit looks good Details
49a08a96da
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head There was a failure building this commit Details
4fc780967f
fix: refs #6703 tests
gitea/salix/pipeline/head This commit looks good Details
65756f98ad
fix: #6184 Minor changes
gitea/salix/pipeline/head There was a failure building this commit Details
eb208edacc
feat: refs #6371 pasar vn2008 a vn part1
gitea/salix/pipeline/head This commit looks good Details
04f1a03d4d
refs #6397 fix back
gitea/salix/pipeline/head There was a failure building this commit Details
ed43b6be2d
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head This commit looks good Details
f14c239391
Merge branch 'dev' into 6397-emailValidation
gitea/salix/pipeline/head There was a failure building this commit Details
94cc3ad80e
Merge branch 'dev' into 6397-emailValidation
gitea/salix/pipeline/head There was a failure building this commit Details
9b8c58ba7d
refs #6270 makeInvoice
gitea/salix/pipeline/head This commit looks good Details
65268487b9
fix: #6184 Now creates only one dms in saveSign
gitea/salix/pipeline/head This commit looks good Details
1fe6818a0f
fix: #6184 Minor changes
gitea/salix/pipeline/head There was a failure building this commit Details
05163bd5a7
feat: refs #6371 table vn2008 to vn
gitea/salix/pipeline/head This commit looks good Details
3a9eb100a1
feat: refs #6371 table vn2008 to vn
gitea/salix/pipeline/head This commit looks good Details
0f3ffcfa61
fix: refs #6184 Upload sign
gitea/salix/pipeline/head There was a failure building this commit Details
13b8964e3d
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head This commit looks good Details
34f7345315
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head This commit looks good Details
1e56e741e2
fix: #6184 Requested changes
gitea/salix/pipeline/head There was a failure building this commit Details
7cf46fc6cd
incluye fecha de ayer
gitea/salix/pipeline/head There was a failure building this commit Details
fe48e27cce
Merge branch 'dev' into 6371-limpiezaTablasVn2008Part1
gitea/salix/pipeline/head There was a failure building this commit Details
ae7fb12b53
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
3d6797d3ba
feat: #6567 sin fixtures
gitea/salix/pipeline/head There was a failure building this commit Details
edfb90813a
Merge branch 'dev' into 6397-emailValidation
gitea/salix/pipeline/head There was a failure building this commit Details
1124722b25
nuevo commit de prueba
gitea/salix/pipeline/head There was a failure building this commit Details
gitea/salix/pipeline/pr-dev This commit looks good Details
a6c0bf8766
Merge branch 'dev' into 6686-Limpieza-vistas-esquema-vn2008-part3
gitea/salix/pipeline/head There was a failure building this commit Details
c226c3f2e3
Merge branch 'dev' into 6752-edi.ekt_scan-improved
gitea/salix/pipeline/head There was a failure building this commit Details
a46c3c4d95
refs #5802 feat:ticket_setState
gitea/salix/pipeline/head There was a failure building this commit Details
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
da2a2b5f09
refs #6444 Remove vn2008.intrastat_neto function
gitea/salix/pipeline/head There was a failure building this commit Details
bd990cf105
Merge branch 'dev' into 6371-limpiezaTablasVn2008Part1
gitea/salix/pipeline/head There was a failure building this commit Details
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
7ebdf59d97
Merge branch 'dev' into 5834-billingDataAutoFillBic
gitea/salix/pipeline/head There was a failure building this commit Details
7e7ab3e8b6
fix(triggers): refs #4515 fix error
gitea/salix/pipeline/head This commit looks good Details
509d5cea14
refs #6270 fix back
gitea/salix/pipeline/head This commit looks good Details
f6607f6533
build: refs #6706 hook test
gitea/salix/pipeline/head This commit looks good Details
825ee76797
build: refs #6706 hook test
gitea/salix/pipeline/head This commit looks good Details
2222926488
build: refs #6706 hook test
gitea/salix/pipeline/head This commit looks good Details
bd1ac5f41e
build: refs #6706 hook test
gitea/salix/pipeline/head This commit looks good Details
826c8ff682
Merge branch 'dev' into 6371-limpiezaTablasVn2008Part1
gitea/salix/pipeline/head This commit looks good Details
6a29e97fc6
Merge branch 'dev' into 6752-edi.ekt_scan-improved
gitea/salix/pipeline/head This commit looks good Details
4bf08ea147
refs #5890 feat:reserves
gitea/salix/pipeline/head This commit looks good Details
141c3d6f6e
Merge branch 'dev' into 6270-electronicInvoiceBack
gitea/salix/pipeline/head This commit looks good Details
aba0d97106
feat: refs#5167 Update
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
a5e5a0d45d
feat: #6749 se mira la vida para buscar dias en el pasado
gitea/salix/pipeline/head There was a failure building this commit Details
a47276c86a
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head This commit looks good Details
0d438e7f4c
Merge branch 'dev' into 5802_setState
gitea/salix/pipeline/head There was a failure building this commit Details
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
18772c04f6
feat: refs #5167 update
gitea/salix/pipeline/head This commit looks good Details
57c5c510ff
Merge branch 'dev' into 6371-limpiezaTablasVn2008Part1
gitea/salix/pipeline/head This commit looks good Details
bbf50995c7
Merge branch 'dev' into 6270-electronicInvoiceBack
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
b8b2e1c507
Merge branch 'dev' into 6752-edi.ekt_scan-improved
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
65a30224f5
Merge branch 'dev' into 5802_setState
gitea/salix/pipeline/pr-dev This commit looks good Details
650f85c737
Merge branch 'dev' into 4515-addBuyCheck
gitea/salix/pipeline/pr-dev This commit looks good Details
cbdb089562
Merge branch 'dev' into 6397-emailValidation
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
3a9c5c90d4
Merge branch 'dev' into 6270-electronicInvoiceBack
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
aa993e7386
refs #6757 fix back, fix upperCase, fix e2e back
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
805a7f65e7
Merge branch 'dev' into 6371-limpiezaTablasVn2008Part1
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
a2e076e94f
Merge branch 'dev' of https://gitea.verdnatura.es/verdnatura/salix into 6703-refactorSaleRefund
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
3fa49a259c
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/pr-dev Something is wrong with the build of this commit Details
bb91035b77
refs #6703 try
gitea/salix/pipeline/pr-dev This commit looks good Details
b091e2467c
build: refs #6706 hook test
gitea/salix/pipeline/pr-dev This commit looks good Details
138cb7627d
Merge branch 'dev' into 6780-changeViewDependencesVn2008
gitea/salix/pipeline/pr-dev This commit looks good Details
36e8840e6e
Merge branch 'dev' into 6757-supplierMayus
gitea/salix/pipeline/pr-dev This commit looks good Details
a7a9276584
Merge branch 'dev' into 6757-supplierMayus
gitea/salix/pipeline/pr-dev This commit looks good Details
91c3c8f04d
Merge branch 'dev' into 6270-electronicInvoiceBack
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
e56e5905c2
Merge branch 'dev' into 6757-supplierMayus
gitea/salix/pipeline/pr-dev This commit looks good Details
6576bab305
Merge branch 'dev' into 6397-emailValidation
gitea/salix/pipeline/pr-dev This commit looks good Details
ff2328fd25
Merge branch 'dev' into 6371-limpiezaTablasVn2008Part1
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
7b1a0e1957
refs #6444 change code according to sql conventions
gitea/salix/pipeline/pr-dev This commit looks good Details
603d8e3d92
build: refs #6706 hook test
gitea/salix/pipeline/head This commit looks good Details
39f0e8b431
refs #6783 deploy: init version
gitea/salix/pipeline/head This commit looks good Details
0852d21ee6
refs #6783 deploy: init version
gitea/salix/pipeline/pr-dev This commit looks good Details
9a084d225c
Merge branch 'dev' into 6567-cambiar-articulos
gitea/salix/pipeline/head This commit looks good Details
d020086255
Merge pull request '6567-cambiar-articulos' (!1966) from 6567-cambiar-articulos into dev
Reviewed-on: #1966
Reviewed-by: Carlos Andrés <carlosap@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
92169adac7
Merge branch 'dev' into 5802_setState
gitea/salix/pipeline/pr-dev This commit looks good Details
c56073c123
Merge branch 'dev' into 6397-emailValidation
gitea/salix/pipeline/head This commit looks good Details
e59ab6fd97
Merge pull request 'refs #6397 emailValidation' (!1941) from 6397-emailValidation into dev
Reviewed-on: #1941
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
837b9e6dea
Merge branch 'dev' into 6752-edi.ekt_scan-improved
gitea/salix/pipeline/pr-dev This commit looks good Details
aba88c812e
build: refs #6706 Jenkinsfile globals
gitea/salix/pipeline/pr-dev This commit looks good Details
056ddbd9ae
build: refs #6706 Jenkinsfile test
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
2180045848
build: refs #6706 Jenkinsfile test
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
76785b99b1
build: refs #6706 Jenkinsfile test
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
3356691124
build: refs #6706 Jenkinsfile test
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
6a27b752e2
build: refs #6706 Jenkinsfile test
gitea/salix/pipeline/pr-dev This commit looks good Details
eb32b6daa2
build: refs #6706 Jenkinsfile fixes
gitea/salix/pipeline/pr-dev This commit looks good Details
d7b15d3221
build: refs #6706 Jenkinsfile fixes
gitea/salix/pipeline/pr-dev This commit looks good Details
c35bbc3c9d
build: refs #6706 Jenkinsfile fixes
gitea/salix/pipeline/pr-dev This commit looks good Details
93982bf160
Merge branch 'dev' into 6706-optimizeHooks
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
9ac0ffb85a
Merge branch 'dev' into 6270-electronicInvoiceBack
gitea/salix/pipeline/head There was a failure building this commit Details
5bc67333dc
Merge pull request '5802_setState' (!1969) from 5802_setState into dev
Reviewed-on: #1969
Reviewed-by: Carlos Andrés <carlosap@verdnatura.es>
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
855b590918
Merge branch 'dev' into 6270-electronicInvoiceBack
gitea/salix/pipeline/pr-dev This commit looks good Details
35f047d4b9
Merge branch 'dev' into 6780-changeViewDependencesVn2008
gitea/salix/pipeline/pr-dev This commit looks good Details
1155c8d309
Merge branch 'dev' into 4515-addBuyCheck
gitea/salix/pipeline/head There was a failure building this commit Details
2a29d68677
Merge pull request 'incluye fecha de ayer' (!1965) from 6752-edi.ekt_scan-improved into dev
Reviewed-on: #1965
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
58daf4754b
Merge branch 'dev' into 4515-addBuyCheck
gitea/salix/pipeline/pr-dev This commit looks good Details
7aea165fb7
Merge branch 'dev' into 6780-changeViewDependencesVn2008
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1d596b63a0
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
eec36300ad
refactor: refs #6184 Minor changes
gitea/salix/pipeline/head There was a failure building this commit Details
770584cdad
Merge pull request 'refactor: refs #6780 Changed dependences from vn2008 to vn' (!1987) from 6780-changeViewDependencesVn2008 into dev
Reviewed-on: #1987
Reviewed-by: Carlos Andrés <carlosap@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
232f46be90
Merge branch 'dev' into 4515-addBuyCheck
gitea/salix/pipeline/head There was a failure building this commit Details
986d3532ed
Merge pull request '4515-addBuyCheck' (!1974) from 4515-addBuyCheck into dev
Reviewed-on: #1974
gitea/salix/pipeline/head This commit looks good Details
bca15cc796
fix: refs #5483 Fix version
gitea/salix/pipeline/pr-dev This commit looks good Details
6f5b03195b
Merge branch 'dev' into 6371-limpiezaTablasVn2008Part1
gitea/salix/pipeline/head There was a failure building this commit Details
d9b6093738
Merge pull request '6371-limpiezaTablasVn2008Part1' (!1964) from 6371-limpiezaTablasVn2008Part1 into dev
Reviewed-on: #1964
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
2fca40b324
fix: refs #6371 Fixed version
gitea/salix/pipeline/head This commit looks good Details
42bf3db629
fix: refs #6371 Fixed version x2
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
743f317b20
fix: refs #4466 test & sql
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1ffbb30d77
refs #6689 feat: delete view vn2008
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1d0fd0ad4f
fix: refs #6706 Jenkinsfile fixes
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
3c642fb838
Merge branch 'dev' into 6689-deleteViewsVn2008-6
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
518d057cf3
refs #6686 feat: Delete views vn2008
gitea/salix/pipeline/pr-dev This commit looks good Details
0bd4602568
refs #6445 remove red function and modify precedures
gitea/salix/pipeline/pr-dev Build queued... Details
2a6dc0c478
fix: refs #4466 spaces
gitea/salix/pipeline/head This commit looks good Details
c3aeaf4da7
fix: refs #6371 Versions fixed
gitea/salix/pipeline/pr-dev This commit looks good Details
2994a303b9
ci: refs#6706 Use pnpm in Jenkins & Docker
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
1c538d58c2
ci: refs#6706 Jenkinsfile refactor
gitea/salix/pipeline/pr-dev This commit looks good Details
0669a3db28
ci: refs#6706 Jenkinsfile fixes
gitea/salix/pipeline/pr-dev This commit looks good Details
d78c8aef40
ci: refs#6706 Jenkinsfile tuning
gitea/salix/pipeline/pr-dev This commit looks good Details
9cda07bc5a
ci: refs#6706 Jenkinsfile tuning
gitea/salix/pipeline/pr-dev This commit looks good Details
766008ce1a
ci: refs#6706 Jenkinsfile tuning
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
fd7e16522f
ci: refs#6706 Jenkinsfile fixes
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
4b0b4797ad
Merge branch 'dev' into 6689-deleteViewsVn2008-6
gitea/salix/pipeline/pr-dev This commit looks good Details
e704f2eaf7
feat: refs #6689 Deleted view vn2008
gitea/salix/pipeline/head This commit looks good Details
3bf4fb3c98
Merge pull request 'refs #6689 feat: delete view vn2008' (!1992) from 6689-deleteViewsVn2008-6 into dev
Reviewed-on: #1992
Reviewed-by: Carlos Satorres <carlossa@verdnatura.es>
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
22f9d7d7a2
Merge branch 'dev' into 5834-billingDataAutoFillBic
gitea/salix/pipeline/head This commit looks good Details
f5108a911f
Merge pull request 'feat: refs #6686 Eliminar vistas vn2008' (!1967) from 6686-Limpieza-vistas-esquema-vn2008-part3 into dev
Reviewed-on: #1967
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
592e5c877f
Merge branch 'dev' into 5167-kk-warehouseAlias-y-warehouseJoined
gitea/salix/pipeline/head This commit looks good Details
045dfa2aa1
Merge pull request 'test' (!1995) from test into dev
Reviewed-on: #1995
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
f4591aae85
feat: refs #5167 Restaurar zoneEstimatedDelivery
gitea/salix/pipeline/pr-dev This commit looks good Details
c16be228e3
Merge branch 'dev' into 6270-electronicInvoiceBack
gitea/salix/pipeline/pr-dev This commit looks good Details
1a869766b9
refs #6444 change code accord to conventions
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
fdd4947401
Merge branch 'dev' into 6742-incoterm-error
gitea/salix/pipeline/head This commit looks good Details
810df2ab95
Merge pull request 'refs #6270 makeInvoice' (!1963) from 6270-electronicInvoiceBack into dev
Reviewed-on: #1963
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
9ee01e2bc2
Merge pull request '#6703 refactor saleRefund' (!1954) from 6703-refactorSaleRefund into dev
Reviewed-on: #1954
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
13021180e1
Merge pull request '#6557 replace getSubordinates for WorkerGetHierach' (!1952) from 6557-useWorkerGetHierarch into dev
Reviewed-on: #1952
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
05478b43f2
fix: refs #4466 test back
gitea/salix/pipeline/pr-dev This commit looks good Details
99fbb95669
fix: refs #6703 test back
gitea/salix/pipeline/head This commit looks good Details
b5ad85dbb5
Merge pull request '#6703 fix test back' (!1997) from 6703-fixTestBack into dev
Reviewed-on: #1997
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
43c245b45b
Merge branch 'dev' into 6706-optimizeHooks
gitea/salix/pipeline/head There was a failure building this commit Details
0ae1d6c546
Merge pull request 'build: refs #6706 Migration to pnpm' (!1990) from 6706-optimizeHooks into dev
Reviewed-on: #1990
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
cfcfa489b4
ci: refs#6706 Jenkinsfile & deps fixes
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
a0c5b1fff6
feat: refs # test corrective & clone
gitea/salix/pipeline/pr-dev This commit looks good Details
5c9589ba7b
Merge branch 'dev' into 6742-incoterm-error
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
9247a802bd
refs #6665 delete unused views
gitea/salix/pipeline/head This commit looks good Details
33c96df0b1
ci: refs#6706 Dockerfile fixes
gitea/salix/pipeline/pr-dev This commit looks good Details
6fb198f579
refs #6665 revoke permissions
gitea/salix/pipeline/pr-dev This commit looks good Details
980f2e61b1
Merge branch 'dev' into 6742-incoterm-error
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev This commit looks good Details
0b12576d2f
Merge pull request '#6742-incoterm-error' (!1989) from 6742-incoterm-error into dev
Reviewed-on: #1989
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
d6ae1fd1f8
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/pr-dev This commit looks good Details
147721642b
Merge branch 'dev' into 6749-disponible-sin-dar-vida
gitea/salix/pipeline/head This commit looks good Details
ebf80a4eb9
Merge pull request 'feat: #6749 se mira la vida para buscar dias en el pasado' (!1978) from 6749-disponible-sin-dar-vida into dev
Reviewed-on: #1978
Reviewed-by: Pako Natek <pako@verdnatura.es>
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
f2946e4168
fix: refs #6184 Requested changes
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
92abc3fb78
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/pr-dev This commit looks good Details
9f6807204d
feat: refs #5167 changes required
gitea/salix/pipeline/pr-dev This commit looks good Details
f7a93a7ccb
Merge branch 'dev' into 4466-invoiceInRectificated
gitea/salix/pipeline/head There was a failure building this commit Details
f67b5fabe6
Merge branch 'test' into dev
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev This commit looks good Details
a72acbb08f
fix: refs# 6642 Bug apply version
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
438af34d73
refs #6444 cambio vUnits por vStems
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev This commit looks good Details
67f29b2d1a
Merge pull request '#4466 InvoiceIn Rectification' (!1902) from 4466-invoiceInRectificated into dev
Reviewed-on: #1902
Reviewed-by: Carlos Andrés <carlosap@verdnatura.es>
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
5729ba90d1
Merge branch 'dev' into 6445-Remove-Vn2008.red-Function
gitea/salix/pipeline/head This commit looks good Details
0d0896758c
Merge pull request 'refs #6445 remove red function and modify precedures' (!1998) from 6445-Remove-Vn2008.red-Function into dev
Reviewed-on: #1998
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
3c140266f4
Merge pull request 'refs #6665 delete unused views' (!1999) from refs-#6665-Clean-Views-vn2008-(1/9) into dev
Reviewed-on: #1999
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
7ebb9cb429
feat: refs #5167 change required
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
6002c6cd7a
refs #6757 fix trad
gitea/salix/pipeline/pr-dev Build queued... Details
a949c25860
feat refs #5167 changes required
gitea/salix/pipeline/head This commit looks good Details
863b37384f
Merge pull request 'feat: refs#5167 Update' (!1976) from 5167-kk-warehouseAlias-y-warehouseJoined into dev
Reviewed-on: #1976
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
409bf9649f
Merge branch 'dev' into 6757-supplierMayus
gitea/salix/pipeline/head This commit looks good Details
78232866c9
Merge pull request 'refs #6757 fix back, fix upperCase, fix e2e back' (!1985) from 6757-supplierMayus into dev
Reviewed-on: #1985
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
50af5154f4
ci: refs#6706 Jenkinsfile load environemnt
gitea/salix/pipeline/head There was a failure building this commit Details
e581247954
ci: refs#6706 Jenkinsfile load properties from config
gitea/salix/pipeline/head There was a failure building this commit Details
4af454edd4
ci: refs#6706 Jenkinsfile debug
gitea/salix/pipeline/head This commit looks good Details
28168130ae
ci: refs#6706 Jenkinsfile fixes
gitea/salix/pipeline/head There was a failure building this commit Details
19080e348a
ci: refs#6706 Jenkinsfile print properties
gitea/salix/pipeline/head There was a failure building this commit Details
5c48d8c6b9
ci: refs#6706 Jenkinsfile fixes
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
2cab007f57
fix: refs #6184 Requested changes
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
f4feb6e8b7
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head This commit looks good Details
4067108258
ci: refs#6706 Jenkinsfile fixes
gitea/salix/pipeline/head There was a failure building this commit Details
4c123247d8
ci: refs#6706 Jenkinsfile fixes
gitea/salix/pipeline/head This commit looks good Details
9c2ec2b8dd
ci: refs#6706 Jenkinsfile fixes
gitea/salix/pipeline/head This commit looks good Details
f909c648a7
ci: refs#6706 Jenkinsfile fixes
gitea/salix/pipeline/head This commit looks good Details
4592429b3d
Merge pull request '6444-MigrateVn2008.intrastat_netoFunctionToVn' (!1972) from 6444-MigrateVn2008.intrastat_netoFunctionToVn into dev
Reviewed-on: #1972
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
4d6e631fca
Merge branch 'dev' into 5834-billingDataAutoFillBic
gitea/salix/pipeline/head There was a failure building this commit Details
a8a5ddd889
Merge pull request '#5834 - billingDataAutoFillBic' (!1821) from 5834-billingDataAutoFillBic into dev
Reviewed-on: #1821
gitea/salix/pipeline/head This commit looks good Details
a67a347a9e
ci: refs#6706 CI fixes
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev This commit looks good Details
46dee65e68
ci: refs#6706 Myt updated
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
87864593b2
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/pr-dev This commit looks good Details
aff8ee28ea
fix: refs #6272 back & create test
gitea/salix/pipeline/pr-dev This commit looks good Details
ffa9212861
fix: refs #6184 Requested changes
gitea/salix/pipeline/head This commit looks good Details
bdfbb8f6f7
build: refs#6706 gulp install fixed, myt updated
gitea/salix/pipeline/head This commit looks good Details
eda85eda76
ci: refs#6706 Jenkinsfile fixes
gitea/salix/pipeline/head This commit looks good Details
c4907d1a33
ci: refs#6706 Jenkinsfile fixes
gitea/salix/pipeline/pr-dev This commit looks good Details
21d047c21f
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head This commit looks good Details
2b987d2461
Merge pull request 'refs #6443 migrate vn2008.cc_to_iban to util.accountNumberToIban' (!2006) from 6443-MigrateVn2008.cc_to_ibanToUtil into dev
Reviewed-on: #2006
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
2e009b6f25
refactor: refs #6609 sectorType description to code
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
2676cb840c
Merge branch 'dev' into 6609-sectorType
gitea/salix/pipeline/pr-dev This commit looks good Details
6a94a48a9d
refactor: refs #6609 sectorType description to code
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev This commit looks good Details
8e8ee39302
Merge pull request 'refactor: refs #6609 sectorType description to code' (!2008) from 6609-sectorType into dev
Reviewed-on: #2008
Reviewed-by: Robert Ferrús <robert@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
cd613c770c
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/pr-dev This commit looks good Details
30069ded15
fix: refs #6806 fix date filter
gitea/salix/pipeline/pr-dev This commit looks good Details
08728d3162
refs #6651 feat:add urlImage
gitea/salix/pipeline/pr-dev This commit looks good Details
02bf78d00a
feat: refs #6830 item_getLack origin
gitea/salix/pipeline/head There was a failure building this commit Details
f18191d6e9
refactor: refs#6706 root dir clean, minimist dep removed
gitea/salix/pipeline/head This commit looks good Details
26d4dbbe34
fix: refs#6706 docker-compose.yml fixes
gitea/salix/pipeline/head This commit looks good Details
e5f2be9f9c
Merge pull request '#6272 updateFiscalData' (!2001) from 6272-updateFiscalData into dev
Reviewed-on: #2001
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
dcefc9d382
refs #6651 feat:add urlImage
gitea/salix/pipeline/pr-dev This commit looks good Details
3e57bf2b34
refs #6791 remake negativeBases
gitea/salix/pipeline/pr-dev This commit looks good Details
1597f17230
refs #6791 remove intro
gitea/salix/pipeline/pr-dev This commit looks good Details
e03e871529
Merge branch 'dev' into 6791-negativeNickname
gitea/salix/pipeline/head This commit looks good Details
3ee63e489e
Merge pull request 'refs #6791 remake negativeBases' (!2017) from 6791-negativeNickname into dev
Reviewed-on: #2017
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
e0de498f65
fix: refs #6379 add Error & locale
gitea/salix/pipeline/pr-dev This commit looks good Details
362d825202
fix: refs #6443 #6444 #6445 ChangeRevokeToGrant
gitea/salix/pipeline/head This commit looks good Details
e96b14ad04
Merge pull request '#6806 fix lastEntriesFilter' (!2013) from 6806-fixEntryFilter into dev
Reviewed-on: #2013
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
222335809e
Merge branch 'dev' into 6443-6444-6445-fix-permissions
gitea/salix/pipeline/head This commit looks good Details
a0599403c8
Merge pull request 'fix: refs #6443 #6444 #6445 ChangeRevokeToGrant' (!2019) from 6443-6444-6445-fix-permissions into dev
Reviewed-on: #2019
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
1f99450ecb
Merge branch 'dev' into 6651_itemShelving_get
gitea/salix/pipeline/head This commit looks good Details
278337dc97
Merge pull request 'refs #6651 feat:add urlImage' (!2015) from 6651_itemShelving_get into dev
Reviewed-on: #2015
Reviewed-by: Carlos Andrés <carlosap@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
b06f80e091
refs #6446 Delete function nz from db
gitea/salix/pipeline/pr-dev This commit looks good Details
d60a95feaa
fix: refs #6379 await & locale
gitea/salix/pipeline/head This commit looks good Details
d7e51e01a2
Merge pull request '#6379 fixDriverRouteEmail' (!2018) from 6379-fixDriverRouteEmail into dev
Reviewed-on: #2018
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
534b5bb05a
fix: refs #6106 where filter
gitea/salix/pipeline/pr-dev This commit looks good Details
474c616b86
Merge branch 'dev' into 6446-Delete-function-nz-from-DB
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev This commit looks good Details
0ed5a0ff16
Merge pull request 'refs #6446 Delete function nz from db' (!2022) from 6446-Delete-function-nz-from-DB into dev
Reviewed-on: #2022
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
97f02187e3
Merge branch 'dev' into 6184-saveCmr
gitea/salix/pipeline/head This commit looks good Details
8f4b901818
Merge pull request 'refs #6184 saveCmr' (!1788) from 6184-saveCmr into dev
Reviewed-on: #1788
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
a897a05e8b
feat: refs#6685RestoreViewCredit
gitea/salix/pipeline/head There was a failure building this commit Details
5b137ad825
Merge pull request 'feat: refs #6685 RestoreViewCredit' (!2028) from 6685-fixRestoreViewCredit into dev
Reviewed-on: #2028
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/pr-dev Build queued... Details
3b35e4dae8
refs#6685 RestoreViewCredit
gitea/salix/pipeline/pr-dev This commit looks good Details
4feae72ee3
Merge branch 'dev' into 6685-fixRestoreViewCredit
gitea/salix/pipeline/pr-dev This commit looks good Details
e08fb3d229
fix: refs #6184 Minor change
gitea/salix/pipeline/pr-dev This commit looks good Details
41db1c924f
refactor: refs #6781 Deleted timeControlDevice
gitea/salix/pipeline/pr-dev This commit looks good Details
6116ada156
fix: refs #6813 remove inserts
gitea/salix/pipeline/pr-dev This commit looks good Details
744171dd4c
fix: refs #6184 Requested changes
gitea/salix/pipeline/head There was a failure building this commit Details
995e249495
Merge pull request '#6106 where filter' (!2024) from 6106-fixSignView into dev
Reviewed-on: #2024
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
b449da28ef
Merge branch 'dev' into 6184-externalCmr
gitea/salix/pipeline/head There was a failure building this commit Details
bbb3f3807a
Merge pull request 'fix: refs #6184 Minor change' (!2031) from 6184-externalCmr into dev
Reviewed-on: #2031
Reviewed-by: Alex Moreno <alexm@verdnatura.es>
gitea/salix/pipeline/head There was a failure building this commit Details
4f9b46346f
fix: refs#6706 back tests spec timeout reduced
gitea/salix/pipeline/pr-dev This commit looks good Details
185cc4f17f
feat: refs #6693 revisar triggers
gitea/salix/pipeline/pr-dev This commit looks good Details
68034fc404
Merge branch 'dev' into 6685-fixRestoreViewCredit
gitea/salix/pipeline/head This commit looks good Details
51b336d9f7
Merge pull request 'refs#6685 RestoreViewCredit' (!2030) from 6685-fixRestoreViewCredit into dev
Reviewed-on: #2030
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
579f2abe5b
fix: refs #6813 remove quotation marks
gitea/salix/pipeline/head This commit looks good Details
bf6d068830
Merge pull request 'refactor: refs #6781 Deleted timeControlDevice' (!2032) from 6781-timeControlDevice into dev
Reviewed-on: #2032
Reviewed-by: Carlos Andrés <carlosap@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev This commit looks good Details
9bd8c21660
Merge pull request '#6813 fix creditClient' (!2026) from 6813-fixCreditClient into dev
Reviewed-on: #2026
Reviewed-by: Javi Gallego <jgallego@verdnatura.es>
Reviewed-by: JAVIER SEGARRA MARTINEZ <jsegarra@verdnatura.es>
gitea/salix/pipeline/pr-dev This commit looks good Details
c9294680a5
Merge branch 'dev' into 6693-revisarTriggersPendientes
gitea/salix/pipeline/pr-dev This commit looks good Details
add5fedc4e
Merge branch 'dev' into 6830-item_getLackOrigin
gitea/salix/pipeline/head This commit looks good Details
11bbab6288
Merge pull request 'feat: refs #6830 item_getLack origin' (!2025) from 6830-item_getLackOrigin into dev
Reviewed-on: #2025
Reviewed-by: Guillermo Bonet <guillermo@verdnatura.es>
gitea/salix/pipeline/head This commit looks good Details
27d7a114e6
fix: refs#6706 package.json dbtest script removed
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev This commit looks good Details
19bbb4a4bf
fix: refs#6706 package.json deprecated scripts removed
gitea/salix/pipeline/pr-dev There was a failure building this commit Details
c2dadc09a2
feat: refs #6693 comprobar triggers
gitea/salix/pipeline/pr-dev This commit looks good Details
6fe6e35607
Merge branch 'dev' into 6693-revisarTriggersPendientes
gitea/salix/pipeline/head This commit looks good Details
gitea/salix/pipeline/pr-dev This commit looks good Details
f765fcca2c
Merge pull request 'feat: refs #6693 revisar triggers' (!2033) from 6693-revisarTriggersPendientes into dev
Reviewed-on: #2033
Reviewed-by: Robert Ferrús <robert@verdnatura.es>
jsegarra dismissed alexm’s review 2024-02-14 07:52:25 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

jsegarra force-pushed 2687_fix_travel_cloneWithEntries from 68e90f8607 to b9a624d9cd 2024-02-14 08:31:09 +00:00 Compare
jsegarra added 1 commit 2024-02-14 08:33:16 +00:00
gitea/salix/pipeline/pr-test There was a failure building this commit Details
fb1d11af17
refs #2687 feat: comments
jsegarra added 1 commit 2024-02-14 08:34:07 +00:00
jsegarra added 1 commit 2024-02-14 19:15:53 +00:00
gitea/salix/pipeline/pr-test This commit looks good Details
3ff3c812ed
refs #2687 fix: remove bad changes file
jsegarra requested review from alexm 2024-02-14 19:16:35 +00:00
alexm approved these changes 2024-02-15 06:28:17 +00:00
Dismissed
alexm requested review from guillermo 2024-02-15 06:28:25 +00:00
guillermo requested changes 2024-02-15 06:40:45 +00:00
guillermo left a comment
Member

Aquí algo

Aquí algo
@ -0,0 +1,13 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `util`.`tx_commit`(IN tx BOOL)
Member

El IN sobra, además, toda variable booleana tiene que tener el prefijo isXXX, hasXXXX (https://wiki.verdnatura.es/index.php/Convenciones_SQL#Booleano)

El IN sobra, además, toda variable booleana tiene que tener el prefijo isXXX, hasXXXX (https://wiki.verdnatura.es/index.php/Convenciones_SQL#Booleano)
jsegarra marked this conversation as resolved
@ -0,0 +2,4 @@
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `util`.`tx_commit`(IN tx BOOL)
BEGIN
/**
* Procedimiento para confirmar los cambios asociados a una transacción
Member

Lo de procedimiento es redundante, cambiar a: "Confirma los cambios asociados a una transacción."

Poner el punto al final del comentario, ya que se suele poner.

Lo de procedimiento es redundante, cambiar a: "Confirma los cambios asociados a una transacción." Poner el punto al final del comentario, ya que se suele poner.
Author
Member
d9756a0f3f5074cb516458f222b7edea7c7dc09f
jsegarra marked this conversation as resolved
@ -0,0 +4,4 @@
/**
* Procedimiento para confirmar los cambios asociados a una transacción
*
* @param tx BOOL es true si existe transacción asociada
Member

Aquí sobra lo de BOOL y la primera letra después de la variable debe de estar en mayúscula (https://wiki.verdnatura.es/index.php/Convenciones_SQL#Documentaci%C3%B3n)

Aquí sobra lo de BOOL y la primera letra después de la variable debe de estar en mayúscula (https://wiki.verdnatura.es/index.php/Convenciones_SQL#Documentaci%C3%B3n)
Author
Member
d9756a0f3f5074cb516458f222b7edea7c7dc09f
Author
Member
d9756a0f3f5074cb516458f222b7edea7c7dc09f
jsegarra marked this conversation as resolved
@ -0,0 +1,13 @@
DELIMITER $$
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `util`.`tx_rollback`(tx BOOL)
Member

Ahora una duda general para todos los procedimientos creados, por que has puesto tx? Entiendo que es lo mismo quitando la variable y quitando el if, si quieres lo llamas y si no no.

Ahora una duda general para todos los procedimientos creados, por que has puesto tx? Entiendo que es lo mismo quitando la variable y quitando el if, si quieres lo llamas y si no no.
Author
Member

Entiendo que hablas del if que hay definido dentro de cada procedure.
Se hace así para no tener que poner el IF desde cada llamada.
Si no he respondido a tu pregunta, nos juntamos

Entiendo que hablas del if que hay definido dentro de cada procedure. Se hace así para no tener que poner el IF desde cada llamada. Si no he respondido a tu pregunta, nos juntamos
@ -0,0 +2,4 @@
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `util`.`tx_rollback`(tx BOOL)
BEGIN
/**
* Procedimiento para deshacer los cambios asociados a una transacción
Member

Cambiar a: "Deshace los cambios asociados a una transacción."

Cambiar a: "Deshace los cambios asociados a una transacción."
Author
Member
d9756a0f3f5074cb516458f222b7edea7c7dc09f
jsegarra marked this conversation as resolved
@ -0,0 +1,15 @@
Member

Quitar esos 2 saltos de linea

Quitar esos 2 saltos de linea
Author
Member
d9756a0f3f5074cb516458f222b7edea7c7dc09f
jsegarra marked this conversation as resolved
@ -0,0 +4,4 @@
CREATE OR REPLACE DEFINER=`root`@`localhost` PROCEDURE `util`.`tx_start`(tx BOOL)
BEGIN
/**
* Procedimiento para iniciar una transacción
Member

Cambiar a: "Inicia una transacción."

Cambiar a: "Inicia una transacción."
Author
Member
d9756a0f3f5074cb516458f222b7edea7c7dc09f
jsegarra marked this conversation as resolved
Author
Member

@guillermo El formato de los procedimientos está extraido de este comentario de Juan
https://redmine.verdnatura.es/issues/2687#note-14

@guillermo El formato de los procedimientos está extraido de este comentario de Juan https://redmine.verdnatura.es/issues/2687#note-14
jsegarra added 2 commits 2024-02-15 06:50:50 +00:00
jsegarra dismissed alexm’s review 2024-02-15 06:50:50 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

Member

@guillermo El formato de los procedimientos está extraido de este comentario de Juan
https://redmine.verdnatura.es/issues/2687#note-14

Entonces supongo que habrá preferido ahorrar código en las llamadas al procedimiento que en el propio procedimiento, a la larga sí que es verdad que te ahorras código y a la hora de leer es mejor.

> @guillermo El formato de los procedimientos está extraido de este comentario de Juan > https://redmine.verdnatura.es/issues/2687#note-14 > > Entonces supongo que habrá preferido ahorrar código en las llamadas al procedimiento que en el propio procedimiento, a la larga sí que es verdad que te ahorras código y a la hora de leer es mejor.
jsegarra added 1 commit 2024-02-15 07:07:46 +00:00
gitea/salix/pipeline/pr-test This commit looks good Details
234ea26fe2
Merge branch 'test' into 2687_fix_travel_cloneWithEntries
guillermo approved these changes 2024-02-15 07:08:31 +00:00
alexm approved these changes 2024-02-15 07:09:33 +00:00
jsegarra merged commit 904692a11f into test 2024-02-15 07:34:50 +00:00
jsegarra deleted branch 2687_fix_travel_cloneWithEntries 2024-02-15 07:34:50 +00:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: verdnatura/salix#2021
No description provided.